Make max height of modification window taller

Author: intitni

Core/Sources/SuggestionWidget/SharedPanelView.swift

@@ -29,35 +29,36 @@ struct SharedPanelView: View {
     }
 
     var body: some View {
-        WithPerceptionTracking {
-            VStack(spacing: 0) {
-                if !store.alignTopToAnchor {
-                    Spacer()
-                        .frame(minHeight: 0, maxHeight: .infinity)
-                        .allowsHitTesting(false)
-                }
-
-                DynamicContent(store: store)
+        GeometryReader { geometry in
+            WithPerceptionTracking {
+                VStack(spacing: 0) {
+                    if !store.alignTopToAnchor {
+                        Spacer()
+                            .frame(minHeight: 0, maxHeight: .infinity)
+                            .allowsHitTesting(false)
+                    }
 
-                    .frame(maxWidth: .infinity, maxHeight: Style.panelHeight)
-                    .fixedSize(horizontal: false, vertical: true)
-                    .allowsHitTesting(store.isPanelDisplayed)
-                    .frame(maxWidth: .infinity)
+                    DynamicContent(store: store)
+                        .frame(maxWidth: .infinity, maxHeight: geometry.size.height)
+                        .fixedSize(horizontal: false, vertical: true)
+                        .allowsHitTesting(store.isPanelDisplayed)
+                        .layoutPriority(1)
 
-                if store.alignTopToAnchor {
-                    Spacer()
-                        .frame(minHeight: 0, maxHeight: .infinity)
-                        .allowsHitTesting(false)
+                    if store.alignTopToAnchor {
+                        Spacer()
+                            .frame(minHeight: 0, maxHeight: .infinity)
+                            .allowsHitTesting(false)
+                    }
                 }
+                .preferredColorScheme(store.colorScheme)
+                .opacity(store.opacity)
+                .animation(
+                    featureFlag: \.animationBCrashSuggestion,
+                    .easeInOut(duration: 0.2),
+                    value: store.isPanelDisplayed
+                )
+                .frame(maxWidth: Style.panelWidth, maxHeight: .infinity)
             }
-            .preferredColorScheme(store.colorScheme)
-            .opacity(store.opacity)
-            .animation(
-                featureFlag: \.animationBCrashSuggestion,
-                .easeInOut(duration: 0.2),
-                value: store.isPanelDisplayed
-            )
-            .frame(maxWidth: Style.panelWidth, maxHeight: Style.panelHeight)
         }
     }
 

Core/Sources/SuggestionWidget/SuggestionPanelContent/PromptToCodePanelView.swift

@@ -620,7 +620,7 @@ extension PromptToCodePanelView {
                             font: codeFont.value.nsFont,
                             droppingLeadingSpaces: hideCommonPrecedingSpaces,
                             proposedForegroundColor: codeForegroundColor,
-                            ignoreWholeLineChange: false
+                            ignoreWholeLineChangeInDiff: false
                         )
                         .frame(maxWidth: .infinity)
 

Core/Sources/SuggestionWidget/WidgetPositionStrategy.swift

@@ -9,6 +9,7 @@ public struct WidgetLocation: Equatable {
 
     var widgetFrame: CGRect
     var tabFrame: CGRect
+    var sharedPanelLocation: PanelLocation
     var defaultPanelLocation: PanelLocation
     var suggestionPanelLocation: PanelLocation?
 }
@@ -70,7 +71,7 @@ enum UpdateLocationStrategy {
                 .value(for: \.preferWidgetToStayInsideEditorWhenWidthGreaterThan),
             editorFrameExpendedSize: CGSize = .zero
         ) -> WidgetLocation {
-            return HorizontalMovable().framesForWindows(
+            var frames = HorizontalMovable().framesForWindows(
                 y: mainScreen.frame.height - editorFrame.maxY + Style.widgetPadding,
                 alignPanelTopToAnchor: false,
                 editorFrame: editorFrame,
@@ -80,6 +81,16 @@ enum UpdateLocationStrategy {
                 hideCircularWidget: hideCircularWidget,
                 editorFrameExpendedSize: editorFrameExpendedSize
             )
+
+            frames.sharedPanelLocation.frame.size.height = max(
+                frames.defaultPanelLocation.frame.height,
+                editorFrame.height - Style.widgetHeight
+            )
+            frames.defaultPanelLocation.frame.size.height = max(
+                frames.defaultPanelLocation.frame.height,
+                (editorFrame.height - Style.widgetHeight) / 2
+            )
+            return frames
         }
     }
 
@@ -155,6 +166,10 @@ enum UpdateLocationStrategy {
                 return .init(
                     widgetFrame: widgetFrameOnTheRightSide,
                     tabFrame: tabFrame,
+                    sharedPanelLocation: .init(
+                        frame: panelFrame,
+                        alignPanelTop: alignPanelTopToAnchor
+                    ),
                     defaultPanelLocation: .init(
                         frame: panelFrame,
                         alignPanelTop: alignPanelTopToAnchor
@@ -214,6 +229,10 @@ enum UpdateLocationStrategy {
                     return .init(
                         widgetFrame: widgetFrameOnTheLeftSide,
                         tabFrame: tabFrame,
+                        sharedPanelLocation: .init(
+                            frame: panelFrame,
+                            alignPanelTop: alignPanelTopToAnchor
+                        ),
                         defaultPanelLocation: .init(
                             frame: panelFrame,
                             alignPanelTop: alignPanelTopToAnchor
@@ -241,6 +260,10 @@ enum UpdateLocationStrategy {
                     return .init(
                         widgetFrame: widgetFrameOnTheRightSide,
                         tabFrame: tabFrame,
+                        sharedPanelLocation: .init(
+                            frame: panelFrame,
+                            alignPanelTop: alignPanelTopToAnchor
+                        ),
                         defaultPanelLocation: .init(
                             frame: panelFrame,
                             alignPanelTop: alignPanelTopToAnchor

Core/Sources/SuggestionWidget/WidgetWindowsController.swift

@@ -335,6 +335,7 @@ extension WidgetWindowsController {
                         return WidgetLocation(
                             widgetFrame: .zero,
                             tabFrame: .zero,
+                            sharedPanelLocation: .init(frame: .zero, alignPanelTop: false),
                             defaultPanelLocation: .init(frame: .zero, alignPanelTop: false)
                         )
                     }
@@ -479,7 +480,7 @@ extension WidgetWindowsController {
                 animate: animated
             )
             windows.sharedPanelWindow.setFrame(
-                widgetLocation.defaultPanelLocation.frame,
+                widgetLocation.sharedPanelLocation.frame,
                 display: false,
                 animate: animated
             )