You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Switched from the unsupported @endemolshinegroup/cosmiconfig-typescript-loader library with it's recommended replacement fork: codex-/cosmiconfig-typescript-loader.
Why
The unsupported library had conflicted ts-node dependencies that didn't allow it to work with newer versions of TypeScript.
Would be great to see this merged! This fixes that we can use ESM in the auto.config.ts file with package.json set to "type": "module", unless I'm mistaken
@hipstersmoothie Branch has been updated. Seems like pr-check and release checks failed for networking errors, not sure if that's expected or what's going on there. I see they're not required, so maybe normal.
I get 50 failing tests just running on the main branch, so I think something might be missing from the setup guide as to how to run them. Any suggestions? I did build first (yarn, yarn build, yarn test). Some of them are related to missing GitHub token, but there's a variety, some just failing expectations. I'm on a Mac if that matters. I'd like to get this resolved, but need to be able to get a passing test run without my changes before I can troubleshoot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Switched from the unsupported
@endemolshinegroup/cosmiconfig-typescript-loaderlibrary with it's recommended replacement fork: codex-/cosmiconfig-typescript-loader.Why
The unsupported library had conflicted
ts-nodedependencies that didn't allow it to work with newer versions of TypeScript.Fixes #2248
Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor