searchComponents: add namespace#151
Open
jrcastro2 wants to merge 1 commit into
Open
Conversation
jrcastro2
force-pushed
the
add-namespace-searchapp
branch
2 times, most recently
from
January 24, 2023 15:14
6cd94cc to
c5e73fe
Compare
jrcastro2
commented
Jan 24, 2023
| children: PropTypes.object, | ||
| modalOpen: PropTypes.bool, | ||
| resource: PropTypes.object.isRequired, | ||
| appName: PropTypes.string, |
Contributor
Author
There was a problem hiding this comment.
IMHO appName should be required to avoid having different admin views that can be potentially overriden by the same component, if this varabiable is missing. That's why I raise an error (see base.py). I will do the change unless someone has a different opinion
jrcastro2
force-pushed
the
add-namespace-searchapp
branch
from
January 25, 2023 10:37
c5e73fe to
37e9263
Compare
This was referenced Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.