Skip to content

i18n: v14 wrap missing strings #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Samk13 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

i18n: v14 wrap missing strings #3413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions invenio_app_rdm/administration/audit_logs/audit_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ class AuditLogListView(AdminResourceListView):
name = "audit-logs"
resource_config = "audit_log_resource"

title = "Audit Logs"
menu_label = "Audit Logs"
category = "Logs"
title = _("Audit Logs")
menu_label = _("Audit Logs")
category = _("Logs")
pid_path = "id"
icon = "file alternate"
template = "invenio_app_rdm/administration/audit_logs.html"
Expand Down
4 changes: 2 additions & 2 deletions invenio_app_rdm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ def github_link_render(record):
)
"""Files integrity report template"""

APP_RDM_FILES_INTEGRITY_REPORT_SUBJECT = "Files integrity report"
APP_RDM_FILES_INTEGRITY_REPORT_SUBJECT = _("Files integrity report")
"""Files integrity report subject"""

APP_RDM_ADMIN_EMAIL_RECIPIENT = "info@inveniosoftware.org"
Expand Down Expand Up @@ -1491,7 +1491,7 @@ def github_link_render(record):
"""Administration base template."""


APP_RDM_SUBCOMMUNITIES_LABEL = "Subcommunities"
APP_RDM_SUBCOMMUNITIES_LABEL = _("Subcommunities")
"""Label for the subcommunities in the community browse page."""

RDM_DETAIL_SIDE_BAR_MANAGE_ATTRIBUTES_EXTENSION_TEMPLATE = None
Expand Down
2 changes: 1 addition & 1 deletion ...pp_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/components/DisplayPartOfCommunities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const DisplayPartOfCommunities = ({ communities }) => {
{(community.children?.allow || community.parent !== undefined) && (
<Popup
trigger={<Icon name="check outline circle" color="green mr-0" />}
content="Verified community"
content={i18next.t("Verified community")}
position="top center"
/>
)}
Expand Down
13 changes: 8 additions & 5 deletions ...dm/theme/assets/semantic-ui/js/invenio_app_rdm/components/RecordDeletion/DeletionModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ export class DeletionModal extends Component {
deletionRequestSchema = (immediateDeletionAllowed) => {
if (immediateDeletionAllowed) {
return Yup.object({
reason: Yup.string().required("Required"),
reason: Yup.string().required(i18next.t("Required")),
});
} else {
return Yup.object({
reason: Yup.string().required("Required"),
reason: Yup.string().required(i18next.t("Required")),
comment: Yup.string()
.min(25, "Please write at least 25 characters")
.required("Required"),
.min(25, i18next.t("Please write at least 25 characters"))
.required(i18next.t("Required")),
});
}
};
Expand All @@ -110,7 +110,10 @@ export class DeletionModal extends Component {
comment: values.comment,
};
if (!("request_deletion" in record.links)) {
this.setState({ error: "Could not submit deletion request", loading: false });
this.setState({
error: i18next.t("Could not submit deletion request"),
loading: false,
});
return;
}
this.cancellableAction = withCancel(
Expand Down
2 changes: 1 addition & 1 deletion ...app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/landing_page/RecordCommunitiesList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class RecordCommunitiesList extends Component {
community.parent !== undefined) && (
<p className="ml-5 display-inline-block">
<Popup
content="Verified community"
content={i18next.t("Verified community")}
trigger={
<Icon
size="small"
Expand Down
Loading