files: hide archive button over the size cap#3447
Open
slint wants to merge 1 commit into
Open
Conversation
slint
force-pushed
the
feat/archive-link-gate
branch
from
89c326a to
bdd2ff5
Compare
OliverGeneser
approved these changes
May 8, 2026
| <i class="file archive icon button" aria-hidden="true"></i> {{_("Download all")}} | ||
| </a> | ||
| {%- set archive_max_size = config.RECORDS_RESOURCES_ARCHIVE_DOWNLOAD_MAX_SIZE %} | ||
| {%- set archive_total_bytes = files|map(attribute='size', default=0)|sum() %} |
Contributor
There was a problem hiding this comment.
Should we add record.files.total_bytes to the template context?
Member
Author
There was a problem hiding this comment.
I tried to, but we're apparently passing a serialized record... I guess it's for permission purposes as well, plus it's a bit dangerous to have "live" API/model instances in templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on inveniosoftware/invenio-records-resources#682