Skip to content

fix ci v2#178

Open
utnapischtim wants to merge 3 commits into
inveniosoftware:masterfrom
utnapischtim:fix-ci-v2
Open

fix ci v2#178
utnapischtim wants to merge 3 commits into
inveniosoftware:masterfrom
utnapischtim:fix-ci-v2

Conversation

@utnapischtim
Copy link
Copy Markdown
Contributor

  • fix(tests): option not exists
  • fix(tests): sqlalchemy.exc.ArgumentError

* invenio-db>=2.3.0 uses SQLALCHEMY_ENGINE_OPTIONS to set connect_args.
  the original app fixture creation uses sqlite which doesn't have this
  option.

* the invenio-admin tests have still to use the old app fixture, because
  otherwise the tests fail. the menu is not created correctly. since
  invenio-admin is deprecated the tests will not be fixed in another way
* Textual SQL expression 'SELECT setval(pg_get_seri...' should be
  explicitly declared as text('SELECT setval(pg_get_seri...')

* unclear why this doesn't popped up before. it should have!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant