Skip to content

updated edition text position #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpsherva merged 2 commits into from
Jul 15, 2026
Merged

updated edition text position #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fb075f
updated edition text position
callumlewis05 Jul 8, 2026
0c16cff
updated test snapshots
callumlewis05 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/modules/Literature/LiteratureEdition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ class LiteratureEdition extends Component {

return withLabel ? (
<>
<label>edition</label> {edition}
{edition} <label>edition</label>
</>
) : (
`ed. ${edition}`
`${edition} ed.`
);
}
}
Expand Down
6 changes: 3 additions & 3 deletions .../PatronCurrentBorrowingRequests/__snapshots__/PatronCurrentBorrowingRequests.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ exports[`PatronCurrentBorrowingRequests tests should render patron borrowing req
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down Expand Up @@ -1043,7 +1043,7 @@ exports[`PatronCurrentBorrowingRequests tests should render patron borrowing req
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down Expand Up @@ -2067,7 +2067,7 @@ exports[`PatronCurrentBorrowingRequests tests should render the see all button w
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down
6 changes: 3 additions & 3 deletions ...etails/PatronPastBorrowingRequests/__snapshots__/PatronPastBorrowingRequests.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ exports[`PatronPastBorrowingRequests tests should render patron borrowing reques
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down Expand Up @@ -1042,7 +1042,7 @@ exports[`PatronPastBorrowingRequests tests should render patron borrowing reques
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down Expand Up @@ -2054,7 +2054,7 @@ exports[`PatronPastBorrowingRequests tests should render the see all button when
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down
6 changes: 3 additions & 3 deletions ...ice/Patron/PatronDetails/PatronPendingLoans/__snapshots__/PatronPendingLoans.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ exports[`PatronLoans tests should render patron loans 1`] = `
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down Expand Up @@ -868,7 +868,7 @@ exports[`PatronLoans tests should render patron loans 1`] = `
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down Expand Up @@ -1710,7 +1710,7 @@ exports[`PatronLoans tests should render the see all button when showing only a
edition="1"
withLabel={false}
>
ed. 1
1 ed.
</LiteratureEdition>
</Overridable(LiteratureEdition)>
-
Expand Down
Loading