fix: handle null configurations key in reconfigure dart config#434
Open
Harshit-0413 wants to merge 1 commit intoinvertase:mainfrom
Open
fix: handle null configurations key in reconfigure dart config#434Harshit-0413 wants to merge 1 commit intoinvertase:mainfrom
Harshit-0413 wants to merge 1 commit intoinvertase:mainfrom
Conversation
|
|
There was a problem hiding this comment.
Code Review
This pull request updates the reconfigure.dart file to handle cases where the configurations map might be null. It introduces a null-safe cast and a check that returns an empty list if the configurations are missing, preventing potential runtime errors. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #353
Problem
When running
flutterfire configuretwice and choosing to reuse theexisting
firebase.json, the command crashes with:Exception: type 'Null' is not a subtype of type 'Map<String, dynamic>' in type cast
This happens in
_writeDartConfigurationFileinreconfigure.dartwhere
map[kConfigurations]is cast directly without a null check.If the existing
firebase.jsonwas written by an older CLI versionthat didn't include the
configurationskey, the cast throws.Fix
Cast
map[kConfigurations]as nullableMap<String, dynamic>?andreturn early if null, skipping that entry gracefully.