test(ios): e2e orchestration flake mitigation

Fix reconnect send race after WS grace recovery under saturated macOS CI
load: assign mocha-remote client before connection emit, single server-side
pull-coverage, non-throwing Server.send, and Jet retry on No client connected.
Regenerate yarn.lock after patch updates; document in okf-bundle.

Author: mikehardy

.yarn/patches/jet-npm-0.9.0-dev.13-3321aeea6e.patch

@@ -1,8 +1,8 @@
 diff --git a/lib/commonjs/cli.js b/lib/commonjs/cli.js
-index 35c04da87c63a79bc26707aaffe3156fb98eca79..5ef301146d35adf38a430f26d78a66f196d781f5 100644
+index 35c04da87c63a79bc26707aaffe3156fb98eca79..41de2f4918095084eca259e334d4deaa82f4bf96 100644
 --- a/lib/commonjs/cli.js
 +++ b/lib/commonjs/cli.js
-@@ -72,22 +72,68 @@ function cleanup() {
+@@ -72,22 +72,64 @@ function cleanup() {
    });
  }
  async function startServer(server, config, after) {
@@ -22,10 +22,6 @@ index 35c04da87c63a79bc26707aaffe3156fb98eca79..5ef301146d35adf38a430f26d78a66f1
 +      reconnectGraceTimer = null;
 +      pendingDisconnectCode = null;
 +      console.warn(`[jet-ws] reconnect_recovered code=${recoveredCode} elapsed_ms=${elapsedMs}`);
-+      if (config.coverage && server.send) {
-+        console.warn(`[jet-coverage] proactive pull-coverage after reconnect`);
-+        server.send({ action: 'pull-coverage' });
-+      }
 +    }
    });
    server.on('disconnection', (_, code, reason) => {
@@ -75,7 +71,7 @@ index 35c04da87c63a79bc26707aaffe3156fb98eca79..5ef301146d35adf38a430f26d78a66f1
    });
    server.on('error', error => {
      if (error instanceof _mochaRemoteServer.ClientError) {
-@@ -100,6 +146,14 @@ async function startServer(server, config, after) {
+@@ -100,6 +142,14 @@ async function startServer(server, config, after) {
        cleanup();
      }
    });
@@ -90,7 +86,7 @@ index 35c04da87c63a79bc26707aaffe3156fb98eca79..5ef301146d35adf38a430f26d78a66f1
    cleanupTasks.add(async () => {
      if (server.listening) {
        await server.stop();
-@@ -129,8 +183,13 @@ function attachHttpServer(wss) {
+@@ -129,8 +179,13 @@ function attachHttpServer(wss) {
        });
        req.on('end', () => {
          try {
@@ -105,7 +101,7 @@ index 35c04da87c63a79bc26707aaffe3156fb98eca79..5ef301146d35adf38a430f26d78a66f1
            res.end(JSON.stringify({
              message: 'OK'
            }));
-@@ -302,12 +361,11 @@ function attachHttpServer(wss) {
+@@ -302,12 +357,11 @@ function attachHttpServer(wss) {
      slow: finalConfig.slow
    });
    return startServer(server, finalConfig, target.after).then(() => {
@@ -120,68 +116,3 @@ index 35c04da87c63a79bc26707aaffe3156fb98eca79..5ef301146d35adf38a430f26d78a66f1
          await cleanup();
          process.exit(failures > 0 ? 1 : 0);
        });
-diff --git a/lib/commonjs/index.js b/lib/commonjs/index.js
-index a72380ed2ace01b19b028bb8e6f9d29dc3affbcd..030475cff75349b2b7f820cf8a3556fb1d7bea45 100644
---- a/lib/commonjs/index.js
-+++ b/lib/commonjs/index.js
-@@ -63,15 +63,7 @@ function JetProvider(props) {
-         });
-         after(async () => {
-           if (_config.coverage) {
--            const coverage = global.__coverage__ ?? {};
--            const url = (props.url ?? 'ws://localhost:8090').replace('ws://', 'http://') + '/coverage';
--            return fetch(url, {
--              method: 'POST',
--              headers: {
--                'Content-Type': 'application/json'
--              },
--              body: JSON.stringify(coverage)
--            });
-+            return client.uploadCoverage();
-           }
-           return Promise.resolve();
-         });
-diff --git a/lib/module/index.js b/lib/module/index.js
-index 897b62288ae128e1ce071142fa3de136caa99239..2f8dd9edf79f6c095b4357307bdac5ea1efa00eb 100644
---- a/lib/module/index.js
-+++ b/lib/module/index.js
-@@ -51,15 +51,7 @@ export function JetProvider(props) {
-         });
-         after(async () => {
-           if (_config.coverage) {
--            const coverage = global.__coverage__ ?? {};
--            const url = (props.url ?? 'ws://localhost:8090').replace('ws://', 'http://') + '/coverage';
--            return fetch(url, {
--              method: 'POST',
--              headers: {
--                'Content-Type': 'application/json'
--              },
--              body: JSON.stringify(coverage)
--            });
-+            return client.uploadCoverage();
-           }
-           return Promise.resolve();
-         });
-diff --git a/src/index.tsx b/src/index.tsx
-index 1b28aca3fe817fee3e8701ac5096df6fc608bc39..17c631309f88a8017a9fd01e3420df2b4bab140e 100644
---- a/src/index.tsx
-+++ b/src/index.tsx
-@@ -82,17 +82,7 @@ export function JetProvider(props: JetProviderProps): React.JSX.Element {
-         });
-         after(async () => {
-           if (_config.coverage) {
--            const coverage = (global as any).__coverage__ ?? {};
--            const url =
--              (props.url ?? 'ws://localhost:8090').replace('ws://', 'http://') +
--              '/coverage';
--            return fetch(url, {
--              method: 'POST',
--              headers: {
--                'Content-Type': 'application/json',
--              },
--              body: JSON.stringify(coverage),
--            });
-+            return client.uploadCoverage();
-           }
-           return Promise.resolve();
-         });

.yarn/patches/mocha-remote-server-npm-1.13.2-619a29d2e3.patch

@@ -1,8 +1,8 @@
 diff --git a/dist/Server.js b/dist/Server.js
-index ad9debe2086ab9b96e97a69aec966da8114ad102..1c7856a7b8983cc71bad33465bae1e8182bb016d 100644
+index ad9debe2086ab9b96e97a69aec966da8114ad102..51cc18658e11d5aec5d5a76c4eb5f965b32a587d 100644
 --- a/dist/Server.js
 +++ b/dist/Server.js
-@@ -73,6 +73,10 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+@@ -73,38 +73,59 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
          /** The options to send to the next connecting running client */
          this.clientOptions = {};
          this._listening = false;
@@ -12,32 +12,53 @@ index ad9debe2086ab9b96e97a69aec966da8114ad102..1c7856a7b8983cc71bad33465bae1e81
 +        this._maxInboundBufferBytes = 50 * 1024 * 1024;
          this.handleConnection = (ws, req) => {
              this.debug("Client connected");
-             // Check that the protocol matches
-@@ -88,6 +92,15 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+-            // Check that the protocol matches
+             const expectedProtocol = `mocha-remote-${this.config.id}`;
+-            ws.on("close", (code, reason) => {
+-                this.emit("disconnection", ws, code, reason.toString());
+-            });
+-            // Signal that a client has connected
+-            this.emit("connection", ws, req);
+-            // Disconnect if the protocol mismatch
++
+             if (ws.protocol !== expectedProtocol) {
+-                // Protocol mismatch - close the connection
                  ws.close(1002, `Expected "${expectedProtocol}" protocol got "${ws.protocol}"`);
                  return;
              }
++
++            const wasReconnecting = Boolean(this._clientResetTimer);
 +            if (this._clientResetTimer) {
 +                clearTimeout(this._clientResetTimer);
 +                this._clientResetTimer = null;
 +                console.warn(`[mocha-remote-ws] reconnect_recovered preserving_runner`);
-+                if (this.runner && !this._awaitingInitialClientRun) {
-+                    console.warn(`[jet-coverage] server send pull-coverage after reconnect`);
-+                    this.send({ action: "pull-coverage" });
-+                }
 +            }
++
              if (this.client) {
                  this.debug("A client was already connected");
                  this.client.close(1013 /* try again later */, "Got a connection from another client");
-@@ -96,15 +109,22 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+-                // Reset the server to prepare for the incoming client
+                 this.handleReset();
              }
-             // Hang onto the client
+-            // Hang onto the client
++
              this.client = ws;
 +            this._inboundBuffer = "";
++            this.client.on("close", (code, reason) => {
++                this.emit("disconnection", ws, code, reason.toString());
++            });
              this.client.on("message", this.handleMessage.bind(this, this.client));
 -            this.client.once("close", this.handleReset);
+-            // If we already have a runner, it can run now that we have a client
 +            this.client.once("close", (code) => this.handleClientDisconnect(code));
-             // If we already have a runner, it can run now that we have a client
++
++            this.emit("connection", ws, req);
++
++            if (wasReconnecting && this.runner && !this._awaitingInitialClientRun) {
++                console.warn(`[jet-coverage] server send pull-coverage after reconnect`);
++                this.send({ action: "pull-coverage" });
++            }
++
              if (this.runner) {
 -                if (this.clientOptions) {
 -                    this.send({ action: "run", options: this.clientOptions });
@@ -56,7 +77,7 @@ index ad9debe2086ab9b96e97a69aec966da8114ad102..1c7856a7b8983cc71bad33465bae1e81
                  }
              }
              else if (this.config.autoRun) {
-@@ -115,8 +135,29 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+@@ -115,8 +136,29 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
              }
          };
          this.handleMessage = (ws, message) => {
@@ -87,7 +108,7 @@ index ad9debe2086ab9b96e97a69aec966da8114ad102..1c7856a7b8983cc71bad33465bae1e81
                  if (typeof msg.action !== "string") {
                      throw new Error("Expected message to have an action property");
                  }
-@@ -130,6 +171,18 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+@@ -130,6 +172,18 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
                          throw new Error("Received a message from the client, but server wasn't running");
                      }
                  }
@@ -106,7 +127,7 @@ index ad9debe2086ab9b96e97a69aec966da8114ad102..1c7856a7b8983cc71bad33465bae1e81
                  else if (msg.action === "error") {
                      if (typeof msg.message !== "string") {
                          throw new Error("Expected 'error' action to have an error argument with a message");
-@@ -152,10 +205,45 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+@@ -152,10 +206,45 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
                  }
              }
          };
@@ -152,46 +173,21 @@ index ad9debe2086ab9b96e97a69aec966da8114ad102..1c7856a7b8983cc71bad33465bae1e81
              // Forget everything about the runner and the client
              const { runner, client } = this;
              delete this.runner;
-@@ -263,6 +351,7 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+@@ -263,6 +352,7 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
          // this.runner = new Mocha.Runner(this.suite, this.options.delay || false);
          // TODO: Stub this to match the Runner's interface even better
          this.runner = new FakeRunner_1.FakeRunner();
 +        this._awaitingInitialClientRun = true;
          // Attach event listeners to update stats
          (0, stats_collector_1.createStatsCollector)(this.runner);
          // Set the client options, to be passed to the next running client
-diff --git a/dist/serialization.js b/dist/serialization.js
-index b2dd290111197907d125e3151a4a965e9fe0528d..a52262f30458c2d0406e0809252f345ce8a2b60e 100644
---- a/dist/serialization.js
-+++ b/dist/serialization.js
-@@ -45,9 +45,29 @@ function createReviver() {
-     };
- }
- exports.createReviver = createReviver;
-+function isIncompleteParseError(err) {
-+    if (!(err instanceof SyntaxError)) {
-+        return false;
-+    }
-+    const message = err.message || "";
-+    return (/Unexpected end of JSON input|Unterminated string in JSON|Unexpected token/.test(message));
-+}
-+exports.isIncompleteParseError = isIncompleteParseError;
- function deserialize(text, reviver = createReviver()) {
-     debug("Deserializing %s", text);
-     return flatted_1.default.parse(text, reviver);
- }
- exports.deserialize = deserialize;
-+function tryDeserialize(text, reviver = createReviver()) {
-+    try {
-+        return { ok: true, value: deserialize(text, reviver) };
-+    }
-+    catch (err) {
-+        if (err instanceof Error && isIncompleteParseError(err)) {
-+            return { ok: false, incomplete: true, error: err };
-+        }
-+        return { ok: false, incomplete: false, error: err };
-+    }
-+}
-+exports.tryDeserialize = tryDeserialize;
- //# sourceMappingURL=serialization.js.map
-\ No newline at end of file
+@@ -370,7 +460,8 @@ class Server extends ServerEventEmitter_1.ServerEventEmitter {
+             this.client.send(data);
+         }
+         else {
+-            throw new Error("No client connected");
++            const readyState = this.client?.readyState ?? "no-client";
++            console.warn(`[mocha-remote-ws] send skipped action=${msg.action} readyState=${readyState}`);
+         }
+     }
+     /**

okf-bundle/ci-workflows/android.md

@@ -42,6 +42,31 @@ Full inventory: [detox-patches.md](detox-patches.md).
 
 **Orchestration retry:** `firebase.test.js` still retries on `RETRYABLE_DISCONNECT`; attempt 2 can pass all tests even when attempt 1's teardown logged adb noise.
 
+## CI failure: Jet JSON / WS protocol desync (Unexpected end of JSON input)
+
+Observed on Android CI under load (e.g. [run 28044822049](https://github.com/invertase/react-native-firebase/actions/runs/28044822049)): Jet runs only ~24 tests before the mocha-remote transport desyncs — often after a transient 1006 under high `loadavg`.
+
+**Symptom**
+
+```
+[🟥] Unexpected end of JSON input
+[mocha-remote-ws] parse_buffering ...
+```
+
+**Cause** — TCP/WebSocket chunks can split JSON frames; under I/O pressure, partial reads are more common. Unbuffered `JSON.parse` on each chunk corrupts the protocol stream.
+
+**Mitigations (patches + orchestration)**
+
+| Change | Location |
+|--------|----------|
+| Inbound parse buffer + `tryDeserialize` / `parse_skip` logging | mocha-remote-server patch → `Server.js` |
+| Outbound queue flushed on reconnect | mocha-remote-client patch |
+| `JET_PROTOCOL_ERROR_RE` → retryable Jet session (attempt 2) | `tests/e2e/firebase.test.js` |
+| Cold-boot ready wait + post-boot settle before Jet attempt 1 | `firebase.test.js` (`waitForAndroidEmulatorReady`, `RNFB_ANDROID_BOOT_SETTLE_MS`) |
+| Load gate before starting Jet (threshold 5, 3 consecutive polls) | `firebase.test.js` |
+
+**Patch workflow reminder** — after editing `tests/node_modules/jet` or `mocha-remote-*`, run `yarn patch-commit` **and** `yarn install` from repo root so `yarn.lock` patch hashes update. CI applies patches from the lockfile, not live `node_modules` edits.
+
 ## Troubleshooting
 
 | Symptom | Likely cause |

okf-bundle/ci-workflows/detox-patches.md

@@ -17,7 +17,7 @@ Patches are maintained in-repo (including by agents). Prefer **editing the patch
 | Ignore missing adb reverse on teardown | `ADB.js` | Android | Jet WS 1006 triggers mid-run `reverse --remove` → adb exit 1 |
 | **2× device-registry lock stale** | `ExclusiveLockfile.js` | iOS, macOS, Android | `proper-lockfile` `ECOMPROMISED` before tests start |
 
-Related non-Detox patches: `jet`, `mocha-remote-client`, `mocha-remote-server` — WS reconnect grace, coverage handshake (`coverage-ready` / `pull-coverage`), client keepalive. See [coverage design](../testing/coverage-design.md) and [iOS CI — issues 6–8](ios.md#6-jet-websocket-disconnect-1006--1001).
+Related non-Detox patches: `jet`, `mocha-remote-client`, `mocha-remote-server` — WS reconnect grace, coverage handshake (`coverage-ready` / `pull-coverage`), client keepalive, server/client parse buffering, reconnect client assignment order. See [coverage design](../testing/coverage-design.md) and [iOS CI — issues 6–8](ios.md#6-jet-websocket-disconnect-1006--1001).
 
 ## Device registry lock (`ECOMPROMISED`)
 
@@ -92,7 +92,7 @@ SRC=tests/node_modules/detox
 yarn patch-commit -s "$PATCH_DIR"   # non-interactive when using /bin/cp -f, not plain cp
 ```
 
-3. `yarn install` from repo root and confirm the change in `tests/node_modules/detox/...`.
+3. `yarn install` from repo root and confirm the change in `tests/node_modules/...` **and** updated `yarn.lock` patch resolution hashes.
 4. Update this doc and platform pages (`ios.md`, `android.md`) if behaviour or file list changes.
 
 **Detox version bump:** change `tests/package.json`, run `yarn`, re-apply all hunks (or redo the headless flow from a fresh `yarn patch`), run iOS + Android E2E.