test: turn on modular deprecation strict mode for e2e suite

remove the entanglement with retries at same time - now that
strict mode is on all the time and we are not actively finding
new namespaced-API usage, we don't need to disable retries
for strict mode as it should be more rare / less need for speed

Author: mikehardy

tests/app.js

@@ -69,7 +69,7 @@ ErrorUtils.setGlobalHandler((err, isFatal) => {
 
 function loadTests(_) {
   describe('React Native Firebase', function () {
-    if (!globalThis.RNFBDebug && !globalThis.RNFB_MODULAR_DEPRECATION_STRICT_MODE) {
+    if (!globalThis.RNFBDebug) {
       // Only retry tests if not debugging or hunting deprecated API usage locally,
       // otherwise it gets annoying to debug.
       this.retries(4);

tests/globals.js

@@ -49,7 +49,7 @@ import shouldMatchers from 'should';
 globalThis.RNFBDebug = false;
 
 // this may be used to locate modular API errors quickly
-globalThis.RNFB_MODULAR_DEPRECATION_STRICT_MODE = false;
+globalThis.RNFB_MODULAR_DEPRECATION_STRICT_MODE = true;
 
 // Needed for Platform.Other session storage
 import AsyncStorage from '@react-native-async-storage/async-storage';