invertase
diff --git a/‎.github/scripts/compare-types/packages/remote-config/config.ts‎
Lines changed: 27 additions & 110 deletions b/‎.github/scripts/compare-types/packages/remote-config/config.ts‎
Lines changed: 27 additions & 110 deletions
diff --git a/‎.github/scripts/compare-types/src/registry.ts‎
Lines changed: 19 additions & 42 deletions b/‎.github/scripts/compare-types/src/registry.ts‎
Lines changed: 19 additions & 42 deletions
diff --git a/‎packages/app/lib/common/index.ts‎
Lines changed: 30 additions & 2 deletions b/‎packages/app/lib/common/index.ts‎
Lines changed: 30 additions & 2 deletions
@@ -16,113 +16,49 @@
 import type { PackageConfig } from '../../src/types';
 
 const config: PackageConfig = {
-  // ---------------------------------------------------------------------------
-  // Name mapping
-  // ---------------------------------------------------------------------------
-  // ValueSource is defined as `ValueSource` in the source files of both
-  // packages, but the RN Firebase index.d.ts re-exports it under the alias
-  // `ModularValueSource` to avoid a naming clash with the namespaced API.
-  // Since we compare source files directly, both sides see `ValueSource`
-  // and they match — no mapping entry is needed here.
-  nameMapping: {},
-
-  // ---------------------------------------------------------------------------
-  // Missing in RN Firebase
-  // ---------------------------------------------------------------------------
   missingInRN: [
-    // Currently empty — all firebase-js-sdk remote-config exports are present
-    // in the RN Firebase modular API (though some have different shapes; see below).
-  ],
-
-  // ---------------------------------------------------------------------------
-  // Extra in RN Firebase
-  // ---------------------------------------------------------------------------
-  extraInRN: [
     {
-      name: 'ConfigValues',
+      name: 'FetchResponse',
       reason:
-        'RN Firebase-specific type alias for `{ [key: string]: Value }`, ' +
-        'semantically equivalent to `Record<string, Value>` used in the ' +
-        'firebase-js-sdk. Kept for backwards compatibility.',
+        'Part of the firebase-js-sdk initialization options surface. RN Firebase ' +
+        'does not expose `RemoteConfigOptions` or the web fetch-response bootstrap path.',
     },
     {
-      name: 'RemoteConfigLogLevel',
+      name: 'FetchType',
       reason:
-        'Type alias for `LogLevel` exposed for API clarity (mirrors the ' +
-        'firebase-js-sdk internal RemoteConfigLogLevel). Not part of the ' +
-        'firebase-js-sdk public API.',
+        'Used by the firebase-js-sdk web fetch-response bootstrap path. RN Firebase ' +
+        'does not expose that initialization surface.',
     },
     {
-      name: 'LastFetchStatus',
+      name: 'FirebaseExperimentDescription',
       reason:
-        'Namespaced constant re-exported from statics.d.ts for backwards ' +
-        'compatibility with the class-based (namespaced) API. Not part of ' +
-        'the firebase-js-sdk modular API.',
+        'Only used by the firebase-js-sdk fetch-response bootstrap types. RN Firebase ' +
+        'does not expose that initialization surface.',
     },
     {
-      name: 'ValueSource',
+      name: 'FirebaseRemoteConfigObject',
       reason:
-        'Namespaced constant re-exported from statics.d.ts for backwards ' +
-        'compatibility with the class-based (namespaced) API. The modular ' +
-        '`ValueSource` type alias (matching firebase-js-sdk) is also exported ' +
-        'separately from types/modular.d.ts.',
+        'Only used by the firebase-js-sdk fetch-response bootstrap types. RN Firebase ' +
+        'does not expose that initialization surface.',
     },
     {
-      name: 'fetch',
+      name: 'RemoteConfigOptions',
       reason:
-        'Legacy RN Firebase fetch API that accepts an optional ' +
-        '`expirationDurationSeconds` parameter. Prefer `fetchConfig()` which ' +
-        'matches the firebase-js-sdk API. Kept for backwards compatibility.',
-    },
-    {
-      name: 'fetchTimeMillis',
-      reason:
-        'Getter function returning the last fetch timestamp. In the ' +
-        'firebase-js-sdk this value is accessed as the `fetchTimeMillis` ' +
-        'property on the `RemoteConfig` object rather than a standalone function.',
-    },
-    {
-      name: 'lastFetchStatus',
-      reason:
-        'Getter function returning the last fetch status. In the ' +
-        'firebase-js-sdk this value is accessed as the `lastFetchStatus` ' +
-        'property on the `RemoteConfig` object rather than a standalone function.',
-    },
-    {
-      name: 'settings',
-      reason:
-        'Getter function returning the current `ConfigSettings`. In the ' +
-        'firebase-js-sdk settings are accessed via the `settings` property ' +
-        'on the `RemoteConfig` object rather than a standalone function.',
-    },
-    {
-      name: 'onConfigUpdated',
-      reason:
-        'Deprecated RN Firebase listener for real-time config updates. ' +
-        'Replaced by `onConfigUpdate()` which matches the firebase-js-sdk API.',
+        'The firebase-js-sdk supports optional initialization options when creating ' +
+        'a Remote Config instance. RN Firebase does not expose this initialization API.',
     },
+  ],
+  // ---------------------------------------------------------------------------
+  // Extra in RN Firebase
+  // ---------------------------------------------------------------------------
+  extraInRN: [
     {
       name: 'reset',
       reason:
         'Android-only API that deletes all activated, fetched and default ' +
         'configs and resets all Remote Config settings. No equivalent exists ' +
         'in the firebase-js-sdk.',
     },
-    {
-      name: 'setConfigSettings',
-      reason:
-        'RN Firebase helper to update `minimumFetchIntervalMillis` and ' +
-        '`fetchTimeoutMillis` asynchronously via the native module. In the ' +
-        'firebase-js-sdk these properties are set by direct property assignment ' +
-        'on the `RemoteConfig.settings` object.',
-    },
-    {
-      name: 'setDefaults',
-      reason:
-        'RN Firebase API for setting default config values programmatically. ' +
-        'The firebase-js-sdk uses direct assignment to `RemoteConfig.defaultConfig` ' +
-        'instead.',
-    },
     {
       name: 'setDefaultsFromResource',
       reason:
@@ -131,10 +67,6 @@ const config: PackageConfig = {
         'exists in the firebase-js-sdk web API.',
     },
   ],
-
-  // ---------------------------------------------------------------------------
-  // Different shape
-  // ---------------------------------------------------------------------------
   differentShape: [
     {
       name: 'ConfigUpdateObserver',
@@ -144,33 +76,18 @@ const config: PackageConfig = {
         'errors but the RN type extends the native bridge error structure.',
     },
     {
-      name: 'getAll',
+      name: 'FetchStatus',
       reason:
-        'Returns `ConfigValues` (RN Firebase type alias for `{ [key: string]: Value }`) ' +
-        'instead of `Record<string, Value>`. The two types are structurally equivalent; ' +
-        'the alias is retained for backwards compatibility.',
+        'RN Firebase preserves the long-standing native string literals ' +
+        '(`no_fetch_yet` / `throttled`) used by both the namespaced API and native bridge, ' +
+        'instead of the firebase-js-sdk web literals (`no-fetch-yet` / `throttle`).',
     },
     {
       name: 'getRemoteConfig',
       reason:
-        'The optional `app` parameter uses `ReactNativeFirebase.FirebaseApp` from ' +
-        '`@react-native-firebase/app` instead of `FirebaseApp` from `@firebase/app`. ' +
-        'Both types represent a Firebase app instance but come from different packages.',
-    },
-    {
-      name: 'setLogLevel',
-      reason:
-        'The RN Firebase implementation accepts `RemoteConfigLogLevel` (a type alias ' +
-        'for `LogLevel`) and returns it, whereas the firebase-js-sdk accepts `LogLevel` ' +
-        'and returns `void`. The parameter types are semantically identical; the return ' +
-        'type difference is a legacy artefact of the RN implementation.',
-    },
-    {
-      name: 'setCustomSignals',
-      reason:
-        'Returns `Promise<null>` in RN Firebase vs `Promise<void>` in the ' +
-        'firebase-js-sdk. The native module resolves with `null` rather than ' +
-        '`undefined`; both signal successful completion.',
+        'The firebase-js-sdk accepts an optional `RemoteConfigOptions` second argument. ' +
+        'RN Firebase only accepts the optional app instance and does not expose the ' +
+        'initialization-options surface.',
     },
   ],
 };
 
@@ -18,6 +18,7 @@ import aiConfig from '../packages/ai/config';
 import appCheckConfig from '../packages/app-check/config';
 import firestoreConfig from '../packages/firestore/config';
 import firestorePipelinesConfig from '../packages/firestore-pipelines/config';
+import remoteConfigConfig from '../packages/remote-config/config';
 
 const SCRIPT_DIR = path.resolve(__dirname, '..');
 const REPO_ROOT = path.resolve(SCRIPT_DIR, '..', '..', '..');
@@ -46,33 +47,10 @@ export interface PackageEntry {
 }
 
 function rnDist(packageName: string): string {
-  return path.join(
-    REPO_ROOT,
-    'packages',
-    packageName,
-    'dist',
-    'typescript',
-    'lib',
-  );
+  return path.join(REPO_ROOT, 'packages', packageName, 'dist', 'typescript', 'lib');
 }
 
 export const packages: PackageEntry[] = [
-  // {
-  //   name: 'remote-config',
-  //   firebaseSdkTypesPaths: [
-  //     path.join(SCRIPT_DIR, 'packages', 'remote-config', 'firebase-sdk.d.ts'),
-  //   ],
-  //   rnFirebaseModularFiles: [
-  //     path.join(rnDist('remote-config'), 'types', 'modular.d.ts'),
-  //     path.join(rnDist('remote-config'), 'modular.d.ts'),
-  //   ],
-  //   rnFirebaseSupportFiles: [
-  //     path.join(rnDist('remote-config'), 'statics.d.ts'),
-  //     path.join(rnDist('remote-config'), 'types', 'namespaced.d.ts'),
-  //     path.join(rnDist('remote-config'), 'types', 'internal.d.ts'),
-  //   ],
-  //   config: remoteConfigConfig,
-  // },
   {
     name: 'storage',
     firebaseSdkTypesPaths: [path.join(
@@ -93,13 +71,24 @@ export const packages: PackageEntry[] = [
     config: storageConfig,
   },
   {
-    name: 'ai',
+    name: 'remote-config',
     firebaseSdkTypesPaths: [
-      path.join(SCRIPT_DIR, 'packages', 'ai', 'ai-sdk.d.ts'),
+      path.join(SCRIPT_DIR, 'packages', 'remote-config', 'firebase-sdk.d.ts'),
     ],
     rnFirebaseModularFiles: [
-      path.join(rnDist('ai'), 'index.d.ts'),
+      path.join(rnDist('remote-config'), 'types', 'remote-config.d.ts'),
+      path.join(rnDist('remote-config'), 'modular.d.ts'),
+    ],
+    rnFirebaseSupportFiles: [
+      path.join(rnDist('remote-config'), 'statics.d.ts'),
+      path.join(rnDist('remote-config'), 'types', 'namespaced.d.ts'),
     ],
+    config: remoteConfigConfig,
+  },
+  {
+    name: 'ai',
+    firebaseSdkTypesPaths: [path.join(SCRIPT_DIR, 'packages', 'ai', 'ai-sdk.d.ts')],
+    rnFirebaseModularFiles: [path.join(rnDist('ai'), 'index.d.ts')],
     rnFirebaseSupportFiles: [
       path.join(rnDist('ai'), 'backend.d.ts'),
       path.join(rnDist('ai'), 'errors.d.ts'),
@@ -148,12 +137,7 @@ export const packages: PackageEntry[] = [
   {
     name: 'firestore',
     firebaseSdkTypesPaths: [
-      path.join(
-        SCRIPT_DIR,
-        'packages',
-        'firestore',
-        'firestore-js-sdk.d.ts',
-      ),
+      path.join(SCRIPT_DIR, 'packages', 'firestore', 'firestore-js-sdk.d.ts'),
     ],
     rnFirebaseModularFiles: [
       path.join(rnDist('firestore'), 'types', 'firestore.d.ts'),
@@ -190,16 +174,9 @@ export const packages: PackageEntry[] = [
   {
     name: 'firestore-pipelines',
     firebaseSdkTypesPaths: [
-      path.join(
-        SCRIPT_DIR,
-        'packages',
-        'firestore-pipelines',
-        'pipelines.d.ts',
-      ),
-    ],
-    rnFirebaseModularFiles: [
-      path.join(rnDist('firestore'), 'pipelines', 'index.d.ts'),
+      path.join(SCRIPT_DIR, 'packages', 'firestore-pipelines', 'pipelines.d.ts'),
     ],
+    rnFirebaseModularFiles: [path.join(rnDist('firestore'), 'pipelines', 'index.d.ts')],
     rnFirebaseSupportFiles: [
       path.join(rnDist('firestore'), 'pipelines', 'expressions.d.ts'),
       path.join(rnDist('firestore'), 'pipelines', 'pipeline.d.ts'),
 
@@ -646,7 +646,11 @@ function isObjectLike(value: unknown): value is object | ((...args: any[]) => un
 }
 
 function isModularInstance(value: unknown): boolean {
-  return isObjectLike(value) && (value as any)[MODULAR_INSTANCE_SYMBOL] === true;
+  if (!isObjectLike(value)) {
+    return false;
+  }
+
+  return Object.getOwnPropertyDescriptor(value, MODULAR_INSTANCE_SYMBOL)?.value === true;
 }
 
 function markModularInstance<T>(value: T): T {
@@ -664,6 +668,10 @@ function markModularInstance<T>(value: T): T {
   return value;
 }
 
+function isModularAccess(target: unknown, receiver?: unknown): boolean {
+  return _isModularCall || isModularInstance(target) || isModularInstance(receiver);
+}
+
 export function createDeprecationProxy<T extends object>(instance: T): T {
   return new Proxy(instance, {
     construct(target: any, args: any[]) {
@@ -672,7 +680,7 @@ export function createDeprecationProxy<T extends object>(instance: T): T {
     },
     get(target: any, prop: string | symbol, receiver: any) {
       const originalMethod = target[prop];
-      const modularAccess = _isModularCall || isModularInstance(target);
+      const modularAccess = isModularAccess(target, receiver);
 
       if (prop === 'constructor') {
         return Reflect.get(target, prop, receiver);
@@ -781,6 +789,26 @@ export function createDeprecationProxy<T extends object>(instance: T): T {
       }
       return Reflect.get(target, prop, receiver);
     },
+    set(target: any, prop: string | symbol, value: unknown, receiver: unknown) {
+      const modularAccess = isModularAccess(target, receiver);
+      const descriptor =
+        Object.getOwnPropertyDescriptor(target, prop) ||
+        Object.getOwnPropertyDescriptor(Object.getPrototypeOf(target), prop);
+
+      if (descriptor?.set) {
+        const instanceName = getInstanceName(target);
+        const nameSpace = getNamespace(target);
+
+        if (nameSpace) {
+          deprecationConsoleWarning(nameSpace, prop as string, instanceName, modularAccess);
+        }
+
+        descriptor.set.call(target, value);
+        return true;
+      }
+
+      return Reflect.set(target, prop, value, receiver);
+    },
   });
 }