fix(remote-config-typescript): extra type definitions

Author: akashdeep931

.github/scripts/compare-types/packages/remote-config/config.ts

@@ -43,13 +43,6 @@ const config: PackageConfig = {
         'compatibility with the class-based (namespaced) API. Not part of ' +
         'the firebase-js-sdk modular API.',
     },
-    {
-      name: 'settings',
-      reason:
-        'Getter function returning the current `ConfigSettings`. In the ' +
-        'firebase-js-sdk settings are accessed via the `settings` property ' +
-        'on the `RemoteConfig` object rather than a standalone function.',
-    },
     {
       name: 'onConfigUpdated',
       reason:

packages/remote-config/__tests__/remote-config.test.ts

@@ -30,7 +30,6 @@ import {
   getValue,
   setLogLevel,
   isSupported,
-  settings,
   reset,
   setConfigSettings,
   setDefaults,
@@ -201,16 +200,15 @@ describe('remoteConfig()', function () {
       expect(isSupported).toBeDefined();
     });
 
-    it('`fetchTimeMillis` and `lastFetchStatus` are on RemoteConfig instance (firebase-js-sdk shape)', function () {
+    it('`fetchTimeMillis`, `lastFetchStatus` and `settings` are on RemoteConfig instance (firebase-js-sdk shape)', function () {
       const rc = getRemoteConfig();
       expect(rc.fetchTimeMillis).toBeDefined();
       expect(typeof rc.fetchTimeMillis).toBe('number');
       expect(rc.lastFetchStatus).toBeDefined();
       expect(typeof rc.lastFetchStatus).toBe('string');
-    });
-
-    it('`settings` function is properly exposed to end user', function () {
-      expect(settings).toBeDefined();
+      expect(rc.settings).toBeDefined();
+      expect(rc.settings.minimumFetchIntervalMillis).toBeDefined();
+      expect(rc.settings.fetchTimeoutMillis).toBeDefined();
     });
 
     it('`reset` function is properly exposed to end user', function () {

packages/remote-config/lib/modular.ts

@@ -13,7 +13,6 @@ import type {
 } from './types/modular';
 import type {
   ConfigDefaults,
-  ConfigSettings,
   RemoteConfigWithDeprecationArg,
   RemoteConfigWithSetCustomSignalsNative,
 } from './types/internal';
@@ -163,16 +162,6 @@ export function isSupported(): Promise<boolean> {
   return Promise.resolve(true);
 }
 
-/**
- * Returns a ConfigSettings object which provides the properties `minimumFetchIntervalMillis` & `fetchTimeMillis` if they have been set
- * using setConfigSettings({ fetchTimeMillis: number, minimumFetchIntervalMillis: number }).
- * @param remoteConfig - RemoteConfig instance
- * @returns ConfigSettings
- */
-export function settings(remoteConfig: RemoteConfig): ConfigSettings {
-  return remoteConfig.settings;
-}
-
 /**
  * Deletes all activated, fetched and defaults configs and resets all Firebase Remote Config settings.
  * Android only. iOS does not reset anything.
@@ -186,7 +175,7 @@ export function reset(remoteConfig: RemoteConfig): Promise<void> {
 /**
  * Set the Remote Config settings, currently able to set `fetchTimeMillis` & `minimumFetchIntervalMillis`.
  * @param remoteConfig - RemoteConfig instance
- * @param settings - ConfigSettings instance
+ * @param settings - RemoteConfigSettings instance
  * @returns Promise<void>
  */
 export function setConfigSettings(

packages/remote-config/type-test.ts

@@ -18,7 +18,6 @@ import remoteConfig, {
   getValue,
   setLogLevel,
   isSupported,
-  settings,
   reset,
   setConfigSettings,
   setDefaults,
@@ -200,7 +199,7 @@ isSupported().then((supported: boolean) => {
 });
 
 console.log(modularRemoteConfig1.fetchTimeMillis);
-console.log(settings(modularRemoteConfig1));
+console.log(modularRemoteConfig1.settings);
 console.log(modularRemoteConfig1.lastFetchStatus);
 
 reset(modularRemoteConfig1).then(() => {