chore(app-distribution): deprecations for v8 API ahead of future major release

Author: MichaelVerdon

packages/app-distribution/__tests__/app-distribution.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeAll, describe, expect, it } from '@jest/globals';
+import { afterAll, beforeAll, describe, expect, it, beforeEach, jest } from '@jest/globals';
 
 import {
   firebase,
@@ -9,6 +9,25 @@ import {
   signOutTester,
 } from '../lib';
 
+import {
+  createCheckV9Deprecation,
+  CheckV9DeprecationFunction,
+} from '../../app/lib/common/unitTestUtils';
+
+// @ts-ignore test
+import FirebaseModule from '../../app/lib/internal/FirebaseModule';
+
+// Mock isIOS to be true so the app distribution methods work in tests
+jest.mock(
+  '@react-native-firebase/app/lib/common',
+  () => ({
+    isIOS: true,
+    isAndroid: false,
+    isOther: false,
+  }),
+  { virtual: true },
+);
+
 describe('appDistribution()', function () {
   describe('namespace', function () {
     beforeAll(async function () {
@@ -49,4 +68,63 @@ describe('appDistribution()', function () {
       expect(signOutTester).toBeDefined();
     });
   });
+
+  describe('test `console.warn` is called for RNFB v8 API & not called for v9 API', function () {
+    let appDistributionV9Deprecation: CheckV9DeprecationFunction;
+
+    beforeEach(function () {
+      appDistributionV9Deprecation = createCheckV9Deprecation(['appDistribution']);
+
+      // @ts-ignore test
+      jest.spyOn(FirebaseModule.prototype, 'native', 'get').mockImplementation(() => {
+        return new Proxy(
+          {},
+          {
+            get: () =>
+              jest.fn().mockResolvedValue({
+                constants: {
+                  isTesterSignedIn: true,
+                },
+              } as never),
+          },
+        );
+      });
+    });
+
+    it('isTesterSignedIn', function () {
+      const appDistribution = getAppDistribution();
+      appDistributionV9Deprecation(
+        () => isTesterSignedIn(appDistribution),
+        () => appDistribution.isTesterSignedIn(),
+        'isTesterSignedIn',
+      );
+    });
+
+    it('signInTester', function () {
+      const appDistribution = getAppDistribution();
+      appDistributionV9Deprecation(
+        () => signInTester(appDistribution),
+        () => appDistribution.signInTester(),
+        'signInTester',
+      );
+    });
+
+    it('checkForUpdate', function () {
+      const appDistribution = getAppDistribution();
+      appDistributionV9Deprecation(
+        () => checkForUpdate(appDistribution),
+        () => appDistribution.checkForUpdate(),
+        'checkForUpdate',
+      );
+    });
+
+    it('signOutTester', function () {
+      const appDistribution = getAppDistribution();
+      appDistributionV9Deprecation(
+        () => signOutTester(appDistribution),
+        () => appDistribution.signOutTester(),
+        'signOutTester',
+      );
+    });
+  });
 });

packages/app-distribution/lib/modular/index.js

@@ -1,4 +1,5 @@
 import { getApp } from '@react-native-firebase/app';
+import { MODULAR_DEPRECATION_ARG } from '../../../app/lib/common';
 
 /**
  * @typedef {import("..").FirebaseApp} FirebaseApp
@@ -22,29 +23,29 @@ export function getAppDistribution(app) {
  * @returns {Promise<boolean>}
  */
 export function isTesterSignedIn(appDistribution) {
-  return appDistribution.isTesterSignedIn();
+  return appDistribution.isTesterSignedIn.call(appDistribution, MODULAR_DEPRECATION_ARG);
 }
 
 /**
  * @param {FirebaseAppDistribution} appDistribution
  * @returns {Promise<void>}
  */
 export function signInTester(appDistribution) {
-  return appDistribution.signInTester();
+  return appDistribution.signInTester.call(appDistribution, MODULAR_DEPRECATION_ARG);
 }
 
 /**
  * @param {FirebaseAppDistribution} appDistribution
  * @returns {AppDistributionRelease>}
  */
 export function checkForUpdate(appDistribution) {
-  return appDistribution.checkForUpdate();
+  return appDistribution.checkForUpdate.call(appDistribution, MODULAR_DEPRECATION_ARG);
 }
 
 /**
  * @param {FirebaseAppDistribution} appDistribution
  * @returns {Promise<void>}
  */
 export function signOutTester(appDistribution) {
-  return appDistribution.signOutTester();
+  return appDistribution.signOutTester.call(appDistribution, MODULAR_DEPRECATION_ARG);
 }

packages/app/lib/common/index.js

@@ -211,6 +211,14 @@ const mapOfDeprecationReplacements = {
       nanoseconds: NO_REPLACEMENT,
     },
   },
+  appDistribution: {
+    default: {
+      isTesterSignedIn: 'isTesterSignedIn()',
+      signInTester: 'signInTester()',
+      checkForUpdate: 'checkForUpdate()',
+      signOutTester: 'signOutTester()',
+    },
+  },
 };
 
 const modularDeprecationMessage =