Skip to content

Commit a9fd4c0

Browse files
committed
build(deps): pin firebase-js-sdk to exact version not semver
this is important because lockfile recreation may allow this to slip, at which point `yarn compare:types` starts to fail we rely on exact versions in practice as we make changes to adopt new versions and may even rely on bug-compatibility internally until a new version is qualified / formally adopted
1 parent d488470 commit a9fd4c0

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
"eslint-plugin-mocha": "^11.2.0",
9797
"eslint-plugin-prettier": "^5.5.5",
9898
"eslint-plugin-react": "^7.37.5",
99-
"firebase": "^12.12.1",
99+
"firebase": "12.12.1",
100100
"firebase-tools": "^15.16.0",
101101
"genversion": "^3.2.0",
102102
"google-java-format": "^2.2.0",

tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"axios": "^1.15.2",
4747
"cpy-cli": "^7.0.0",
4848
"detox": "patch:detox@npm%3A20.51.0#~/.yarn/patches/detox-npm-20.51.0-3e13b6e309.patch",
49-
"firebase": "^12.12.1",
49+
"firebase": "12.12.1",
5050
"firebase-tools": "^15.16.0",
5151
"jest-circus": "^30.3.0",
5252
"jest-environment-node": "^30.3.0",

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13004,7 +13004,7 @@ __metadata:
1300413004
languageName: node
1300513005
linkType: hard
1300613006

13007-
"firebase@npm:12.12.1, firebase@npm:^12.12.1":
13007+
"firebase@npm:12.12.1":
1300813008
version: 12.12.1
1300913009
resolution: "firebase@npm:12.12.1"
1301013010
dependencies:
@@ -22256,7 +22256,7 @@ __metadata:
2225622256
axios: "npm:^1.15.2"
2225722257
cpy-cli: "npm:^7.0.0"
2225822258
detox: "patch:detox@npm%3A20.51.0#~/.yarn/patches/detox-npm-20.51.0-3e13b6e309.patch"
22259-
firebase: "npm:^12.12.1"
22259+
firebase: "npm:12.12.1"
2226022260
firebase-tools: "npm:^15.16.0"
2226122261
jest-circus: "npm:^30.3.0"
2226222262
jest-environment-node: "npm:^30.3.0"
@@ -22308,7 +22308,7 @@ __metadata:
2230822308
eslint-plugin-mocha: "npm:^11.2.0"
2230922309
eslint-plugin-prettier: "npm:^5.5.5"
2231022310
eslint-plugin-react: "npm:^7.37.5"
22311-
firebase: "npm:^12.12.1"
22311+
firebase: "npm:12.12.1"
2231222312
firebase-tools: "npm:^15.16.0"
2231322313
genversion: "npm:^3.2.0"
2231422314
google-java-format: "npm:^2.2.0"

0 commit comments

Comments
 (0)