Skip to content

Commit ae5976c

Browse files
mikehardymikehardy
committed
fix: resolve CI lint and spec-native parity failures
1 parent 034c274 commit ae5976c

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎docs/migrating-to-v26.mdx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,12 @@ When migrating from firebase-js-sdk web examples, watch for these high-impact ru
8585
| ----------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
8686
| **Auth** | Browser persistence, redirects, reCAPTCHA, `revokeAccessToken`, `useDeviceLanguage`, `linkWithPhoneNumber` / `reauthenticateWithPhoneNumber` | Native iOS/Android SDKs manage persistence. Several web-only helpers **throw synchronously** on React Native (`setPersistence`, `getRedirectResult`, `revokeAccessToken`, `useDeviceLanguage`, `linkWithPhoneNumber`, `reauthenticateWithPhoneNumber`). Use native provider flows instead. |
8787
| **Analytics** | Cross-platform modular API | On-device conversion measurement helpers (`initiateOnDeviceConversionMeasurement*`) are **iOS only**; on Android and web the JS layer resolves without calling native (no-op). `logTransaction` (verified iOS in-app purchase events) is **iOS only** and **rejects** on other platforms. |
88-
| **Realtime Database** | `goOnline` / `goOffline` are synchronous; web transport toggles | `goOnline` / `goOffline` are **synchronous** through TurboModules, matching firebase-js-sdk. `getServerTime`, `setPersistenceEnabled`, and `setPersistenceCacheSizeBytes` are RN-specific. `forceLongPolling` / `forceWebSockets` **throw** — transport is native-controlled. |
88+
| **Realtime Database** | `goOnline` / `goOffline` are synchronous; web transport toggles | `goOnline` / `goOffline` are **synchronous** through TurboModules, matching firebase-js-sdk. `getServerTime`, `setPersistenceEnabled`, and `setPersistenceCacheSizeBytes` are RN-specific. `forceLongPolling` / `forceWebSockets` **throw** — transport is native-controlled. |
8989
| **Phone Number Verification** | N/A (Android SDK only) | **Android only** — all entry points throw on iOS and Web. |
9090
| **Cloud Storage** | `uploadBytes` / `uploadString` from JS blobs | `putFile` and `writeToFile` are **native-only** file-path APIs with no firebase-js-sdk equivalent. Retry-time setters are modular functions on RN, not instance properties. |
9191
| **Cloud Messaging** | Web push / service-worker surface | FCM token lifecycle, permissions, background handlers, and **APNs token APIs are iOS only**. Event delivery still uses the legacy native event proxy during the TurboModule migration; behavior matches pre-v26 releases but will change when Codegen events land in a future release. |
9292
| **Remote Config** | `reset()` clears server and local state | `reset()` is **Android only** — iOS does not clear activated, fetched, or default Remote Config values. `setDefaultsFromResource` loads from native resource files (`.plist` / XML). |
93-
| **Performance** | `initializePerformance` returns synchronously; trace `start`/`stop` are sync | `initializePerformance` is **synchronous** on RN (applies settings to the native instance). Trace, HTTP metric, and screen trace `start`/`stop` are **synchronous** through TurboModules, matching firebase-js-sdk. |
93+
| **Performance** | `initializePerformance` returns synchronously; trace `start`/`stop` are sync | `initializePerformance` is **synchronous** on RN (applies settings to the native instance). Trace, HTTP metric, and screen trace `start`/`stop` are **synchronous** through TurboModules, matching firebase-js-sdk. |
9494
| **Firestore** | IndexedDB persistence, `memoryLocalCache`, `persistentLocalCache` | Local cache factories and IndexedDB APIs are **web only**. Persistence is controlled by the native Firestore SDK. `initializeFirestore` is **async** on RN. |
9595
| **App Check** | reCAPTCHA version 3 / Enterprise web providers | Use `ReactNativeFirebaseAppCheckProvider` for Device Check, App Attest, Play Integrity, etc. Web reCAPTCHA provider classes have **no RN equivalent**. |
9696
| **RN-native-only modules** | No web SDK | `crashlytics`, `in-app-messaging`, `app-distribution`, and `ml` are **React Native only** — no firebase-js-sdk modular surface. |

‎packages/app/__tests__/specNativeParityHelper.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,8 @@ export function extractSpecMethods(specContent: string, fileName = 'spec.ts'): s
119119

120120
export function extractAndroidReactMethods(javaContent: string): string[] {
121121
const methods: string[] = [];
122-
const methodRegex = /@ReactMethod\s+(?:@DoNotStrip\s+)?public abstract void (\w+)\s*\(/g;
122+
const methodRegex =
123+
/@ReactMethod(?:\([^)]*\))?\s+(?:@DoNotStrip\s+)?public abstract [\w.]+ (\w+)\s*\(/g;
123124
let match = methodRegex.exec(javaContent);
124125
while (match) {
125126
const name = match[1];

‎packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthSyncException.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
*/
1919

2020
/**
21-
* Structured sync TurboModule error carrying the same RNFB {@code code}/{@code message} pair used by
22-
* {@code rejectPromiseWithCodeAndMessage}.
21+
* Structured sync TurboModule error carrying the same RNFB {@code code}/{@code message} pair used
22+
* by {@code rejectPromiseWithCodeAndMessage}.
2323
*/
2424
public class ReactNativeFirebaseAuthSyncException extends RuntimeException {
2525
private final String code;

‎packages/auth/ios/RNFBAuth/RNFBAuthModule.mm‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,8 +1111,8 @@ - (NSString *)generateQrCodeUrl:(NSString *)appName
11111111
DLog(@"generateQrCodeUrl using secretKey: %@", secretKey);
11121112
FIRTOTPSecret *totpSecret = cachedTotpSecrets[secretKey];
11131113
if (!totpSecret) {
1114-
RNFBAuthThrowSyncErrorWithCode(
1115-
@"invalid-multi-factor-secret", @"can't find secret for provided key");
1114+
RNFBAuthThrowSyncErrorWithCode(@"invalid-multi-factor-secret",
1115+
@"can't find secret for provided key");
11161116
}
11171117
NSString *url = [totpSecret generateQRCodeURLWithAccountName:account issuer:issuer];
11181118
DLog(@"generateQrCodeUrl got QR Code URL %@", url);

‎packages/perf/ios/RNFBPerf/RNFBPerfModule.mm‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,7 @@ - (void)startHttpMetric:(double)id url:(NSString *)url httpMethod:(NSString *)ht
162162
}
163163
}
164164

165-
- (void)stopHttpMetric:(double)id
166-
metricData:(JS::NativeRNFBTurboPerf::HttpMetricData &)metricData {
165+
- (void)stopHttpMetric:(double)id metricData:(JS::NativeRNFBTurboPerf::HttpMetricData &)metricData {
167166
FIRHTTPMetric *httpMetric;
168167
@synchronized([self class]) {
169168
httpMetric = httpMetrics[@((int)id)];

0 commit comments

Comments
 (0)