feat(phone-number-verification)!: migrate phone-number-verification to TurboModules

Author: mikehardy

jest.setup.ts

@@ -457,6 +457,32 @@ jest.doMock('react-native', () => {
           startHttpMetric: jest.fn(() => Promise.resolve()),
           stopHttpMetric: jest.fn(() => Promise.resolve()),
         },
+        NativeRNFBTurboPnv: {
+          enableTestSession: jest.fn(() => Promise.resolve()),
+          getVerificationSupportInfo: jest.fn(() => Promise.resolve([])),
+          getVerificationSupportInfoForSimSlot: jest.fn(() => Promise.resolve([])),
+          getVerifiedPhoneNumber: jest.fn(() =>
+            Promise.resolve({
+              phoneNumber: '+15555550100',
+              token: 'jwt',
+              expirationTimestamp: 0,
+              issuedAtTimestamp: 0,
+              nonce: null,
+              claims: null,
+            }),
+          ),
+          getDigitalCredentialPayload: jest.fn(() => Promise.resolve('payload')),
+          exchangeCredentialResponseForPhoneNumber: jest.fn(() =>
+            Promise.resolve({
+              phoneNumber: '+15555550100',
+              token: 'jwt',
+              expirationTimestamp: 0,
+              issuedAtTimestamp: 0,
+              nonce: null,
+              claims: null,
+            }),
+          ),
+        },
         NativeRNFBTurboML: {},
         NativeRNFBTurboConfig: {
           getConstants: () => ({

okf-bundle/new-architecture/migration-work-queue.md

@@ -8,7 +8,7 @@ timestamp: 2026-06-26T00:00:00Z
 
 # TurboModule migration — work queue
 
-> **IN PROGRESS (2026-07-02):** Phase **4** — P4u `auth` committed; Phase 4 Tier A/B complete except opportunistic docs. Next: Phase **5** `phone-number-verification` or Phase **R** prep.
+> **IN PROGRESS (2026-07-02):** Phase **5** complete (P5pnv + auth fix committed). All native packages migrated except Phase **R** / **S** / **C**. Next: Phase **R** pre-merge validation or opportunistic docs.
 > **Goal/order:** app foundation → hard probe → easy wins → remaining complex → sync conversion → coordinated break → cleanup (events, shared-state encapsulation). Decisions: [architecture-decisions.md](architecture-decisions.md). Links: [implementation workflow](turbomodule-implementation-workflow.md), [change authoring](../testing/change-authoring-workflow.md), [functions reference](../../../packages/functions/) ([PR #8603](https://github.com/invertase/react-native-firebase/pull/8603)).
 
 Ephemeral tracker; see [OKF policy](../documentation-policy.md).
@@ -322,11 +322,11 @@ Skip steps 1–2 when spec shape is known (most Tier D packages).
 
 ## Current snapshot
 
-**Label:** `phase-4-auth` (2026-07-02); **harness:** full (implementer applies area narrowing for e2e)
+**Label:** `phase-5-pnv` (2026-07-02); **harness:** full (implementer applies area narrowing for e2e)
 
-**Next item:** Phase **5** `phone-number-verification` (Android-only) or opportunistic PDoc
+**Next item:** Phase **R** pre-merge validation or opportunistic PDoc
 
-**Current gates:** P4u all gates **closed** — committed `feat(auth)!: migrate auth to TurboModules` 2026-07-02. Review: macOS 171 / iOS 185 / Android 192 passing.
+**Current gates:** P5pnv all gates **closed** — committed 2026-07-02. Auth fix `fix(auth): rename delete turbo method for C++ codegen compatibility` committed separately.
 
 **Host rule:** one `:test-cover` at a time — never parallel subagents with e2e.
 
@@ -358,7 +358,8 @@ Skip steps 1–2 when spec shape is known (most Tier D packages).
 | Phase 4a messaging event decision | P4a | n/a | n/a | n/a | done | `none` | none | **Defer** events to Phase C — [NewArch-AD-4 § messaging](architecture-decisions.md#messaging--defer-eventemitter-cutover-migrate-shell-only-in-phase-4). |
 | Phase 4 `messaging` TurboModules | P4m | **closed** | **closed** | **closed** | done | `area-focused` | `feat(messaging)!: migrate messaging to TurboModules` | Turbo shell only (AD-4 event path preserved). Jest 38/38 + parity 32/32; codegen:verify incl messaging; legacy Java removed. iOS/Android area e2e green on method-call + listener-registration scope. Foreground `onMessage` delivery test **left `xit`** — flaky FCM harness; re-enable in [Phase C](#deferred-cleanup-phase-eventemitter). |
 | Phase 4 `database` TurboModules | P4d | **closed** | **closed** | **closed** | done | `area-focused` | `feat(database)!: migrate database to TurboModules` | 5 Turbo specs/shells + committed codegen; Jest 49 + parity 38; area e2e macOS 213 / iOS 219 / Android 220 (delta logs `/tmp/rnfb-e2e-*-database-delta-review.log`). Remediation: invalidate/teardown parity (Reference+Transaction), onComplete guard, contract test 22 methods, jest mock cleanup. Orchestration: macOS/Android `:8090` pre-flight in `firebase.test.js` + OKF. **Deferred minor:** void spec vs Promise JS API; silent Query `RejectedExecutionException` post-invalidate. |
-| Phase 4 `auth` TurboModules | P4u | **closed** | **closed** | **closed** | done | `area-focused` | `feat(auth)!: migrate auth to TurboModules` | 60-method spec + shells; Jest 135 + parity 40; review e2e macOS 171 / iOS 185 / Android 192 (logs `/tmp/rnfb-e2e-*-auth-review.log`). AD-4 events preserved; AD-10 authDomains unchanged. **Deferred minor:** iOS no-op stubs for Android-only testing APIs undocumented in spec. **Deferred nit:** phone-auth invalidate gap (legacy parity). |
+| Phase 4 `auth` TurboModules | P4u | **closed** | **closed** | **closed** | done | `area-focused` | `feat(auth)!: migrate auth to TurboModules` | … **Follow-up (uncommitted):** spec `delete` → C++ keyword collision; rename + regen; `TaskExecutorService(TAG)` fix applied on disk. |
+| Phase 5 `phone-number-verification` TurboModules | P5pnv | **closed** | **closed** | **closed** | done | `area-focused` | `feat(phone-number-verification)!: migrate phone-number-verification to TurboModules` | Android-only 6-method spec; review e2e Android 40/2 pending (log `/tmp/rnfb-e2e-android-pnv-review.log`). AD-18 E10 direct resolver. Parity registered. **Bundled auth fix:** separate commit `fix(auth): rename delete turbo method for C++ codegen compatibility`. |
 | Phase Docs — NA reqs + consolidation | PDoc | open | open | open | documentation | `none` | `docs: new-architecture requirements + migration consolidation` | Opportunistic; does not gate 4. |
 | Phase PD — platform divergence | PPD | open | open | open | documentation | `none` | `docs(<pkg>): …` per package | Opportunistic; gap-analysis first. |
 | Phase R — remove `NativeModules` fallback | PR-fallback | open | open | open | pre-merge-validation | `full` | (Phase R) | Decision B. Jest + `app` e2e "unknown module throws". |

packages/app/__tests__/specNativeParityHelper.ts

@@ -24,6 +24,7 @@ export const MIGRATED_TURBO_PACKAGES = [
   'messaging',
   'database',
   'auth',
+  'phone-number-verification',
 ] as const;
 
 export type MigratedTurboPackage = (typeof MIGRATED_TURBO_PACKAGES)[number];
@@ -36,6 +37,40 @@ export type SpecParityContext = {
   iosHeaderPath: string;
 };
 
+export type SpecParityContextEntry = {
+  moduleName: string;
+  specPath: string;
+  androidSpecPath: string;
+  iosHeaderPath: string;
+};
+
+/** Explicit spec/native paths for packages with non-default codegen layout (see database/messaging guardrail commits). */
+export const PACKAGE_SPEC_PARITY_CONTEXTS: Partial<
+  Record<MigratedTurboPackage, readonly SpecParityContextEntry[]>
+> = {
+  auth: [
+    {
+      moduleName: 'NativeRNFBTurboAuth',
+      specPath: 'packages/auth/specs/NativeRNFBTurboAuth.ts',
+      androidSpecPath:
+        'packages/auth/android/src/main/java/io/invertase/firebase/auth/generated/java/com/facebook/fbreact/specs/NativeRNFBTurboAuthSpec.java',
+      iosHeaderPath:
+        'packages/auth/ios/generated/RNFBAuthTurboModules/RNFBAuthTurboModules.h',
+    },
+  ],
+  'phone-number-verification': [
+    {
+      moduleName: 'NativeRNFBTurboPnv',
+      specPath: 'packages/phone-number-verification/specs/NativeRNFBTurboPnv.ts',
+      androidSpecPath:
+        'packages/phone-number-verification/android/src/reactnative/java/io/invertase/firebase/pnv/generated/java/com/facebook/fbreact/specs/NativeRNFBTurboPnvSpec.java',
+      iosHeaderPath:
+        'packages/phone-number-verification/ios/generated/RNFBPnvTurboModules/RNFBPnvTurboModules.h',
+    },
+  ],
+};
+
+
 export function extractSpecMethods(specContent: string, fileName = 'spec.ts'): string[] {
   const sourceFile = ts.createSourceFile(
     fileName,
@@ -166,9 +201,27 @@ function findSingleMatch(rootDir: string, pattern: RegExp, label: string): strin
   return matches[0];
 }
 
+function resolveParityContext(
+  packageName: MigratedTurboPackage,
+  entry: SpecParityContextEntry,
+): SpecParityContext {
+  return {
+    packageName,
+    moduleName: entry.moduleName,
+    specPath: path.join(REPO_ROOT, entry.specPath),
+    androidSpecPath: path.join(REPO_ROOT, entry.androidSpecPath),
+    iosHeaderPath: path.join(REPO_ROOT, entry.iosHeaderPath),
+  };
+}
+
 export function discoverPackageSpecContexts(
   packageName: MigratedTurboPackage,
 ): SpecParityContext[] {
+  const explicitContexts = PACKAGE_SPEC_PARITY_CONTEXTS[packageName];
+  if (explicitContexts?.length) {
+    return explicitContexts.map(entry => resolveParityContext(packageName, entry));
+  }
+
   const packageDir = path.join(REPO_ROOT, 'packages', packageName);
   const specsDir = path.join(packageDir, 'specs');
   const specFiles = fs

packages/phone-number-verification/__tests__/nativeModuleContract.test.ts

@@ -0,0 +1,54 @@
+import { describe, expect, it, jest } from '@jest/globals';
+import { createTurboModuleFixture } from '../../app/__tests__/turboModuleContractHelper';
+
+const SPEC_METHODS = [
+  'enableTestSession',
+  'getVerificationSupportInfo',
+  'getVerificationSupportInfoForSimSlot',
+  'getVerifiedPhoneNumber',
+  'getDigitalCredentialPayload',
+  'exchangeCredentialResponseForPhoneNumber',
+] as const;
+
+describe('TurboModule direct resolver contract (NewArch-AD-17.1 / NewArch-AD-18 E10)', function () {
+  it('resolves every spec method through the direct turbo resolver', async function () {
+    const mocks = Object.fromEntries(
+      SPEC_METHODS.map(method => [
+        method,
+        jest.fn(() =>
+          method === 'enableTestSession'
+            ? Promise.resolve()
+            : method === 'getDigitalCredentialPayload'
+              ? Promise.resolve('payload')
+              : method === 'getVerificationSupportInfo' ||
+                  method === 'getVerificationSupportInfoForSimSlot'
+                ? Promise.resolve([])
+                : Promise.resolve({
+                    phoneNumber: '+15555550100',
+                    token: 'jwt',
+                    expirationTimestamp: 0,
+                    issuedAtTimestamp: 0,
+                    nonce: null,
+                    claims: null,
+                  }),
+        ),
+      ]),
+    ) as Record<string, jest.Mock>;
+
+    const raw = createTurboModuleFixture(mocks);
+
+    jest.resetModules();
+    const { setReactNativeModule } = await import(
+      '@react-native-firebase/app/dist/module/internal/nativeModule'
+    );
+    setReactNativeModule('NativeRNFBTurboPnv', raw);
+    const { getVerificationSupportInfo } = await import('../lib/index');
+
+    await getVerificationSupportInfo();
+
+    expect(mocks.getVerificationSupportInfo).toHaveBeenCalledTimes(1);
+    for (const method of SPEC_METHODS) {
+      expect(typeof raw[method]).toBe('function');
+    }
+  });
+});

packages/phone-number-verification/android/build.gradle

@@ -80,6 +80,7 @@ android {
   sourceSets {
     main {
       java.srcDirs = ['src/main/java', 'src/reactnative/java']
+      java.excludes = ['**/generated/jni/**']
     }
   }
 }
@@ -99,3 +100,21 @@ ReactNative.shared.applyPackageVersion()
 ReactNative.shared.applyDefaultExcludes()
 ReactNative.module.applyAndroidVersions()
 ReactNative.module.applyReactNativeDependency('api')
+
+def isNewArchitectureDisabled() {
+  return project.hasProperty("newArchEnabled") && project.newArchEnabled != "true"
+}
+
+if (isNewArchitectureDisabled()) {
+  def ANSI_RED = "\u001B[31m";
+  def ANSI_RESET = "\u001B[0m";
+
+  println("\n\n\n")
+  println(ANSI_RED + "**************************************************************************************************************")
+  println("\n\n\n")
+  println("New Architecture support is required for @react-native-firebase/phone-number-verification")
+  println("\n\n\n")
+  println("**************************************************************************************************************" + ANSI_RESET)
+  println("\n\n\n")
+  System.exit(1)
+}

packages/phone-number-verification/android/src/main/java/io/invertase/firebase/pnv/ReactNativeFirebasePnvPackage.java

@@ -30,7 +30,7 @@ public class ReactNativeFirebasePnvPackage implements ReactPackage {
   @Override
   public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
     List<NativeModule> modules = new ArrayList<>();
-    modules.add(new ReactNativeFirebasePnvModule(reactContext));
+    modules.add(new NativeRNFBTurboPnv(reactContext));
     return modules;
   }
 

…se/pnv/ReactNativeFirebasePnvModule.java …ase/firebase/pnv/NativeRNFBTurboPnv.javapackages/phone-number-verification/android/src/main/java/io/invertase/firebase/pnv/ReactNativeFirebasePnvModule.java renamed to packages/phone-number-verification/android/src/reactnative/java/io/invertase/firebase/pnv/NativeRNFBTurboPnv.java packages/phone-number-verification/android/src/main/java/io/invertase/firebase/pnv/ReactNativeFirebasePnvModule.java renamed to packages/phone-number-verification/android/src/reactnative/java/io/invertase/firebase/pnv/NativeRNFBTurboPnv.java

@@ -17,29 +17,44 @@
  *
  */
 
+import static io.invertase.firebase.common.ReactNativeFirebaseModule.rejectPromiseWithCodeAndMessage;
+
 import android.app.Activity;
+import com.facebook.fbreact.specs.NativeRNFBTurboPnvSpec;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.bridge.ReactApplicationContext;
-import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.bridge.WritableArray;
 import com.facebook.react.bridge.WritableMap;
 import com.google.firebase.pnv.FirebasePhoneNumberVerification;
 import com.google.firebase.pnv.FirebasePhoneNumberVerificationException;
 import com.google.firebase.pnv.VerificationSupportResult;
 import com.google.firebase.pnv.VerifiedPhoneNumberTokenResult;
-import io.invertase.firebase.common.ReactNativeFirebaseModule;
+import io.invertase.firebase.common.TaskExecutorService;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.Executor;
 
-public class ReactNativeFirebasePnvModule extends ReactNativeFirebaseModule {
+public class NativeRNFBTurboPnv extends NativeRNFBTurboPnvSpec {
   private static final String TAG = "Pnv";
 
   private final FirebasePhoneNumberVerification fpnv;
+  private final TaskExecutorService executorService;
 
-  ReactNativeFirebasePnvModule(ReactApplicationContext reactContext) {
-    super(reactContext, TAG);
+  public NativeRNFBTurboPnv(ReactApplicationContext reactContext) {
+    super(reactContext);
     fpnv = FirebasePhoneNumberVerification.getInstance();
+    executorService = new TaskExecutorService(TAG);
+  }
+
+  @Override
+  public void invalidate() {
+    super.invalidate();
+    executorService.shutdown();
+  }
+
+  private Executor getExecutor() {
+    return executorService.getExecutor();
   }
 
   private static String reasonToString(int reason) {
@@ -150,7 +165,7 @@ private static WritableMap claimsToWritableMap(Map<String, Object> claims) {
     return map;
   }
 
-  @ReactMethod
+  @Override
   public void enableTestSession(String token, Promise promise) {
     try {
       fpnv.enableTestSession(token);
@@ -160,7 +175,7 @@ public void enableTestSession(String token, Promise promise) {
     }
   }
 
-  @ReactMethod
+  @Override
   public void getVerificationSupportInfo(Promise promise) {
     fpnv.getVerificationSupportInfo()
         .addOnSuccessListener(
@@ -175,9 +190,9 @@ public void getVerificationSupportInfo(Promise promise) {
             });
   }
 
-  @ReactMethod
-  public void getVerificationSupportInfoForSimSlot(int simSlot, Promise promise) {
-    fpnv.getVerificationSupportInfo(simSlot)
+  @Override
+  public void getVerificationSupportInfoForSimSlot(double simSlot, Promise promise) {
+    fpnv.getVerificationSupportInfo((int) simSlot)
         .addOnSuccessListener(
             getExecutor(),
             results -> {
@@ -190,7 +205,7 @@ public void getVerificationSupportInfoForSimSlot(int simSlot, Promise promise) {
             });
   }
 
-  @ReactMethod
+  @Override
   public void getVerifiedPhoneNumber(Promise promise) {
     Activity activity = getCurrentActivity();
     if (activity == null) {
@@ -211,7 +226,7 @@ public void getVerifiedPhoneNumber(Promise promise) {
             });
   }
 
-  @ReactMethod
+  @Override
   public void getDigitalCredentialPayload(String nonce, Promise promise) {
     fpnv.getDigitalCredentialPayload(nonce)
         .addOnSuccessListener(
@@ -226,7 +241,7 @@ public void getDigitalCredentialPayload(String nonce, Promise promise) {
             });
   }
 
-  @ReactMethod
+  @Override
   public void exchangeCredentialResponseForPhoneNumber(String dcApiResponse, Promise promise) {
     fpnv.exchangeCredentialResponseForPhoneNumber(dcApiResponse)
         .addOnSuccessListener(