test(e2e): fix mocha-remote parse patch and macOS Metro bundle startup

Author: mikehardy

.github/workflows/tests_e2e_other.yml

@@ -264,7 +264,7 @@ jobs:
             sleep 2
           done
           echo "Packager is online! Preparing bundle..."
-          curl --output /dev/null --silent --head --fail "http://localhost:8081/index.bundle?platform=macos&dev=true&minify=false&inlineSourceMap=true"
+          curl --output /dev/null --silent --head --fail "http://127.0.0.1:8081/index.bundle?platform=macos&dev=true&lazy=true&minify=false&inlineSourceMap=true&modulesOnly=false&runModule=true&app=org.reactjs.native.io-invertase-testing"
           echo "...javascript bundle ready"
 
       - name: Start Screen Recording and System Logging

.yarn/patches/mocha-remote-server-npm-1.13.2-619a29d2e3.patch

@@ -191,3 +191,39 @@ index ad9debe2086ab9b96e97a69aec966da8114ad102..51cc18658e11d5aec5d5a76c4eb5f965
          }
      }
      /**
+diff --git a/dist/serialization.js b/dist/serialization.js
+index b2dd290111197907d125e3151a4a965e9fe0528d..7a29ad98febf3ec7dbffe02b9d555fa40340e325 100644
+--- a/dist/serialization.js
++++ b/dist/serialization.js
+@@ -3,7 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
+     return (mod && mod.__esModule) ? mod : { "default": mod };
+ };
+ Object.defineProperty(exports, "__esModule", { value: true });
+-exports.deserialize = exports.createReviver = void 0;
++exports.tryDeserialize = exports.deserialize = exports.createReviver = void 0;
+ const flatted_1 = __importDefault(require("flatted"));
+ const debug_1 = require("./debug");
+ const debug = (0, debug_1.extend)("serialization");
+@@ -45,6 +45,22 @@ function createReviver() {
+     };
+ }
+ exports.createReviver = createReviver;
++function tryDeserialize(text, reviver = createReviver()) {
++    if (!text) {
++        return { ok: false, incomplete: true, error: new Error("empty buffer") };
++    }
++    try {
++        const value = flatted_1.default.parse(text, reviver);
++        return { ok: true, value };
++    }
++    catch (error) {
++        const err = error instanceof Error ? error : new Error(String(error));
++        const message = err.message || "";
++        const incomplete = /unexpected end of (json )?input|end of data/i.test(message);
++        return { ok: false, incomplete, error: err };
++    }
++}
++exports.tryDeserialize = tryDeserialize;
+ function deserialize(text, reviver = createReviver()) {
+     debug("Deserializing %s", text);
+     return flatted_1.default.parse(text, reviver);

okf-bundle/ci-workflows/android.md

@@ -59,7 +59,7 @@ Observed on Android CI under load (e.g. [run 28044822049](https://github.com/inv
 
 | Change | Location |
 |--------|----------|
-| Inbound parse buffer + `tryDeserialize` / `parse_skip` logging | mocha-remote-server patch → `Server.js` |
+| Inbound parse buffer + `tryDeserialize` in `serialization.js` / `parse_skip` logging | mocha-remote-server patch |
 | Outbound queue flushed on reconnect | mocha-remote-client patch |
 | `JET_PROTOCOL_ERROR_RE` → retryable Jet session (attempt 2) | `tests/e2e/firebase.test.js` |
 | Cold-boot ready wait + post-boot settle before Jet attempt 1 | `firebase.test.js` (`waitForAndroidEmulatorReady`, `RNFB_ANDROID_BOOT_SETTLE_MS`) |

okf-bundle/ci-workflows/index.md

@@ -6,7 +6,7 @@ Knowledge for GitHub Actions workflows in this repository: how jobs are structur
 
 * [iOS](ios.md) — simulator boot reliability, logging, and troubleshooting
 * [Android](android.md) — idling resources, adb teardown, native coverage pull
-* [Other](other.md) — macOS Detox (non-iOS), Windows, and shared workflow concerns — TBD
+* [Other](other.md) — macOS Jet e2e (Metro bundle startup), Windows, and shared workflow concerns
 
 ## Shared E2E dependencies
 

okf-bundle/ci-workflows/other.md

@@ -1,3 +1,66 @@
 # Other CI workflows
 
-TBD — macOS Detox (`tests_e2e_other.yml`), Windows, documentation workflows, and shared actions (caches, Codecov, etc.).
+## macOS Jet e2e (`tests_e2e_other.yml`)
+
+macOS e2e runs **Jet directly** (no Detox): `yarn tests:macos:test-cover`. The test app is a react-native-macos binary launched via `open` in `tests/.jetrc.js`.
+
+### Pipeline
+
+1. Build macOS app (`yarn tests:macos:build`, `SKIP_BUNDLING=1`)
+2. Start Firestore emulator
+3. Start Metro (`yarn tests:packager:jet-ci`)
+4. **Pre-fetch JS bundle** (workflow step) — must match the URL the app requests
+5. `yarn tests:macos:test-cover` — Jet `before` hook also prefetches, then `open` app
+
+### CI failure: bundle load hang / `Could not connect to development server`
+
+**Symptom** — Jet logs `[💻] macOS app started` but never `[🟩] Jet client connected`. System log / `syslog` artifact shows:
+
+```
+HTTP load failed, 384/63910994 bytes (error code: -1017)
+Could not connect to development server.
+URL: http://localhost:8081/index.bundle?platform=macos&...&inlineSourceMap=false...
+```
+
+**Cause**
+
+1. **Startup race** — `.jetrc.js` opened the app before Metro finished the first ~64MB bundle. The native HTTP client received a truncated response (`-1017`) and JS never loaded, so mocha-remote never connected.
+2. **Prefetch URL mismatch** — CI warmed `inlineSourceMap=true` without `lazy` / `app=` query params, while the default `AppDelegate` requested `localhost` with `inlineSourceMap=false` — a cache miss and a second full bundle build at app launch.
+3. **`localhost` vs `127.0.0.1`** — same class of issue as [iOS AppDelegate](ios.md#operational-notes); macOS can connect via `::1` while Metro is still streaming.
+
+**Mitigations in this repo**
+
+| Change | Location |
+|--------|----------|
+| `127.0.0.1` + explicit `inlineSourceMap:YES` bundle URL (mirrors iOS) | `tests/macos/io.invertase.testing-macOS/AppDelegate.mm` |
+| `waitForMetroMacosBundle()` before `open` app | `tests/.jetrc.js` → `macos.before` |
+| CI prefetch uses **exact** bundle query string (127.0.0.1, `lazy`, `inlineSourceMap=true`, `app=`) | `.github/workflows/tests_e2e_other.yml` |
+
+**Diagnosing**
+
+```bash
+rg 'Could not connect to development server|HTTP load failed|Jet client connected|macOS Metro bundle prefetched' detox-step.log syslog.log
+log show --predicate 'process == "io.invertase.testing"' --last 10m --style compact | rg 'development server|HTTP load failed'
+```
+
+### CI failure: `tryDeserialize is not a function` (mocha-remote-server patch)
+
+**Symptom** — immediate crash on first WS message after client connects:
+
+```
+TypeError: (0 , serialization_1.tryDeserialize) is not a function
+    at Server.handleMessage (.../mocha-remote-server/dist/Server.js:149)
+```
+
+**Cause** — `Server.js` patch called `tryDeserialize` but the helper was never added to `dist/serialization.js`.
+
+**Fix** — export `tryDeserialize` from `serialization.js` in `.yarn/patches/mocha-remote-server-npm-1.13.2-*.patch`; run `yarn patch-commit` + `yarn install` so `yarn.lock` hash updates.
+
+### Related
+
+- [iOS CI](ios.md) — simulator + Detox; shared Jet / mocha-remote patches
+- [Coverage design](../testing/coverage-design.md) — macOS uploads `e2e-ts-macos` only (no native gate)
+
+## Windows / shared
+
+TBD — Windows workflows and shared actions (caches, Codecov, etc.).

tests/.jetrc.js

@@ -1,7 +1,35 @@
 const { execSync, spawn } = require('child_process');
+const { promisify } = require('util');
+const execFile = promisify(require('child_process').execFile);
 
 let macOsRetries = 0;
 
+const MACOS_BUNDLE_QUERY =
+  'platform=macos&dev=true&lazy=true&minify=false&inlineSourceMap=true&modulesOnly=false&runModule=true&app=org.reactjs.native.io-invertase-testing';
+
+async function waitForMetroMacosBundle(metroPort = 8081, timeoutMs = 600000) {
+  const host = '127.0.0.1';
+  const statusUrl = `http://${host}:${metroPort}/status`;
+  const bundleUrl = `http://${host}:${metroPort}/index.bundle?${MACOS_BUNDLE_QUERY}`;
+  const started = Date.now();
+
+  while (Date.now() - started < timeoutMs) {
+    try {
+      const { stdout } = await execFile('curl', ['-sf', statusUrl]);
+      if (stdout.includes('packager-status:running')) {
+        break;
+      }
+    } catch (_e) {
+      // Metro still starting.
+    }
+    await new Promise(resolve => setTimeout(resolve, 2000));
+  }
+
+  const remainingSec = Math.max(60, Math.ceil((timeoutMs - (Date.now() - started)) / 1000));
+  await execFile('curl', ['-sf', '--max-time', String(remainingSec), '-o', '/dev/null', bundleUrl]);
+  console.warn(`[rnfb-e2e] macOS Metro bundle prefetched from ${bundleUrl}`);
+}
+
 module.exports = {
   config: {
     slow: 3000,
@@ -36,6 +64,7 @@ module.exports = {
         } catch (_e) {
           // noop
         }
+        await waitForMetroMacosBundle(config.metroPort ?? 8081);
         const macApp = spawn(
           'open',
           ['./macos/build/Build/Products/Debug/io.invertase.testing.app'],

tests/macos/io.invertase.testing-macOS/AppDelegate.mm

@@ -1,11 +1,45 @@
 #import "AppDelegate.h"
 
 #import <React/RCTBundleURLProvider.h>
+#import <React/RCTConstants.h>
+
+static NSString *const RNFBTestingMetroHost = @"127.0.0.1";
+
+static NSString *RNFBTestingMetroHostPort(void)
+{
+  return [NSString stringWithFormat:@"%@:%lu", RNFBTestingMetroHost, (unsigned long)RCT_METRO_PORT];
+}
+
+#if DEBUG
+static void RNFBTestingConfigureMetroHost(void)
+{
+  RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
+  [settings setJsLocation:RNFBTestingMetroHostPort()];
+  // NYC/babel-istanbul remap needs inline source maps in the dev bundle.
+  [settings setInlineSourceMap:YES];
+}
+
+static NSURL *RNFBTestingDebugBundleURL(void)
+{
+  RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
+  return [RCTBundleURLProvider jsBundleURLForBundleRoot:@"index"
+                                           packagerHost:RNFBTestingMetroHostPort()
+                                         packagerScheme:settings.packagerScheme ?: @"http"
+                                              enableDev:settings.enableDev
+                                     enableMinification:settings.enableMinification
+                                        inlineSourceMap:YES
+                                            modulesOnly:NO
+                                              runModule:YES];
+}
+#endif
 
 @implementation AppDelegate
 
 - (void)applicationDidFinishLaunching:(NSNotification *)notification
 {
+#if DEBUG
+  RNFBTestingConfigureMetroHost();
+#endif
   self.moduleName = @"testing";
   // You can add your custom initial props in the dictionary below.
   // They will be passed down to the ViewController used by React Native.
@@ -17,17 +51,16 @@ - (void)applicationDidFinishLaunching:(NSNotification *)notification
 - (NSURL *)bundleURL
 {
 #if DEBUG
-  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
+  return RNFBTestingDebugBundleURL();
 #else
   return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
 #endif
 }
 
 - (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
 {
-  
 #if DEBUG
-  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
+  return RNFBTestingDebugBundleURL();
 #else
   return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
 #endif

yarn.lock

@@ -19562,13 +19562,13 @@ __metadata:
 
 "mocha-remote-server@patch:mocha-remote-server@npm%3A1.13.2#~/.yarn/patches/mocha-remote-server-npm-1.13.2-619a29d2e3.patch":
   version: 1.13.2
-  resolution: "mocha-remote-server@patch:mocha-remote-server@npm%3A1.13.2#~/.yarn/patches/mocha-remote-server-npm-1.13.2-619a29d2e3.patch::version=1.13.2&hash=bab3ca"
+  resolution: "mocha-remote-server@patch:mocha-remote-server@npm%3A1.13.2#~/.yarn/patches/mocha-remote-server-npm-1.13.2-619a29d2e3.patch::version=1.13.2&hash=04ee13"
   dependencies:
     debug: "npm:^4.3.4"
     flatted: "npm:^3.3.1"
     mocha-remote-common: "npm:1.13.2"
     ws: "npm:^8.17.1"
-  checksum: 10/12dd1d674164de70bd3ad9b3ac545cb6de1a6e8aaec1bfaf62b3e699948667f38dd5d5fbf85382e412298dacc70dfc3ad9e80dd3aa6b8b89a442ea39fc6ae5d4
+  checksum: 10/cd9f2a1d15889e1fb7f3c63ae196ef8eea08ad9f0d3abc8ee7ff58f80edbddb7379c5fb322e710d5e6ebbce943157d683d806f1e207a7d7a2326852aa8666bfd
   languageName: node
   linkType: hard