refactor(auth): return sync parity for auth parsers

Author: mikehardy

.github/scripts/compare-types/configs/auth.ts

@@ -204,11 +204,6 @@ const config: PackageConfig = {
       reason:
         'RN Firebase modular UserCredential includes optional enumerable additionalUserInfo (firebase-js-sdk core fields plus preserved native bridge keys). firebase-js-sdk keeps additionalUserInfo off the public UserCredential interface — use getAdditionalUserInfo there.',
     },
-    {
-      name: 'isSignInWithEmailLink',
-      reason:
-        'iOS/Android: Promise<boolean> via native bridge. Other/All: not aligned yet; firebase-js-sdk synchronous boolean is possible on Other/Hermes and Other/Web.',
-    },
     {
       name: 'linkWithRedirect',
       reason:
@@ -241,8 +236,7 @@ const config: PackageConfig = {
     },
     {
       name: 'TotpSecret',
-      reason:
-        'iOS/Android: generateQrCodeUrl is Promise<string> via native bridge; openInOtpApp is an RN-only helper. Other/All: js-sdk synchronous generateQrCodeUrl is possible when MFA is supported on Other.',
+      reason: 'RN Firebase extension: openInOtpApp is an RN-only helper.',
     },
     {
       name: 'User',

docs/migrating-to-v26.mdx

@@ -558,6 +558,11 @@ The namespaced API for `@react-native-firebase/auth` has been **removed**. This
 | `auth().useEmulator(url)`                | `connectAuthEmulator(getAuth(), url, options?)`                 |
 | `firebase.auth.EmailAuthProvider`        | `EmailAuthProvider` (named export)                              |
 
+## Signature changes
+
+- `isSignInWithEmailLink(auth, emailLink)` now returns `boolean` synchronously, matching firebase-js-sdk.
+- `TotpSecret.generateQrCodeUrl(accountName?, issuer?)` now returns `string` synchronously, matching firebase-js-sdk. When `accountName` or `issuer` is omitted, React Native Firebase fills the same defaults from the current user email and Firebase app name.
+
 ## Example
 
 ```js

jest.setup.ts

@@ -204,7 +204,7 @@ jest.doMock('react-native', () => {
           finalizeMultiFactorEnrollment: jest.fn(() => Promise.resolve()),
           finalizeTotpEnrollment: jest.fn(() => Promise.resolve()),
           generateTotpSecret: jest.fn(() => Promise.resolve({ secretKey: 'secret' })),
-          generateQrCodeUrl: jest.fn(() => Promise.resolve('qr-url')),
+          generateQrCodeUrl: jest.fn(() => 'qr-url'),
           openInOtpApp: jest.fn(),
           resolveMultiFactorSignIn: jest.fn(() => Promise.resolve({ user: null })),
           confirmationResultConfirm: jest.fn(() => Promise.resolve({ user: null })),

okf-bundle/new-architecture/migration-work-queue.md

@@ -332,9 +332,9 @@ Skip steps 1–2 when spec shape is known (most Tier D packages).
 
 **Label:** `phase-s-sync-conversion` (2026-07-03)
 
-**Next item:** Phase **S** auth parser/TOTP URL sync conversion implementation
+**Next item:** Phase **S** perf metric controls sync conversion (`PS-perf-metrics`)
 
-**Current gates:** Phase **S** `app/registerVersion` gates **closed**; next pickup is auth parser/TOTP URL sync conversion.
+**Current gates:** PS-auth-parsers all gates **closed** — committing `refactor(auth): return sync parity for auth parsers`.
 
 **Host rule:** one `:test-cover` at a time — never parallel subagents with e2e.
 
@@ -373,7 +373,7 @@ Skip steps 1–2 when spec shape is known (most Tier D packages).
 | Phase R — remove `NativeModules` fallback | PR-fallback | **closed** | **closed** | **closed** | done | `full` + RNFBDebug | `refactor: cleanup legacy arch native module fallback` | Proof 683/823/849 (`/tmp/rnfb-e2e-phaseR-proof-*.log`). Review 2026-07-03: no critical/serious. Android cold boot committed separately. |
 | Phase S gap-analysis | PS-gap | n/a | n/a | n/a | done | `none` | none | Completed 2026-07-03. First implementation slice: `app/registerVersion`; follow-ups: auth parser/TOTP URL, then perf metric controls. |
 | Phase S `app/registerVersion` sync parity | PS-app-registerVersion | **closed** | **closed** | **closed** | done | `area-focused` | `refactor(app): return sync parity for registerVersion` | Implemented 2026-07-03: `registerVersion(): void`, sync throw Jest assertion, removed stale `configs/app.ts` async-vs-sync entry. Green: `lerna:prepare`, `tsc:compile`, `tsc:compile:consumer`, focused app Jest 10/10, `reference:api`, `compare:types`, `lint:js`. Independent review: no findings; no e2e needed for type-only scope. |
-| Phase S auth parser/TOTP sync parity | PS-auth-parsers | **open** | **open** | **open** | `implementation` | `unit-focused` | `refactor(auth): return sync parity for auth parsers` | Candidate methods: `isSignInWithEmailLink` and `TotpSecret.generateQrCodeUrl`; gap-analysis classified both as parser/string-only with cached native SDK objects. |
+| Phase S auth parser/TOTP sync parity | PS-auth-parsers | **closed** | **closed** | **closed** | done | `area-focused` | `refactor(auth): return sync parity for auth parsers` | Sync `isSignInWithEmailLink` + `TotpSecret.generateQrCodeUrl`; native sync error shape; jest.setup; tests + e2e sync calls; compare-types + v26 doc. Validation: Jest 91/91, compare:types, lint, reference:api, codegen:verify exit 0. Android area e2e 159/15/0 (`/tmp/rnfb-e2e-android-auth-phaseS-final.log`). |
 
 ---
 

packages/auth/__tests__/auth.test.ts

@@ -141,6 +141,13 @@ describe('Auth', function () {
       expect(isSignInWithEmailLink).toBeDefined();
     });
 
+    it('`isSignInWithEmailLink` returns synchronously', function () {
+      const result = isSignInWithEmailLink(getAuth(), 'https://example.com/link');
+
+      expect(result).toBe(false);
+      expect(result).not.toBeInstanceOf(Promise);
+    });
+
     it('`onAuthStateChanged` function is properly exposed to end user', function () {
       expect(onAuthStateChanged).toBeDefined();
     });
@@ -242,6 +249,67 @@ describe('Auth', function () {
       expect(ActionCodeURL.parseLink('https://example.com/not-an-action-link')).toBeNull();
     });
 
+    it('`TotpSecret.generateQrCodeUrl` returns synchronously with default account and issuer', function () {
+      const generateQrCodeUrl = jest.fn(
+        (_secretKey: string, _account: string, _issuer: string) => 'otpauth://totp/example',
+      );
+      const secret = new TotpSecret('secret-key', {
+        app: { name: '[DEFAULT]' },
+        currentUser: { email: 'user@example.com' },
+        native: { generateQrCodeUrl },
+      } as never);
+
+      const result = secret.generateQrCodeUrl();
+
+      expect(result).toBe('otpauth://totp/example');
+      expect(result).not.toBeInstanceOf(Promise);
+      expect(generateQrCodeUrl).toHaveBeenCalledWith('secret-key', 'user@example.com', '[DEFAULT]');
+    });
+
+    it('`TotpSecret.generateQrCodeUrl` throws auth/invalid-multi-factor-secret for a missing secret', function () {
+      const generateQrCodeUrl = jest.fn((_secretKey: string, _account: string, _issuer: string) => {
+        const error = new Error("can't find secret for provided key");
+        error.name = 'invalid-multi-factor-secret';
+        throw error;
+      });
+      const secret = new TotpSecret('missing-secret-key', {
+        app: { name: '[DEFAULT]' },
+        currentUser: { email: 'user@example.com' },
+        native: { generateQrCodeUrl },
+      } as never);
+
+      expect(() => secret.generateQrCodeUrl()).toThrow(
+        "[auth/invalid-multi-factor-secret] can't find secret for provided key",
+      );
+      expect(generateQrCodeUrl).toHaveBeenCalledWith(
+        'missing-secret-key',
+        'user@example.com',
+        '[DEFAULT]',
+      );
+    });
+
+    it('`TotpSecret.generateQrCodeUrl` forwards explicit account and issuer synchronously', function () {
+      const generateQrCodeUrl = jest.fn(
+        (_secretKey: string, _account: string, _issuer: string) =>
+          'otpauth://totp/Example%20App:account%40example.com',
+      );
+      const secret = new TotpSecret('secret-key', {
+        app: { name: '[DEFAULT]' },
+        currentUser: { email: 'user@example.com' },
+        native: { generateQrCodeUrl },
+      } as never);
+
+      const result = secret.generateQrCodeUrl('account@example.com', 'Example App');
+
+      expect(result).toBe('otpauth://totp/Example%20App:account%40example.com');
+      expect(result).not.toBeInstanceOf(Promise);
+      expect(generateQrCodeUrl).toHaveBeenCalledWith(
+        'secret-key',
+        'account@example.com',
+        'Example App',
+      );
+    });
+
     it('`deleteUser` function is properly exposed to end user', function () {
       expect(deleteUser).toBeDefined();
     });

packages/auth/__tests__/nativeModuleContract.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, jest } from '@jest/globals';
+import { describe, expect, it, jest } from '@jest/globals';
 import { assertTurboContract } from '../../app/__tests__/turboModuleContractHelper';
 
 const SPEC_METHODS = [
@@ -80,23 +80,32 @@ describe('TurboModule wrapper contract (NewArch-AD-17.1)', function () {
           APP_USER: { '[DEFAULT]': null },
         },
         createMock: method =>
-          jest.fn(() =>
-            method === 'configureAuthDomain' ||
-            method === 'addAuthStateListener' ||
-            method === 'removeAuthStateListener' ||
-            method === 'addIdTokenListener' ||
-            method === 'removeIdTokenListener' ||
-            method === 'setLanguageCode' ||
-            method === 'useDeviceLanguage' ||
-            method === 'openInOtpApp' ||
-            method === 'verifyPhoneNumber' ||
-            method === 'useEmulator' ||
-            method === 'isSignInWithEmailLink'
-              ? method === 'isSignInWithEmailLink'
-                ? false
-                : undefined
-              : Promise.resolve(),
-          ),
+          jest.fn(() => {
+            if (method === 'isSignInWithEmailLink') {
+              return false;
+            }
+
+            if (method === 'generateQrCodeUrl') {
+              return 'otpauth://totp/example';
+            }
+
+            if (
+              method === 'configureAuthDomain' ||
+              method === 'addAuthStateListener' ||
+              method === 'removeAuthStateListener' ||
+              method === 'addIdTokenListener' ||
+              method === 'removeIdTokenListener' ||
+              method === 'setLanguageCode' ||
+              method === 'useDeviceLanguage' ||
+              method === 'openInOtpApp' ||
+              method === 'verifyPhoneNumber' ||
+              method === 'useEmulator'
+            ) {
+              return undefined;
+            }
+
+            return Promise.resolve();
+          }),
       },
       {
         createUserWithEmailAndPassword: wrapped => {
@@ -160,7 +169,9 @@ describe('TurboModule wrapper contract (NewArch-AD-17.1)', function () {
           void wrapped.generateTotpSecret('session');
         },
         generateQrCodeUrl: wrapped => {
-          void wrapped.generateQrCodeUrl('secret', 'account', 'issuer');
+          const result = wrapped.generateQrCodeUrl('secret', 'account', 'issuer');
+          expect(result).toBe('otpauth://totp/example');
+          expect(result).not.toBeInstanceOf(Promise);
         },
         openInOtpApp: wrapped => {
           wrapped.openInOtpApp('secret', 'otpauth://totp/example');
@@ -198,6 +209,11 @@ describe('TurboModule wrapper contract (NewArch-AD-17.1)', function () {
         useEmulator: wrapped => {
           wrapped.useEmulator('localhost', 9099);
         },
+        isSignInWithEmailLink: wrapped => {
+          const result = wrapped.isSignInWithEmailLink('https://example.com/link');
+          expect(result).toBe(false);
+          expect(result).not.toBeInstanceOf(Promise);
+        },
         forceRecaptchaFlowForTesting: wrapped => {
           void wrapped.forceRecaptchaFlowForTesting(true);
         },

packages/auth/android/src/main/java/io/invertase/firebase/auth/NativeRNFBTurboAuth.java

@@ -427,14 +427,13 @@ public void createUserWithEmailAndPassword(
    * isSignInWithEmailLink
    *
    * @param email
-   * @param promise
    */
   @Override
-  public void isSignInWithEmailLink(String appName, String emailLink, final Promise promise) {
+  public boolean isSignInWithEmailLink(String appName, String emailLink) {
     Log.d(TAG, "isSignInWithEmailLink");
     FirebaseApp firebaseApp = FirebaseApp.getInstance(appName);
     FirebaseAuth firebaseAuth = FirebaseAuth.getInstance(firebaseApp);
-    promise.resolve(firebaseAuth.isSignInWithEmailLink(emailLink));
+    return firebaseAuth.isSignInWithEmailLink(emailLink);
   }
 
   /**
@@ -1322,20 +1321,15 @@ public void finalizeMultiFactorEnrollment(
   }
 
   @Override
-  public void generateQrCodeUrl(
-      final String appName,
-      final String secretKey,
-      final String account,
-      final String issuer,
-      final Promise promise) {
+  public String generateQrCodeUrl(
+      final String appName, final String secretKey, final String account, final String issuer) {
 
     TotpSecret secret = mTotpSecrets.get(secretKey);
     if (secret == null) {
-      rejectPromiseWithCodeAndMessage(
-          promise, "invalid-multi-factor-secret", "can't find secret for provided key");
-      return;
+      throw new ReactNativeFirebaseAuthSyncException(
+          "invalid-multi-factor-secret", "can't find secret for provided key");
     }
-    promise.resolve(secret.generateQrCodeUrl(account, issuer));
+    return secret.generateQrCodeUrl(account, issuer);
   }
 
   @Override

packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthSyncException.java

@@ -0,0 +1,35 @@
+package io.invertase.firebase.auth;
+
+/*
+ * Copyright (c) 2016-present Invertase Limited & Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this library except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+/**
+ * Structured sync TurboModule error carrying the same RNFB {@code code}/{@code message} pair used by
+ * {@code rejectPromiseWithCodeAndMessage}.
+ */
+public class ReactNativeFirebaseAuthSyncException extends RuntimeException {
+  private final String code;
+
+  public ReactNativeFirebaseAuthSyncException(String code, String message) {
+    super(message);
+    this.code = code;
+  }
+
+  public String getCode() {
+    return code;
+  }
+}

packages/auth/android/src/main/java/io/invertase/firebase/auth/generated/java/com/facebook/fbreact/specs/NativeRNFBTurboAuthSpec.java

@@ -118,9 +118,9 @@ public NativeRNFBTurboAuthSpec(ReactApplicationContext reactContext) {
   @DoNotStrip
   public abstract void createUserWithEmailAndPassword(String appName, String email, String password, Promise promise);
 
-  @ReactMethod
+  @ReactMethod(isBlockingSynchronousMethod = true)
   @DoNotStrip
-  public abstract void isSignInWithEmailLink(String appName, String emailLink, Promise promise);
+  public abstract boolean isSignInWithEmailLink(String appName, String emailLink);
 
   @ReactMethod
   @DoNotStrip
@@ -218,9 +218,9 @@ public NativeRNFBTurboAuthSpec(ReactApplicationContext reactContext) {
   @DoNotStrip
   public abstract void generateTotpSecret(String appName, String sessionKey, Promise promise);
 
-  @ReactMethod
+  @ReactMethod(isBlockingSynchronousMethod = true)
   @DoNotStrip
-  public abstract void generateQrCodeUrl(String appName, String secretKey, String account, String issuer, Promise promise);
+  public abstract String generateQrCodeUrl(String appName, String secretKey, String account, String issuer);
 
   @ReactMethod
   @DoNotStrip

packages/auth/android/src/main/java/io/invertase/firebase/auth/generated/jni/RNFBAuthTurboModules-generated.cpp

@@ -84,7 +84,7 @@ static facebook::jsi::Value __hostFunction_NativeRNFBTurboAuthSpecJSI_createUser
 
 static facebook::jsi::Value __hostFunction_NativeRNFBTurboAuthSpecJSI_isSignInWithEmailLink(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) {
   static jmethodID cachedMethodId = nullptr;
-  return static_cast<JavaTurboModule &>(turboModule).invokeJavaMethod(rt, PromiseKind, "isSignInWithEmailLink", "(Ljava/lang/String;Ljava/lang/String;Lcom/facebook/react/bridge/Promise;)V", args, count, cachedMethodId);
+  return static_cast<JavaTurboModule &>(turboModule).invokeJavaMethod(rt, BooleanKind, "isSignInWithEmailLink", "(Ljava/lang/String;Ljava/lang/String;)Z", args, count, cachedMethodId);
 }
 
 static facebook::jsi::Value __hostFunction_NativeRNFBTurboAuthSpecJSI_signInWithEmailAndPassword(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) {
@@ -209,7 +209,7 @@ static facebook::jsi::Value __hostFunction_NativeRNFBTurboAuthSpecJSI_generateTo
 
 static facebook::jsi::Value __hostFunction_NativeRNFBTurboAuthSpecJSI_generateQrCodeUrl(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) {
   static jmethodID cachedMethodId = nullptr;
-  return static_cast<JavaTurboModule &>(turboModule).invokeJavaMethod(rt, PromiseKind, "generateQrCodeUrl", "(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lcom/facebook/react/bridge/Promise;)V", args, count, cachedMethodId);
+  return static_cast<JavaTurboModule &>(turboModule).invokeJavaMethod(rt, StringKind, "generateQrCodeUrl", "(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;", args, count, cachedMethodId);
 }
 
 static facebook::jsi::Value __hostFunction_NativeRNFBTurboAuthSpecJSI_openInOtpApp(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) {