Skip to content

Change nativeErrorCode, nativeErrorMessage to be nullable #8206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvliwanag wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Change nativeErrorCode, nativeErrorMessage to be nullable #8206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app/lib/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ export namespace ReactNativeFirebase {
/**
* The native sdks returned error code, different per platform
*/
readonly nativeErrorCode: string | number;
readonly nativeErrorCode: string | number | null;

/**
* The native sdks returned error message, different per platform
*/
readonly nativeErrorMessage: string;
readonly nativeErrorMessage: string | null;
}

export type LogLevelString = 'debug' | 'verbose' | 'info' | 'warn' | 'error' | 'silent';
Expand Down