fix(firestore): type definitions

[SelaseKay]

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
  • Other (macOS, web)
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2025 0:50am

[github-actions]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (8f59579) to head (796493f).
Report is 52 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8378      +/-   ##
==========================================
- Coverage   71.78%   69.79%   -1.99%     
==========================================
  Files         163      187      +24     
  Lines        6626     8039    +1413     
  Branches     1524     1840     +316     
==========================================
+ Hits         4756     5610     +854     
- Misses       1749     2238     +489     
- Partials      121      191      +70     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MichaelVerdon]

Kept definition for onSnapshotsInSync() which will merge with other PR that actually implements it.

[mikehardy]

These look ready to go in, with exception of a question about the empty VectorValue.d.ts file - should that exist, or should it be deleted before mergin?

[mikehardy]

Why is there an empty file in here? 🤔

[mikehardy]

I removed it, I think that was the right call?

[mikehardy]

@russellwheatley / @MichaelVerdon I rebased this to main and pushed it out, minus the empty modular/VectorValue.d.ts file - I think this is ready to go though ? +1 from me for merge anyway. Any last thoughts from you two no this one?

[macksal]

I think this should be reverted as the updates to type definitions are incorrect. Query, CollectionReference and friends only take one type parameter. Firestore types are currently broken for all typescript-based consumers in #8611

[cbdeveloper]

I believe this is already being fixed as per the comment above, but just in case, I'm also getting querySnapshot as any in all of my onSnapshot usage. This was not happening before, and I recently updated to 23.3.1.

This is the signature I'm using:

import { onSnapshot } from '@react-native-firebase/firestore';

const unsubscribe = onSnapshot(q, (querySnapshot <--- this is being evaluated as any) => {});