Skip to content

feat(firestore): add support for onSnapshotsInSync#8379

Merged
mikehardy merged 50 commits into
mainfrom
feat-add-onSnapshotsInSync-support
Jun 30, 2025
Merged

feat(firestore): add support for onSnapshotsInSync#8379
mikehardy merged 50 commits into
mainfrom
feat-add-onSnapshotsInSync-support

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Feb 28, 2025

Copy link
Copy Markdown
Collaborator

Description

Currently the firebase-js-sdk has an onSnapshotsInSync API and react-native-firebase does not

This PR (when complete) will close that feature gap)

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - is this a namespace -> modular gap, or a feature gap between RNFB and firebase-js-sdk?

There's no info in the PR beyond the boilerplate template contents

@SelaseKay

Copy link
Copy Markdown
Collaborator Author

@mikehardy, it's a feature. onSnapshotsInSync is not supported in RNFB, both in the JS and natively. This PR is not complete.

@mikehardy

Copy link
Copy Markdown
Collaborator

Ah, thanks. I updated the description to match in case I take a peek again

@github-actions

Copy link
Copy Markdown

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@vercel

vercel Bot commented Apr 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2025 0:10am

@russellwheatley

Copy link
Copy Markdown
Member

@MichaelVerdon - I've updated so it works on android. Setup a test app for onSnapshotInSync.

You will need to update the path to point towards it here: https://github.com/invertase/react-native-firebase/blob/feat-add-onSnapshotsInSync-support/tests/test-app/index.js#L6

To run the example test app, run these scripts: https://github.com/invertase/react-native-firebase/blob/feat-add-onSnapshotsInSync-support/package.json#L56-L58

Remember to have the emulator or simulator running depending on if you're running android or iOS.

Comment thread packages/firestore/ios/RNFBFirestore/RNFBFirestoreModule.m
Comment thread packages/firestore/e2e/firestore.e2e.js
Comment thread packages/firestore/e2e/firestore.e2e.js
Comment thread packages/firestore/e2e/firestore.e2e.js Outdated
Comment thread packages/firestore/e2e/firestore.e2e.js Outdated
@russellwheatley russellwheatley changed the title chore(firestore): add support for onSnapshotsInSync feat(firestore): add support for onSnapshotsInSync Jun 10, 2025

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! honestly, everything looks great here

@mikehardy mikehardy merged commit f8c1464 into main Jun 30, 2025
19 checks passed
@mikehardy mikehardy deleted the feat-add-onSnapshotsInSync-support branch June 30, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants