feat(firestore): add support for onSnapshotsInSync#8379
Conversation
mikehardy
left a comment
There was a problem hiding this comment.
Just curious - is this a namespace -> modular gap, or a feature gap between RNFB and firebase-js-sdk?
There's no info in the PR beyond the boilerplate template contents
|
@mikehardy, it's a feature. |
|
Ah, thanks. I updated the description to match in case I take a peek again |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@MichaelVerdon - I've updated so it works on android. Setup a test app for onSnapshotInSync. You will need to update the path to point towards it here: https://github.com/invertase/react-native-firebase/blob/feat-add-onSnapshotsInSync-support/tests/test-app/index.js#L6 To run the example test app, run these scripts: https://github.com/invertase/react-native-firebase/blob/feat-add-onSnapshotsInSync-support/package.json#L56-L58 Remember to have the emulator or simulator running depending on if you're running android or iOS. |
mikehardy
left a comment
There was a problem hiding this comment.
wow! honestly, everything looks great here
Description
Currently the firebase-js-sdk has an onSnapshotsInSync API and react-native-firebase does not
This PR (when complete) will close that feature gap)
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter