Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/firestore/e2e/firestore.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -1011,5 +1011,18 @@ describe('firestore()', function () {
events.forEach(event => event.should.equal('sync'));
});
});

describe('non-default db', function () {
it('should be able to initialize a non-default db on mobile platforms', async function () {
// Not supported on web lite sdk
if (!Platform.other) {
const { initializeFirestore } = firestoreModular;
const { getApp } = modular;
const app = getApp('secondaryFromNative');
const db = await initializeFirestore(app, { persistence: false }, 'test2ndDb');
db.customUrlOrRegion.should.equal('test2ndDb');
}
});
});
});
});
5 changes: 5 additions & 0 deletions packages/firestore/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ class FirebaseFirestoreModule extends FirebaseModule {
persistence: true,
};
}

get customUrlOrRegion() {
return this._customUrlOrRegion;
}

// We override the FirebaseModule's `eventNameForApp()` method to include the customUrlOrRegion
eventNameForApp(...args) {
return `${this.app.name}-${this._customUrlOrRegion}-${args.join('-')}`;
Expand Down
5 changes: 2 additions & 3 deletions packages/firestore/lib/modular/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,9 @@ export function waitForPendingWrites(firestore) {
* @param {string?} databaseId
* @returns {Promise<Firestore>}
*/
export async function initializeFirestore(app, settings /* databaseId */) {
// TODO(exaby73): implement 2nd database once it's supported
export async function initializeFirestore(app, settings, databaseId) {
const firebase = getApp(app.name);
const firestore = firebase.firestore();
const firestore = firebase.firestore(databaseId);
await firestore.settings.call(firestore, settings, MODULAR_DEPRECATION_ARG);
return firestore;
}
Expand Down
Loading