Skip to content

fix(auth): missing PhoneMultiFactorGenerator export#8508

Merged
mikehardy merged 1 commit into
invertase:mainfrom
DoctorJohn:fix-auth-phonemultifactorgenerator-export
May 1, 2025
Merged

fix(auth): missing PhoneMultiFactorGenerator export#8508
mikehardy merged 1 commit into
invertase:mainfrom
DoctorJohn:fix-auth-phonemultifactorgenerator-export

Conversation

@DoctorJohn

Copy link
Copy Markdown
Contributor

Description

This PR fixes that the PhoneMultiFactorGenerator class was not properly exported via the modular API.

Related issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I updated the auth package's jest tests and verified they pass/fail with/without the relevant code changes.

🔥


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel

vercel Bot commented May 1, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 5:51pm

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah 🤦 - thanks @DoctorJohn

@mikehardy mikehardy merged commit aaaec03 into invertase:main May 1, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants