You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a universal link that has nothing to do with firebase. but when i link into the url, the link has nil url host and falls into the generated expo prebuild linking code and returns NO. which is inappropriate and needed that url to pass to the very bottom of the linking delegate code.
Related issues
Release Summary
Checklist
I read the Contributor Guide and followed the process outlined there for submitting PRs.
Yes
My change supports the following platforms;
Android
iOS
Other (macOS, web)
My change includes tests;
e2e tests added or updated in packages/\*\*/e2e
jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
Yes
No
Test Plan
you can test with url with nullable(nil) url host. in my case, i tested with a custom universal link that has nothing to do with firebase app
Think react-native-firebase is great? Please consider supporting the project with any of the below:
yjb94
changed the title
fix(auth,ios): fixes inappropriate branching when host is nil
fix(auth,ios): fixes inappropriate linking when host is nil
May 7, 2025
The reason will be displayed to describe this comment to others. Learn more.
Hey @yjb94 👋 this looks like a great change, I'd love to merge it - thank you for posting the PR. Could you sign the CLA as indicated in the details link for the failed CI check / and/or the CLA check comment? Thanks!
mikehardy
changed the title
fix(auth,ios): fixes inappropriate linking when host is nil
fix(auth, ios): fixes inappropriate linking when host is nil
May 12, 2025
Hey @yjb94 👋 this looks like a great change, I'd love to merge it - thank you for posting the PR. Could you sign the CLA as indicated in the details link for the failed CI check / and/or the CLA check comment? Thanks!
i've signed for CLA :) thak you,
and i assume changing the title you just made PR Title cheking CI task failed. could you please check it? thank you
@yjb94 - yep, the title change was just so it would populate in the squash-merge github text box the way I wanted it. Merged and will release next time I publish - I just published a release today so it may be a couple days but it won't sit too long. We do small releases pretty frequently so things don't queue up. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have a universal link that has nothing to do with firebase. but when i link into the url, the link has nil url host and falls into the generated expo prebuild linking code and returns NO. which is inappropriate and needed that url to pass to the very bottom of the linking delegate code.
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
you can test with url with nullable(nil) url host. in my case, i tested with a custom universal link that has nothing to do with firebase app
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter