refactor(auth)!: Migrate to typescript

jest.config.js

@@ -20,6 +20,10 @@ module.exports = {
     '^.+\\.(js)$': '<rootDir>/node_modules/babel-jest',
     '\\.(ts|tsx)$': ['ts-jest', { tsconfig: './tsconfig-jest.json' }],
   },
+  // Strip explicit `.js` from relative imports so Jest resolves sibling `.ts` sources.
+  moduleNameMapper: {
+    '^(\\.{1,2}/.*)\\.js$': '$1',
+  },
   setupFiles: ['./jest.setup.ts'],
   testMatch: ['**/packages/**/__tests__/**/*.test.(ts|js)'],
   modulePaths: ['node_modules', './tests/node_modules'],

package.json

@@ -57,8 +57,7 @@
     "tests:ios:test-cover-reuse": "cd tests && SIMCTL_CHILD_GULGeneratedClassDisposeDisabled=1 node_modules/.bin/nyc yarn detox test --configuration ios.sim.debug --reuse --loglevel warn",
     "tests:ios:pod:install": "cd tests && rm -f ios/Podfile.lock && rm -rf ios/ReactNativeFirebaseDemo.xcworkspace && cd ios && pod install",
     "tests:macos:build": "cd tests && yarn build:macos",
-    "tests:macos:pod:install": "cd tests && rm -f macos/Podfile.lock && cd macos && pod install",
-    "tests:macos:manual": "cd tests && yarn react-native run-macos",
+    "tests:macos:pod:install": "cd tests && rm -f macos/Podfile.lock && cd macos && pod install",    "tests:macos:manual": "cd tests && yarn react-native run-macos",
     "tests:macos:test": "cd tests && npx jet --target=macos --coverage",
     "tests:macos:test-cover": "cd tests && npx jet --target=macos --coverage",
     "format:js": "prettier --write \"packages/**/*.{js,ts,tsx}\"",

packages/ai/__tests__/live-session.test.ts

@@ -29,6 +29,8 @@ import { AIError } from '../lib/errors';
 import { logger } from '../lib/logger';
 import { ReadableStream } from 'web-streams-polyfill';
 
+type LiveReceiveYield = LiveServerContent | LiveServerToolCall | LiveServerToolCallCancellation;
+
 class MockWebSocketHandler implements WebSocketHandler {
   connect = jest.fn<() => Promise<void>>().mockResolvedValue(undefined);
   send = jest.fn<(data: string | ArrayBuffer) => void>();
@@ -216,7 +218,7 @@ describe('LiveSession', function () {
   describe('receive()', function () {
     it('should correctly parse and transform all server message types', async function () {
       const receivePromise = (async () => {
-        const responses = [];
+        const responses: LiveReceiveYield[] = [];
         for await (const response of session.receive()) {
           responses.push(response);
         }
@@ -257,7 +259,7 @@ describe('LiveSession', function () {
     it('should log a warning and skip messages that are not objects', async function () {
       const loggerSpy = jest.spyOn(logger, 'warn');
       const receivePromise = (async () => {
-        const responses = [];
+        const responses: LiveReceiveYield[] = [];
         for await (const response of session.receive()) {
           responses.push(response);
         }
@@ -282,7 +284,7 @@ describe('LiveSession', function () {
     it('should log a warning and skip objects of unknown type', async function () {
       const loggerSpy = jest.spyOn(logger, 'warn');
       const receivePromise = (async () => {
-        const responses = [];
+        const responses: LiveReceiveYield[] = [];
         for await (const response of session.receive()) {
           responses.push(response);
         }

packages/ai/lib/public-types.ts

@@ -16,7 +16,7 @@
  */
 
 import { ReactNativeFirebase } from '@react-native-firebase/app';
-import { FirebaseAuthTypes } from '@react-native-firebase/auth';
+import type { FirebaseAuthTypes } from '@react-native-firebase/auth';
 import { FirebaseAppCheckTypes } from '@react-native-firebase/app-check';
 import { Backend } from './backend';
 

packages/ai/lib/requests/request.ts

@@ -153,7 +153,7 @@ export class TemplateRequestUrl {
  * Log language and "fire/version" to x-goog-api-client
  */
 function getClientHeaders(): string {
-  const loggingTags = [];
+  const loggingTags: string[] = [];
   loggingTags.push(`${LANGUAGE_TAG}/${PACKAGE_VERSION}`);
   loggingTags.push(`fire/${PACKAGE_VERSION}`);
   return loggingTags.join(' ');

packages/ai/lib/requests/response-helpers.ts

@@ -160,7 +160,7 @@ export function getText(
   response: GenerateContentResponse,
   partFilter: (part: Part) => boolean,
 ): string {
-  const textStrings = [];
+  const textStrings: string[] = [];
   if (response.candidates?.[0]?.content?.parts) {
     for (const part of response.candidates?.[0]?.content?.parts) {
       if (part.text && partFilter(part)) {

packages/ai/lib/requests/schema-builder.ts

@@ -259,7 +259,7 @@ export class ObjectSchema extends Schema {
   toJSON(): SchemaRequest {
     const obj = super.toJSON();
     obj.properties = { ...this.properties };
-    const required = [];
+    const required: string[] = [];
     if (this.optionalProperties) {
       for (const propertyKey of this.optionalProperties) {
         if (!this.properties.hasOwnProperty(propertyKey)) {

packages/ai/lib/service.ts

@@ -17,7 +17,7 @@
 
 import { ReactNativeFirebase } from '@react-native-firebase/app';
 import { AI, Backend } from './public-types';
-import { FirebaseAuthTypes } from '@react-native-firebase/auth';
+import type { FirebaseAuthTypes } from '@react-native-firebase/auth';
 import { FirebaseAppCheckTypes } from '@react-native-firebase/app-check';
 import { VertexAIBackend } from './backend';
 

packages/ai/tsconfig.json

@@ -32,7 +32,7 @@
       ],
       "@react-native-firebase/app/lib/internal": ["../app/dist/typescript/lib/internal"],
       "@react-native-firebase/app": ["../app/dist/typescript/lib"],
-      "@react-native-firebase/auth": ["../auth/lib"],
+      "@react-native-firebase/auth": ["../auth/dist/typescript/lib"],
       "@react-native-firebase/app-check": ["../app-check/dist/typescript/lib"]
     }
   },

packages/app-check/lib/web/RNFBAppCheckModule.android.ts

@@ -1,4 +1,4 @@
-// No-op for android.
-const module: Record<string, never> = {};
+// No-op for android. Avoid binding name `module` (Jest runs TS in a CJS context).
+const noopNativeModule: Record<string, never> = {};
 
-export default module;
+export default noopNativeModule;

packages/app-check/lib/web/RNFBAppCheckModule.ios.ts

@@ -1,4 +1,4 @@
-// No-op for ios.
-const module: Record<string, never> = {};
+// No-op for ios. Avoid binding name `module` (Jest runs TS in a CJS context).
+const noopNativeModule: Record<string, never> = {};
 
-export default module;
+export default noopNativeModule;

packages/app/lib/common/Base64.ts

@@ -15,7 +15,6 @@
  *
  */
 
-// @ts-expect-error - No type declarations available
 import binaryToBase64 from 'react-native/Libraries/Utilities/binaryToBase64';
 import { promiseDefer } from './promise';
 

packages/app/lib/shims/react-native-binaryToBase64.d.ts

@@ -0,0 +1,7 @@
+/*
+ * Deep import from `react-native` (not declared in `@types/react-native`).
+ * Used by @react-native-firebase/app Base64 helper.
+ */
+declare module 'react-native/Libraries/Utilities/binaryToBase64' {
+  export default function binaryToBase64(data: ArrayBuffer | Uint8Array): string;
+}

packages/auth/e2e/phone.e2e.js

@@ -46,12 +46,11 @@ describe('auth() => Phone', function () {
         confirmResult.confirm.should.be.a.Function();
         const lastSmsCode = await getLastSmsCode(testPhone);
         const userCredential = await confirmResult.confirm(lastSmsCode);
-        userCredential.user.should.be.instanceOf(
-          require('@react-native-firebase/auth/lib/User').default,
-        );
-
-        // Broken check, phone number is undefined
-        // userCredential.user.phoneNumber.should.equal(TEST_PHONE_A);
+        const { user } = userCredential;
+        // Avoid instanceof: Metro may load User from two module paths (main vs deep require).
+        user.constructor.name.should.equal('User');
+        user.uid.should.be.a.String();
+        user.phoneNumber.should.equal(testPhone);
       });
 
       it('errors on invalid code', async function () {
@@ -237,12 +236,11 @@ describe('auth() => Phone', function () {
         confirmResult.confirm.should.be.a.Function();
         const lastSmsCode = await getLastSmsCode(testPhone);
         const userCredential = await confirmResult.confirm(lastSmsCode);
-        userCredential.user.should.be.instanceOf(
-          require('@react-native-firebase/auth/lib/User').default,
-        );
-
-        // Broken check, phone number is undefined
-        // userCredential.user.phoneNumber.should.equal(TEST_PHONE_A);
+        const { user } = userCredential;
+        // Avoid instanceof: Metro may load User from two module paths (main vs deep require).
+        user.constructor.name.should.equal('User');
+        user.uid.should.be.a.String();
+        user.phoneNumber.should.equal(testPhone);
       });
 
       it('errors on invalid code', async function () {

packages/auth/e2e/user.e2e.js

@@ -622,7 +622,8 @@ describe('auth().currentUser', function () {
           try {
             await firebase.auth().currentUser.delete();
           } catch (e) {
-            consle.log(e);
+            // eslint-disable-next-line no-console
+            console.log(e);
             /* do nothing */
           }
 
@@ -1621,7 +1622,8 @@ describe('auth().currentUser', function () {
           try {
             await deleteUser(auth.currentUser);
           } catch (e) {
-            consle.log(e);
+            // eslint-disable-next-line no-console
+            console.log(e);
             /* do nothing */
           }
 

packages/auth/lib/ConfirmationResult.js → packages/auth/lib/ConfirmationResult.ts

@@ -15,19 +15,24 @@
  *
  */
 
+import type { AuthInternal } from './types/internal';
+
 export default class ConfirmationResult {
-  constructor(auth, verificationId) {
+  _auth: AuthInternal;
+  _verificationId: string;
+
+  constructor(auth: AuthInternal, verificationId: string) {
     this._auth = auth;
     this._verificationId = verificationId;
   }
 
-  confirm(verificationCode) {
+  confirm(verificationCode: string): Promise<unknown> {
     return this._auth.native
       .confirmationResultConfirm(verificationCode)
-      .then(userCredential => this._auth._setUserCredential(userCredential));
+      .then((userCredential: unknown) => this._auth._setUserCredential(userCredential));
   }
 
-  get verificationId() {
+  get verificationId(): string {
     return this._verificationId;
   }
 }

packages/auth/lib/MultiFactorResolver.ts

@@ -0,0 +1,51 @@
+/*
+ * Copyright (c) 2016-present Invertase Limited & Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this library except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+import type { AuthInternal } from './types/internal';
+import type { MultiFactorInfo } from './types/auth';
+
+interface ResolverShape {
+  hints: MultiFactorInfo[];
+  session: string;
+}
+
+export default class MultiFactorResolver {
+  _auth: AuthInternal;
+  hints: MultiFactorInfo[];
+  session: string;
+
+  constructor(auth: AuthInternal, resolver: ResolverShape) {
+    this._auth = auth;
+    this.hints = resolver.hints;
+    this.session = resolver.session;
+  }
+
+  resolveSignIn(assertion: {
+    token?: string;
+    secret?: string;
+    uid?: string;
+    verificationCode?: string;
+  }): Promise<unknown> {
+    const { token, secret, uid, verificationCode } = assertion;
+
+    if (token && secret) {
+      return this._auth.resolveMultiFactorSignIn(this.session, token, secret);
+    }
+
+    return this._auth.resolveTotpSignIn(this.session, uid ?? '', verificationCode ?? '');
+  }
+}