docs: add mdx file linting, fixup all mdx-related errors#8993
Merged
Conversation
previously it was working in compability mode and the config was a mess of technical debt, now the config is squeaky clean and ready for future additions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds an 'AI Logic' group to the documentation, updates versioning language in MDX files, and migrates the ESLint configuration to the Flat Config format. Feedback focuses on correcting the ESLint configuration, where the extends key is invalid and configs.all was unintentionally enabled. Additionally, logical errors were identified in the Android and iOS installation guides regarding manual integration requirements, and the markdown linting glob was found to be too restrictive, potentially excluding standard .md files.
russellwheatley
approved these changes
Apr 23, 2026
b7f4f4c to
b71dc39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were some problems in the conversion from previous Gatsby static website build and dynamic docs.page mdx build - specifically some of the files had invalid MDX
This PR adds an MDX linter to our eslint config, and configures our
lint:markdownrun target to use it, then fixes all errors that turned upAn unfortunate discovery was that when I previously converted our eslint config file from the legacy format to the new "flat config" format I did so in a compatibility mode that was a real hash - I paid up the technical debt and forward-ported us to a really clean eslint "flat config" style in the first commit so that I could add the mdx file easily
Related issues
Release Summary
docs only, will go live once merged to main
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
1- hit rnfirebase.io/messaging/usage and it should work (can check the preview link as well, and should work --> https://rnfirebase.io/~8993/messaging/usage )
2-
yarn lint:markdownshould also pass, and will be exercised in CI (or when tested locally) to make sure nothing creeps in over time without us knowingThink
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter