refactor(ml,app-distribution): align namespaced firebase export with other packages#9042
refactor(ml,app-distribution): align namespaced firebase export with other packages#9042mikehardy wants to merge 2 commits into
Conversation
…other packages Use FirebaseNamespacedExport instead of the manual Module intersection type.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a minor refactor to standardize how Firebase modules are exported within the ML and App Distribution packages. By adopting the FirebaseNamespacedExport utility, the codebase achieves better consistency and maintainability without altering the functional behavior of the packages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the exported firebase types in the app-distribution and ml packages to use the generic FirebaseNamespacedExport type. A review comment points out that for the ml package, the fourth generic parameter (representing multi-app support) is incorrectly set to false instead of true, which should be corrected to match the module's actual configuration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
Use FirebaseNamespacedExport instead of the manual Module intersection type.
This was noticed as an inconsistency in these two packages during migration debt analysis
Small refactor to align them with what I believe is best practice
Related issues
Release Summary
Minor refactor, should have no effect.
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
types tests still pass
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter