Skip to content

refactor(ml,app-distribution): align namespaced firebase export with other packages#9042

Open
mikehardy wants to merge 2 commits into
mainfrom
ts-align-namespace-exports
Open

refactor(ml,app-distribution): align namespaced firebase export with other packages#9042
mikehardy wants to merge 2 commits into
mainfrom
ts-align-namespace-exports

Conversation

@mikehardy

Copy link
Copy Markdown
Collaborator

Description

Use FirebaseNamespacedExport instead of the manual Module intersection type.

This was noticed as an inconsistency in these two packages during migration debt analysis

Small refactor to align them with what I believe is best practice

Related issues

Release Summary

Minor refactor, should have no effect.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

types tests still pass


Think react-native-firebase is great? Please consider supporting the project with any of the below:

…other packages

Use FirebaseNamespacedExport instead of the manual Module intersection type.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a minor refactor to standardize how Firebase modules are exported within the ML and App Distribution packages. By adopting the FirebaseNamespacedExport utility, the codebase achieves better consistency and maintainability without altering the functional behavior of the packages.

Highlights

  • Type Definition Refactoring: Replaced manual Module intersection types with the standardized FirebaseNamespacedExport utility in both the ML and App Distribution packages.
  • Code Consistency: Aligned the namespaced exports with existing best practices across the repository to resolve inconsistencies identified during migration debt analysis.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Jun 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the exported firebase types in the app-distribution and ml packages to use the generic FirebaseNamespacedExport type. A review comment points out that for the ml package, the fourth generic parameter (representing multi-app support) is incorrectly set to false instead of true, which should be corrected to match the module's actual configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/ml/lib/namespaced.ts
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Workflow: Needs Review Pending feedback or review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant