From 359f84d4551adcf31cc739979d90b71fa3e38569 Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Tue, 9 Jun 2026 20:32:57 -0500 Subject: [PATCH 1/2] refactor(ml,app-distribution): align namespaced firebase export with other packages Use FirebaseNamespacedExport instead of the manual Module intersection type. --- packages/app-distribution/lib/namespaced.ts | 16 ++++++++++------ packages/ml/lib/namespaced.ts | 11 +++++++---- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/packages/app-distribution/lib/namespaced.ts b/packages/app-distribution/lib/namespaced.ts index cb8b14ffc2..29debe5b51 100644 --- a/packages/app-distribution/lib/namespaced.ts +++ b/packages/app-distribution/lib/namespaced.ts @@ -91,9 +91,13 @@ const appDistributionNamespace = createModuleNamespace({ export default appDistributionNamespace; -export const firebase = getFirebaseRoot() as unknown as ReactNativeFirebase.Module & { - appDistribution: typeof appDistributionNamespace; - app(name?: string): ReactNativeFirebase.FirebaseApp & { - appDistribution(): FirebaseAppDistributionTypes.Module; - }; -}; +// import appDistribution, { firebase } from '@react-native-firebase/app-distribution'; +// appDistribution().X(...); +// firebase.appDistribution().X(...); +export const firebase = + getFirebaseRoot() as unknown as ReactNativeFirebase.FirebaseNamespacedExport< + 'appDistribution', + FirebaseAppDistributionTypes.Module, + FirebaseAppDistributionTypes.Statics, + false + >; diff --git a/packages/ml/lib/namespaced.ts b/packages/ml/lib/namespaced.ts index dc838e65c9..f9baa70f35 100644 --- a/packages/ml/lib/namespaced.ts +++ b/packages/ml/lib/namespaced.ts @@ -62,7 +62,10 @@ export default defaultExport; // import ml, { firebase } from '@react-native-firebase/ml'; // ml().X(...); // firebase.ml().X(...); -export const firebase = getFirebaseRoot() as unknown as ReactNativeFirebase.Module & { - ml: typeof defaultExport; - app(name?: string): ReactNativeFirebase.FirebaseApp & { ml(): FirebaseMLTypes.Module }; -}; +export const firebase = + getFirebaseRoot() as unknown as ReactNativeFirebase.FirebaseNamespacedExport< + 'ml', + FirebaseMLTypes.Module, + FirebaseMLTypes.Statics, + false + >; From e44b12d9fb49b3716f3e0b306a99633264d839be Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Tue, 9 Jun 2026 20:53:42 -0500 Subject: [PATCH 2/2] Update packages/ml/lib/namespaced.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- packages/ml/lib/namespaced.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ml/lib/namespaced.ts b/packages/ml/lib/namespaced.ts index f9baa70f35..cfb964ac92 100644 --- a/packages/ml/lib/namespaced.ts +++ b/packages/ml/lib/namespaced.ts @@ -67,5 +67,5 @@ export const firebase = 'ml', FirebaseMLTypes.Module, FirebaseMLTypes.Statics, - false + true >;