chore: fix issue labeler and restrict workflow token permissions#9058
Merged
Conversation
Replace unmaintained actions-ecosystem actions with github-script, use step outputs instead of env context, and restrict token permissions to issues: write only.
Declare explicit minimal GITHUB_TOKEN permissions on workflows that previously inherited the org default, and fix a missing newline in the stale issue message.
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Collaborator
Author
|
this has already passed any of the CI checks that would be affected by the changes --> merging so labeler is fixed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9058 +/- ##
==========================================
+ Coverage 60.88% 61.38% +0.50%
==========================================
Files 286 286
Lines 14492 14494 +2
Branches 3108 3047 -61
==========================================
+ Hits 8822 8895 +73
+ Misses 5625 5515 -110
- Partials 45 84 +39 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI hygiene problems on
main:issue-labels.yamlpinnedactions-ecosystem/action-add-labelsto a non-existent SHA (typo in commit8e53fa6b3), so every run failed at action download since 2026-06-18. Theactions-ecosystemactions are also unmaintained.GITHUB_TOKENscope instead of declaring minimal permissions.Decisions: Replace the three ecosystem actions with
github-scriptand the default token (issues: writeonly); drop the adminGH_TOKENdependency for this workflow. Add explicit minimal permissions per workflow (contents: read+actions: writewhere cache/artifacts are used). Fix a stale-bot message typo while touchingstale.yml.Remediation: Audited all failed labeler runs; only one had a missed action (closed-item comment on #8914), already posted manually.
Test plan
Needs Attention/ removeblocked: customer-response; OP reply on closed → standard bot comment)