Skip to content

chore(ci): grant pull-requests write to issue labeler workflow#9073

Merged
mikehardy merged 1 commit into
mainfrom
ci-fix-issue-labeler-permissions
Jun 24, 2026
Merged

chore(ci): grant pull-requests write to issue labeler workflow#9073
mikehardy merged 1 commit into
mainfrom
ci-fix-issue-labeler-permissions

Conversation

@mikehardy

Copy link
Copy Markdown
Collaborator

Description

Fixes a permissions regression from #9058 where issue-labels.yaml was scoped to issues: write only after replacing secrets.GH_TOKEN with the default GITHUB_TOKEN.

When a PR author replies on an open pull request, the labeler calls issues.addLabels / issues.removeLabel. GitHub requires pull-requests: write for PRs (403: Resource not accessible by integration; x-accepted-github-permissions: issues=write; pull_requests=write).

Adds pull-requests: write to match stale.yml in the same PR.

Related issues

Release Summary

N/A — CI workflow only.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/**/e2e
    • jest tests added or updated in packages/**/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  • Merge and post an OP comment on an open PR → expect Needs Attention added and blocked: customer-response removed
  • Post an OP comment on a closed/merged PR → expect standard bot comment (also needs pull-requests: write for createComment)

Missed label updates since #9058 merged (2026-06-20)

Audited 43 labeler runs since merge. 4 open-PR OP replies failed at the label step with 403; labels were not applied:

PR Title State Failed run
#9062 style(docs): lint fixes from docs.page audit MERGED run
#9063 docs: convert all code examples to modular API MERGED run
#9065 feat(ai): implement Firebase JS SDK 12.15.0 portable API parity MERGED run
#9068 docs(firestore): add pipelines overview and SDK compatibility pages OPEN run

Expected automation for each: add Needs Attention, remove blocked: customer-response (if present). None currently have labels.

Also failed (closed PR path, not labels): #9057 — OP comment on merged PR; bot reply not posted (run).

Issue-only OP replies succeeded (e.g. #9066, #9067, #9069) — issues: write is sufficient for issues.


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Labeling pull requests requires pull-requests: write, not just issues: write.
Regression from #9058 when GH_TOKEN was replaced with scoped GITHUB_TOKEN.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@mikehardy mikehardy merged commit 93310ce into main Jun 24, 2026
18 checks passed
@mikehardy mikehardy deleted the ci-fix-issue-labeler-permissions branch June 24, 2026 22:58
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.55%. Comparing base (cbe2593) to head (494fa6e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9073      +/-   ##
==========================================
+ Coverage   62.50%   63.55%   +1.06%     
==========================================
  Files         256      319      +63     
  Lines       12714    21883    +9169     
  Branches     3023     3932     +909     
==========================================
+ Hits         7945    13905    +5960     
- Misses       4755     7571    +2816     
- Partials       14      407     +393     
Flag Coverage Δ
e2e-ts-ios 65.01% <ø> (?)
ios-native 65.01% <ø> (?)
jest 62.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant