Skip to content

Commit 7a6e786

Browse files
maneeshtcabljac
maneesht
authored and
cabljac
committed
Fix tests
1 parent 802a853 commit 7a6e786

6 files changed

Lines changed: 110 additions & 110 deletions

File tree

‎dataconnect-sdk/js/default-connector/esm/index.esm.js‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,39 @@ export const connectorConfig = {
66
location: 'us-central1'
77
};
88

9+
export const listMoviesRef = (dc) => {
10+
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
11+
dcInstance._useGeneratedSdk();
12+
return queryRef(dcInstance, 'ListMovies');
13+
}
14+
listMoviesRef.operationName = 'ListMovies';
15+
16+
export function listMovies(dc) {
17+
return executeQuery(listMoviesRef(dc));
18+
}
19+
20+
export const getMovieByIdRef = (dcOrVars, vars) => {
21+
const { dc: dcInstance, vars: inputVars} = validateArgs(connectorConfig, dcOrVars, vars, true);
22+
dcInstance._useGeneratedSdk();
23+
return queryRef(dcInstance, 'GetMovieById', inputVars);
24+
}
25+
getMovieByIdRef.operationName = 'GetMovieById';
26+
27+
export function getMovieById(dcOrVars, vars) {
28+
return executeQuery(getMovieByIdRef(dcOrVars, vars));
29+
}
30+
31+
export const getMetaRef = (dc) => {
32+
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
33+
dcInstance._useGeneratedSdk();
34+
return queryRef(dcInstance, 'GetMeta');
35+
}
36+
getMetaRef.operationName = 'GetMeta';
37+
38+
export function getMeta(dc) {
39+
return executeQuery(getMetaRef(dc));
40+
}
41+
942
export const createMovieRef = (dcOrVars, vars) => {
1043
const { dc: dcInstance, vars: inputVars} = validateArgs(connectorConfig, dcOrVars, vars, true);
1144
dcInstance._useGeneratedSdk();
@@ -61,36 +94,3 @@ export function deleteMeta(dcOrVars, vars) {
6194
return executeMutation(deleteMetaRef(dcOrVars, vars));
6295
}
6396

64-
export const listMoviesRef = (dc) => {
65-
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
66-
dcInstance._useGeneratedSdk();
67-
return queryRef(dcInstance, 'ListMovies');
68-
}
69-
listMoviesRef.operationName = 'ListMovies';
70-
71-
export function listMovies(dc) {
72-
return executeQuery(listMoviesRef(dc));
73-
}
74-
75-
export const getMovieByIdRef = (dcOrVars, vars) => {
76-
const { dc: dcInstance, vars: inputVars} = validateArgs(connectorConfig, dcOrVars, vars, true);
77-
dcInstance._useGeneratedSdk();
78-
return queryRef(dcInstance, 'GetMovieById', inputVars);
79-
}
80-
getMovieByIdRef.operationName = 'GetMovieById';
81-
82-
export function getMovieById(dcOrVars, vars) {
83-
return executeQuery(getMovieByIdRef(dcOrVars, vars));
84-
}
85-
86-
export const getMetaRef = (dc) => {
87-
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
88-
dcInstance._useGeneratedSdk();
89-
return queryRef(dcInstance, 'GetMeta');
90-
}
91-
getMetaRef.operationName = 'GetMeta';
92-
93-
export function getMeta(dc) {
94-
return executeQuery(getMetaRef(dc));
95-
}
96-

‎dataconnect-sdk/js/default-connector/index.cjs.js‎

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,42 @@ const connectorConfig = {
77
};
88
exports.connectorConfig = connectorConfig;
99

10+
const listMoviesRef = (dc) => {
11+
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
12+
dcInstance._useGeneratedSdk();
13+
return queryRef(dcInstance, 'ListMovies');
14+
}
15+
listMoviesRef.operationName = 'ListMovies';
16+
exports.listMoviesRef = listMoviesRef;
17+
18+
exports.listMovies = function listMovies(dc) {
19+
return executeQuery(listMoviesRef(dc));
20+
};
21+
22+
const getMovieByIdRef = (dcOrVars, vars) => {
23+
const { dc: dcInstance, vars: inputVars} = validateArgs(connectorConfig, dcOrVars, vars, true);
24+
dcInstance._useGeneratedSdk();
25+
return queryRef(dcInstance, 'GetMovieById', inputVars);
26+
}
27+
getMovieByIdRef.operationName = 'GetMovieById';
28+
exports.getMovieByIdRef = getMovieByIdRef;
29+
30+
exports.getMovieById = function getMovieById(dcOrVars, vars) {
31+
return executeQuery(getMovieByIdRef(dcOrVars, vars));
32+
};
33+
34+
const getMetaRef = (dc) => {
35+
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
36+
dcInstance._useGeneratedSdk();
37+
return queryRef(dcInstance, 'GetMeta');
38+
}
39+
getMetaRef.operationName = 'GetMeta';
40+
exports.getMetaRef = getMetaRef;
41+
42+
exports.getMeta = function getMeta(dc) {
43+
return executeQuery(getMetaRef(dc));
44+
};
45+
1046
const createMovieRef = (dcOrVars, vars) => {
1147
const { dc: dcInstance, vars: inputVars} = validateArgs(connectorConfig, dcOrVars, vars, true);
1248
dcInstance._useGeneratedSdk();
@@ -66,39 +102,3 @@ exports.deleteMetaRef = deleteMetaRef;
66102
exports.deleteMeta = function deleteMeta(dcOrVars, vars) {
67103
return executeMutation(deleteMetaRef(dcOrVars, vars));
68104
};
69-
70-
const listMoviesRef = (dc) => {
71-
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
72-
dcInstance._useGeneratedSdk();
73-
return queryRef(dcInstance, 'ListMovies');
74-
}
75-
listMoviesRef.operationName = 'ListMovies';
76-
exports.listMoviesRef = listMoviesRef;
77-
78-
exports.listMovies = function listMovies(dc) {
79-
return executeQuery(listMoviesRef(dc));
80-
};
81-
82-
const getMovieByIdRef = (dcOrVars, vars) => {
83-
const { dc: dcInstance, vars: inputVars} = validateArgs(connectorConfig, dcOrVars, vars, true);
84-
dcInstance._useGeneratedSdk();
85-
return queryRef(dcInstance, 'GetMovieById', inputVars);
86-
}
87-
getMovieByIdRef.operationName = 'GetMovieById';
88-
exports.getMovieByIdRef = getMovieByIdRef;
89-
90-
exports.getMovieById = function getMovieById(dcOrVars, vars) {
91-
return executeQuery(getMovieByIdRef(dcOrVars, vars));
92-
};
93-
94-
const getMetaRef = (dc) => {
95-
const { dc: dcInstance} = validateArgs(connectorConfig, dc, undefined);
96-
dcInstance._useGeneratedSdk();
97-
return queryRef(dcInstance, 'GetMeta');
98-
}
99-
getMetaRef.operationName = 'GetMeta';
100-
exports.getMetaRef = getMetaRef;
101-
102-
exports.getMeta = function getMeta(dc) {
103-
return executeQuery(getMetaRef(dc));
104-
};

‎dataconnect-sdk/js/default-connector/index.d.ts‎

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,42 @@ export interface UpsertMovieVariables {
9393
imageUrl: string;
9494
}
9595

96+
interface ListMoviesRef {
97+
/* Allow users to create refs without passing in DataConnect */
98+
(): QueryRef<ListMoviesData, undefined>;
99+
/* Allow users to pass in custom DataConnect instances */
100+
(dc: DataConnect): QueryRef<ListMoviesData, undefined>;
101+
operationName: string;
102+
}
103+
export const listMoviesRef: ListMoviesRef;
104+
105+
export function listMovies(): QueryPromise<ListMoviesData, undefined>;
106+
export function listMovies(dc: DataConnect): QueryPromise<ListMoviesData, undefined>;
107+
108+
interface GetMovieByIdRef {
109+
/* Allow users to create refs without passing in DataConnect */
110+
(vars: GetMovieByIdVariables): QueryRef<GetMovieByIdData, GetMovieByIdVariables>;
111+
/* Allow users to pass in custom DataConnect instances */
112+
(dc: DataConnect, vars: GetMovieByIdVariables): QueryRef<GetMovieByIdData, GetMovieByIdVariables>;
113+
operationName: string;
114+
}
115+
export const getMovieByIdRef: GetMovieByIdRef;
116+
117+
export function getMovieById(vars: GetMovieByIdVariables): QueryPromise<GetMovieByIdData, GetMovieByIdVariables>;
118+
export function getMovieById(dc: DataConnect, vars: GetMovieByIdVariables): QueryPromise<GetMovieByIdData, GetMovieByIdVariables>;
119+
120+
interface GetMetaRef {
121+
/* Allow users to create refs without passing in DataConnect */
122+
(): QueryRef<GetMetaData, undefined>;
123+
/* Allow users to pass in custom DataConnect instances */
124+
(dc: DataConnect): QueryRef<GetMetaData, undefined>;
125+
operationName: string;
126+
}
127+
export const getMetaRef: GetMetaRef;
128+
129+
export function getMeta(): QueryPromise<GetMetaData, undefined>;
130+
export function getMeta(dc: DataConnect): QueryPromise<GetMetaData, undefined>;
131+
96132
interface CreateMovieRef {
97133
/* Allow users to create refs without passing in DataConnect */
98134
(vars: CreateMovieVariables): MutationRef<CreateMovieData, CreateMovieVariables>;
@@ -153,39 +189,3 @@ export const deleteMetaRef: DeleteMetaRef;
153189
export function deleteMeta(vars: DeleteMetaVariables): MutationPromise<DeleteMetaData, DeleteMetaVariables>;
154190
export function deleteMeta(dc: DataConnect, vars: DeleteMetaVariables): MutationPromise<DeleteMetaData, DeleteMetaVariables>;
155191

156-
interface ListMoviesRef {
157-
/* Allow users to create refs without passing in DataConnect */
158-
(): QueryRef<ListMoviesData, undefined>;
159-
/* Allow users to pass in custom DataConnect instances */
160-
(dc: DataConnect): QueryRef<ListMoviesData, undefined>;
161-
operationName: string;
162-
}
163-
export const listMoviesRef: ListMoviesRef;
164-
165-
export function listMovies(): QueryPromise<ListMoviesData, undefined>;
166-
export function listMovies(dc: DataConnect): QueryPromise<ListMoviesData, undefined>;
167-
168-
interface GetMovieByIdRef {
169-
/* Allow users to create refs without passing in DataConnect */
170-
(vars: GetMovieByIdVariables): QueryRef<GetMovieByIdData, GetMovieByIdVariables>;
171-
/* Allow users to pass in custom DataConnect instances */
172-
(dc: DataConnect, vars: GetMovieByIdVariables): QueryRef<GetMovieByIdData, GetMovieByIdVariables>;
173-
operationName: string;
174-
}
175-
export const getMovieByIdRef: GetMovieByIdRef;
176-
177-
export function getMovieById(vars: GetMovieByIdVariables): QueryPromise<GetMovieByIdData, GetMovieByIdVariables>;
178-
export function getMovieById(dc: DataConnect, vars: GetMovieByIdVariables): QueryPromise<GetMovieByIdData, GetMovieByIdVariables>;
179-
180-
interface GetMetaRef {
181-
/* Allow users to create refs without passing in DataConnect */
182-
(): QueryRef<GetMetaData, undefined>;
183-
/* Allow users to pass in custom DataConnect instances */
184-
(dc: DataConnect): QueryRef<GetMetaData, undefined>;
185-
operationName: string;
186-
}
187-
export const getMetaRef: GetMetaRef;
188-
189-
export function getMeta(): QueryPromise<GetMetaData, undefined>;
190-
export function getMeta(dc: DataConnect): QueryPromise<GetMetaData, undefined>;
191-

‎dataconnect-sdk/js/default-connector/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@
2020
"./package.json": "./package.json"
2121
},
2222
"peerDependencies": {
23-
"firebase": "^10.14.0 || ^11.3.0"
23+
"firebase": "^10.14.0 || ^11.3.0 || ^12.0.0"
2424
}
2525
}

‎packages/angular/src/data-connect/injectDataConnectMutation.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { provideHttpClient } from "@angular/common/http";
2-
import { provideExperimentalZonelessChangeDetection } from "@angular/core";
2+
import { provideZonelessChangeDetection } from "@angular/core";
33
import { TestBed } from "@angular/core/testing";
44
import { initializeApp, provideFirebaseApp } from "@angular/fire/app";
55
import {
@@ -44,7 +44,7 @@ describe("injectDataConnectMutation", () => {
4444
invalidateQueriesSpy = vi.spyOn(queryClient, "invalidateQueries");
4545
TestBed.configureTestingModule({
4646
providers: [
47-
provideExperimentalZonelessChangeDetection(), // Required as angularfire's ZoneScheduler breaks tests.
47+
provideZonelessChangeDetection(), // Required as angularfire's ZoneScheduler breaks tests.
4848
provideFirebaseApp(() => initializeApp({ projectId: "p" })),
4949
provideDataConnect(() => {
5050
const dc = getDataConnect(connectorConfig);

‎packages/angular/src/data-connect/injectDataConnectQuery.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { provideHttpClient } from "@angular/common/http";
22
import {
33
inject,
4-
provideExperimentalZonelessChangeDetection,
4+
provideZonelessChangeDetection,
55
} from "@angular/core";
66
import { TestBed } from "@angular/core/testing";
77
import { initializeApp, provideFirebaseApp } from "@angular/fire/app";
@@ -35,7 +35,7 @@ describe("injectDataConnectQuery", () => {
3535
queryClient.clear();
3636
TestBed.configureTestingModule({
3737
providers: [
38-
provideExperimentalZonelessChangeDetection(), // Required as angularfire's ZoneScheduler breaks tests.
38+
provideZonelessChangeDetection(), // Required as angularfire's ZoneScheduler breaks tests.
3939
provideFirebaseApp(() => initializeApp({ projectId: "p" })),
4040
provideDataConnect(() => {
4141
const dc = getDataConnect(connectorConfig);

0 commit comments

Comments
 (0)