Skip to content

feat(react): support firebase v12 - #210

Merged
cabljac merged 1 commit into
mainfrom
@invertase/firebase-12-react
Aug 26, 2025
Merged

feat(react): support firebase v12#210
cabljac merged 1 commit into
mainfrom
@invertase/firebase-12-react

Conversation

@cabljac

@cabljac cabljac commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

This PR adds support for firebase v12 in the react package.

  • added a temporary CI to run tests against firebase v12
  • removed caches from CI temporarily because of npm incident

@changeset-bot

changeset-bot Bot commented Aug 26, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 40976b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tanstack-query-firebase/react Minor
react-example Patch
useGetIdTokenQuery Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@docs-page

docs-page Bot commented Aug 26, 2025

Copy link
Copy Markdown

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~210

Documentation is deployed and generated using docs.page.

@cabljac
cabljac force-pushed the @invertase/firebase-12-react branch 2 times, most recently from 48e22a2 to bb3583d Compare August 26, 2025 14:07
@cabljac
cabljac force-pushed the @invertase/firebase-12-react branch from bb3583d to 40976b3 Compare August 26, 2025 14:19
@cabljac
cabljac marked this pull request as ready for review August 26, 2025 14:31
Copilot AI review requested due to automatic review settings August 26, 2025 14:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Firebase v12 to the React package while maintaining backward compatibility with v11.3.0. The changes update peer dependencies, TypeScript configuration, and add testing infrastructure for the new Firebase version.

Key changes:

  • Updated Firebase peer dependency to support both v11.3.0 and v12.0.0
  • Upgraded TypeScript target from ES2015 to ES2020 to meet Firebase v12 requirements
  • Added dedicated CI workflow for testing Firebase v12 compatibility

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/package.json Updated Firebase peer dependency to include v12.0.0
packages/react/tsconfig.json Upgraded TypeScript target to ES2020 for Firebase v12 compatibility
.github/workflows/test-react-firebase-v12.yml Added new CI workflow to test React package with Firebase v12
.github/workflows/tests.yaml Removed pnpm cache setup steps to streamline CI
dataconnect-sdk/js/default-connector/index.cjs.js Reordered exports by moving query functions after mutation functions
dataconnect-sdk/js/default-connector/esm/index.esm.js Reordered exports by moving query functions after mutation functions
.changeset/firebase-v12-support.md Added changeset documenting the Firebase v12 support feature
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cabljac
cabljac merged commit 802e2f1 into main Aug 26, 2025
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from Approved [PR] to Done in [Cloud] Open Source P0 Aug 26, 2025
@cabljac
cabljac deleted the @invertase/firebase-12-react branch August 26, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants