Skip to content

chore(*): add dataconnect sdk to changeset ignore - #219

Merged
cabljac merged 1 commit into
mainfrom
@invertase/ignore-dataconnect-sdk
Aug 27, 2025
Merged

chore(*): add dataconnect sdk to changeset ignore#219
cabljac merged 1 commit into
mainfrom
@invertase/ignore-dataconnect-sdk

Conversation

@cabljac

@cabljac cabljac commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings August 27, 2025 14:06
@changeset-bot

changeset-bot Bot commented Aug 27, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2bff913

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "example-react-data-connect" depends on the ignored package "@dataconnect/default-connector", but "example-react-data-connect" is not being ignored. Please add "example-react-data-connect" to the `ignore` option.
The package "@tanstack-query-firebase/angular" depends on the ignored package "@dataconnect/default-connector", but "@tanstack-query-firebase/angular" is not being ignored. Please add "@tanstack-query-firebase/angular" to the `ignore` option.
The package "@tanstack-query-firebase/react" depends on the ignored package "@dataconnect/default-connector", but "@tanstack-query-firebase/react" is not being ignored. Please add "@tanstack-query-firebase/react" to the `ignore` option.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the dataconnect SDK package to the changeset ignore list to prevent it from being included in automated version management. The changes mark the default connector package as private and exclude it from changeset tracking.

  • Mark the default connector package as private
  • Add the package to changeset ignore configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
dataconnect-sdk/js/default-connector/package.json Adds "private": true to prevent npm publication
.changeset/config.json Adds @dataconnect/default-connector to ignore list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's release configuration to exclude the @dataconnect/default-connector package from automatic changelog generation and versioning by the changeset tool. Additionally, it explicitly marks the default-connector package as private, preventing its accidental publication.

Highlights

  • Changeset Configuration: The @dataconnect/default-connector package has been added to the ignore list in the .changeset/config.json file. This prevents changeset from generating changelog entries or version bumps for this specific package.
  • Package Privacy: The dataconnect-sdk/js/default-connector/package.json file now includes "private": true, indicating that this package is not intended for publication to a registry.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cabljac
cabljac force-pushed the @invertase/ignore-dataconnect-sdk branch from a4cdb1a to 2bff913 Compare August 27, 2025 14:07

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly configures the repository to ignore the @dataconnect/default-connector package from changeset versioning and marks it as private to prevent accidental publishing. The changes are sound. I've included one suggestion to use a glob pattern in the changeset configuration to make it more maintainable and automatically include any future packages under the @dataconnect scope.

Comment thread .changeset/config.json
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": ["example-*"]
"ignore": ["example-*", "@dataconnect/default-connector"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To make this configuration more robust and future-proof, consider using a glob pattern to ignore all packages under the @dataconnect scope. This will prevent the need to manually update this configuration file if more packages are added under this scope later.

Suggested change
"ignore": ["example-*", "@dataconnect/default-connector"]
"ignore": ["example-*", "@dataconnect/*"]

@cabljac
cabljac merged commit 9ea8c43 into main Aug 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants