Skip to content

Remove unnecessary decode from received package #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oguzhanogreden wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary decode from received package #158

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bce91e
Remove unnecessary decode from received package
oguzhanogreden May 26, 2017
eff7c68
Update setup.py
oguzhanogreden Feb 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions socketIO_client/parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,20 +121,15 @@ def _make_packet_prefix(packet):


def _read_packet_length(content, content_index):
while get_byte(content, content_index) != 0:
while content.decode()[content_index] != ':':
content_index += 1
content_index += 1
packet_length_string = ''
byte = get_byte(content, content_index)
while byte != 255:
packet_length_string += str(byte)
content_index += 1
byte = get_byte(content, content_index)
packet_length_string = content.decode()[0:content_index]

return content_index, int(packet_length_string)


def _read_packet_text(content, content_index, packet_length):
while get_byte(content, content_index) == 255:
while content.decode()[content_index] == ':':
content_index += 1
packet_text = content[content_index:content_index + packet_length]
return content_index + packet_length, packet_text