refactor(config): centralize provider configuration management

This change refactors provider configuration handling by introducing new SettingsManager methods for accessing active provider settings, API keys, base URLs, and models. The SuperAgent class now uses these centralized methods instead of directly accessing settings, ensuring consistent provider ID normalization and improved maintainability of configuration logic.

Author: involvex

CHANGELOG.md

@@ -1,3 +1,11 @@
+## [0.0.70](https://github.com/involvex/super-agent-cli/compare/v0.0.69...v0.0.70) (2026-01-30)
+
+### Features
+
+- **settings:** add zai models, update default to glm-4 ([231f2a2](https://github.com/involvex/super-agent-cli/commit/231f2a261c57ad253f9d1269ed94d6ab1310ca01))
+
+## [0.0.69](https://github.com/involvex/super-agent-cli/compare/v0.0.68...v0.0.69) (2026-01-30)
+
 ## [0.0.68](https://github.com/involvex/super-agent-cli/compare/v0.0.67...v0.0.68) (2026-01-30)
 
 ### Features

src/agent/super-agent.ts

@@ -68,38 +68,29 @@ export class SuperAgent extends EventEmitter {
   ) {
     super();
     const manager = getSettingsManager();
-    const settings = manager.loadUserSettings();
-    const activeProviderId = (settings.active_provider || "grok").toLowerCase();
-
-    const providerConfig = settings.providers[activeProviderId];
-    // Fallback if config is missing (shouldn't happen with defaults, but safety check)
-    const providerType = providerConfig?.provider || activeProviderId;
 
     // Resolve effective configuration
     // Command line args (constructor params) override settings
-    const effectiveApiKey = apiKey || providerConfig?.api_key || "";
-    // Ensure baseURL is undefined if empty string to let SDKs use defaults
-    let effectiveBaseURL =
-      baseURL ||
-      (providerConfig?.base_url ? providerConfig.base_url : undefined);
+    const activeConfig = manager.getActiveProviderConfig();
+    const activeProviderId = activeConfig?.id || "grok";
+    const providerType = activeConfig?.provider || activeProviderId;
+
+    const effectiveApiKey = apiKey || manager.getApiKey() || "";
+    let effectiveBaseURL = baseURL || manager.getBaseURL();
+    const effectiveModel = model || manager.getCurrentModel();
 
     // Cloudflare Workers AI specific handling
     if (
-      providerConfig?.provider === "workers-ai" &&
+      providerType === "workers-ai" &&
       effectiveBaseURL?.includes("{ACCOUNT_ID}")
     ) {
-      if (providerConfig.account_id) {
+      if (activeConfig?.account_id) {
         effectiveBaseURL = effectiveBaseURL.replace(
           "{ACCOUNT_ID}",
-          providerConfig.account_id,
+          activeConfig.account_id,
         );
       }
     }
-    const effectiveModel =
-      model ||
-      providerConfig?.model ||
-      providerConfig?.default_model ||
-      "grok-code-fast-1";
 
     this.maxToolRounds = maxToolRounds || 400;
 
@@ -231,26 +222,24 @@ Current working directory: ${process.cwd()}`,
    */
   public setProvider(providerId: string): void {
     const manager = getSettingsManager();
-    const settings = manager.loadUserSettings();
 
-    // Normalize provider ID
+    // Normalize provider ID and update active provider in settings
     const activeProviderId = (providerId || "grok").toLowerCase();
 
+    // Load config for this specific provider ID
+    const settings = manager.loadUserSettings();
     const providerConfig = settings.providers[activeProviderId];
-    if (!providerConfig) {
-      throw new Error(`Provider '${activeProviderId}' not configured.`);
-    }
+    const providerType = providerConfig?.provider || activeProviderId;
 
-    const providerType = providerConfig.provider || activeProviderId;
-    const effectiveApiKey = providerConfig.api_key || "";
-    let effectiveBaseURL = providerConfig.base_url || undefined;
+    const effectiveApiKey = providerConfig?.api_key || "";
+    let effectiveBaseURL = providerConfig?.base_url || undefined;
 
     // Cloudflare Workers AI specific handling
     if (
-      providerConfig.provider === "workers-ai" &&
+      providerType === "workers-ai" &&
       effectiveBaseURL?.includes("{ACCOUNT_ID}")
     ) {
-      if (providerConfig.account_id) {
+      if (providerConfig?.account_id) {
         effectiveBaseURL = effectiveBaseURL.replace(
           "{ACCOUNT_ID}",
           providerConfig.account_id,
@@ -259,8 +248,8 @@ Current working directory: ${process.cwd()}`,
     }
 
     const effectiveModel =
-      providerConfig.model ||
-      providerConfig.default_model ||
+      providerConfig?.model ||
+      providerConfig?.default_model ||
       "grok-code-fast-1";
 
     // Re-instantiate appropriate provider

src/utils/settings-manager.ts

@@ -312,6 +312,9 @@ export class SettingsManager {
     value: UserSettings[K],
   ): void {
     const settings = { [key]: value } as Partial<UserSettings>;
+    if (key === "active_provider" && typeof value === "string") {
+      settings.active_provider = value.toLowerCase();
+    }
     this.saveUserSettings(settings);
   }
 
@@ -372,7 +375,7 @@ export class SettingsManager {
 
   public getActiveProviderConfig(): ProviderConfig | undefined {
     const settings = this.getEffectiveSettings();
-    const active = settings.active_provider;
+    const active = (settings.active_provider || "grok").toLowerCase();
     return settings.providers?.[active];
   }
 
@@ -383,7 +386,7 @@ export class SettingsManager {
 
   public setCurrentModel(model: string): void {
     const settings = this.loadUserSettings();
-    const active = settings.active_provider;
+    const active = (settings.active_provider || "grok").toLowerCase();
     if (settings.providers && settings.providers[active]) {
       settings.providers[active].model = model;
       this.saveUserSettings(settings);