Merged
Conversation
Replace icon for astro-events
Replace icon for astro-events
# Conflicts: # src-editor/src/App.jsx
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # CHANGELOG_OLD.md # README.md # io-package.json # package.json
# Conflicts: # admin/assets/hostInit-fzxL8JAx.js # admin/assets/index-DDfrUhXZ.js # admin/custom/customComponents.js # admin/custom/customComponents.js.map # admin/custom/static/js/node_modules_react_index_js.60fb7d60.chunk.js # admin/custom/static/js/node_modules_react_index_js.60fb7d60.chunk.js.map # admin/custom/static/js/vendors-node_modules_emotion_cache_dist_emotion-cache_browser_esm_js.2d58366e.chunk.js.map # admin/custom/static/js/vendors-node_modules_leaflet_dist_leaflet-src_js.affb2096.chunk.js # admin/custom/static/js/vendors-node_modules_leaflet_dist_leaflet-src_js.affb2096.chunk.js.map # admin/custom/static/js/vendors-node_modules_mui_icons-material_esm_index_js-node_modules_mui_system_esm_DefaultProps-1adf53.6cbdb6c1.chunk.js.map # admin/custom/static/js/vendors-node_modules_react-color_es_index_js.39857f84.chunk.js # admin/mf-manifest.json # admin/remoteEntry.js # admin/tab.html # package.json # src-admin/eslint.config.mjs # src-admin/package.json # src-admin/src/Astro.jsx # src-admin/src/Components/Map.jsx # src-editor/package.json # src-editor/src/Components/RulesEditor/components/Blocks/ActionSendEmail.tsx # test/testFunctions.js
There was a problem hiding this comment.
Pull Request Overview
This PR primarily migrates parts of the codebase to TypeScript and cleans up legacy modules while updating configuration files for consistency. Key changes include:
- Removal of legacy files (ThemeProvider-Buvx5nSd.js and inheritsLoose‑VBbEsHHj.js) and the introduction of a new inheritsLoose‑DgfqekV3.js.
- Updates to module imports to reference new file names (e.g. createSvgIcon‑DMsh‑YeH.js, DefaultPropsProvider‑9qubdy‑V.js) and a migration of the back‑end to TypeScript.
- Various configuration and documentation updates including breaking changes (removal of the “require” module) and formatting improvements in workflow and dependabot files.
Reviewed Changes
Copilot reviewed 193 out of 193 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| admin/custom/assets/ThemeProvider‑Buvx5nSd.js | Removed legacy ThemeProvider; verify all components that reference it are updated. |
| admin/custom/assets/FilledInput‑BpuM_GyB.js | Updated imports and internal references to align with new DefaultPropsProvider naming. |
| admin/custom/assets/DefaultPropsProvider‑9qubdy‑V.js | Minor adjustments in import and comment formatting; no functional changes detected. |
| admin/assets/useTheme‑N2j2HWMZ.js | Updated import to use createSvgIcon‑DMsh‑YeH.js – ensure compatibility with new icon API. |
| admin/assets/inheritsLoose‑VBbEsHHj.js | File deletion; replaced by inheritsLoose‑DgfqekV3.js – verify that no references remain. |
| admin/assets/inheritsLoose‑DgfqekV3.js | New version of the inheritsLoose module; confirm all tests pass with the new implementation. |
| admin/assets/createSvgIcon‑DMsh‑YeH.js | Minor formatting and comment updates; no functional changes. |
| README.md | Expanded release notes detailing the TypeScript migration, breaking change, and prettier. |
| Various .github/workflows and config files | Minor formatting updates (e.g. quote style adjustments) for consistency across the repo. |
Comments suppressed due to low confidence (4)
admin/custom/assets/ThemeProvider-Buvx5nSd.js:1
- Ensure that the removal of ThemeProvider-Buvx5nSd.js is intentional and that any components or modules depending on it are updated to use the new theme management approach.
File deletion: the entire ThemeProvider-Buvx5nSd.js is removed
admin/assets/inheritsLoose-VBbEsHHj.js:1
- Confirm that the removal of inheritsLoose-VBbEsHHj.js is accompanied by a proper update in all references to use the new file inheritsLoose-DgfqekV3.js.
File deletion: the entire inheritsLoose-VBbEsHHj.js is removed
admin/assets/useTheme-N2j2HWMZ.js:1
- The import for createSvgIcon has been updated to use the new file. Please verify that the new API is compatible with all usages in the code and that no regressions occur.
import {q as t, u as s, T as m, E as u} from "./createSvgIcon-DMsh-YeH.js";
.github/workflows/test-and-release.yml:14
- [nitpick] The regex patterns in the GitHub workflow files have been reformatted with single quotes. Please double-check that the new quoting style does not affect pattern matching in the release pipeline.
- - "v?[0-9]+.[0-9]+.[0-9]+"
|
|
||
| * (@klein0r) Added possibility to escape chars in formatTimeDiff | ||
| * (@GermanBluefox) Back-end was migrated to TypeScript | ||
| * (@GermanBluefox) Breaking change: removed "require" module |
There was a problem hiding this comment.
The README has been updated with a breaking change note regarding the removal of the ‘require’ module. Ensure that this change is clearly communicated to all users and included in any migration documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.