Pie chart vertical legend: fixed call stack exception, and redesigned sizing logic for the legend.

Author: michelezanda

CHANGELOG_ION.md

@@ -1,5 +1,10 @@
 # plotly.js ION changelog
 
+## [1.33.1-ion36] -- 2020-05-18
+
+### Vertical legend in pie chart sizing caused call stack exception.
+
+
 ## [1.33.1-ion35] -- 2020-04-27
 
 ### Regression in ion31. Chart wrongly autosized at startup

dist_ion/plotly-ion.js

@@ -32811,7 +32811,7 @@ exports.svgAttrs = {
 var Plotly = require('./plotly');
 
 // package version injected by `npm run preprocess`
-exports.version = '1.33.1-ion35';
+exports.version = '1.33.1-ion36';
 
 // inject promise polyfill
 require('es6-promise').polyfill();
@@ -38109,8 +38109,9 @@ function buildSVGText(containerNode, str, gd, IONFormat) {
 
     // In case ION new line logic applies to the legend labels
     var numCharsInLabel = 17;
-    if (gd._fullLayout._hasPie && gd._fullLayout.legend && gd._fullLayout.legend.orientation === 'v' && gd._fullLayout.width > 220 && gd.data.length === 1) {
-        numCharsInLabel = 5 + Math.ceil((gd._fullLayout.width - 220)/25);
+
+    if (gd._fullLayout._hasPie && gd._fullLayout.legend && gd._fullLayout.legend.orientation === 'v' && gd._fullLayout.width > 170 && gd.data.length === 1) {
+        numCharsInLabel = 5 + Math.floor((gd._fullLayout.width - 170)/22);
     }
 
     // In case BR is already used for hovertooltip custom formatting
@@ -38129,7 +38130,7 @@ function buildSVGText(containerNode, str, gd, IONFormat) {
         } else  {
             strION = strION.substr(0, upToPos) + "<br>" + strION.substr(upToPos);
         }
-        if (strION.length > numCharsInLabel * 2) {
+        if (strION.length - 4 > numCharsInLabel * 2) {
             strION = strION.substr(0, (numCharsInLabel * 2) + 4 - 3 ) + "...";
         }
     } 

dist_ion/plotly-ion.min.js

@@ -1,6 +1,6 @@
 {
   "name": "plotly.js",
-  "version": "1.33.1-ion35",
+  "version": "1.33.1-ion36",
   "description": "The open source javascript graphing library that powers plotly",
   "license": "MIT",
   "main": "./lib/index.js",

package.json

@@ -12,4 +12,4 @@ var saneTopojson = require('sane-topojson');
 
 
 // package version injected by `npm run preprocess`
-exports.version = '1.33.1-ion35';exports.topojson = saneTopojson;
+exports.version = '1.33.1-ion36';exports.topojson = saneTopojson;

src/assets/geo_assets.js

@@ -15,7 +15,7 @@
 var Plotly = require('./plotly');
 
 // package version injected by `npm run preprocess`
-exports.version = '1.33.1-ion35';
+exports.version = '1.33.1-ion36';
 
 // inject promise polyfill
 require('es6-promise').polyfill();

src/core.js

@@ -428,8 +428,9 @@ function buildSVGText(containerNode, str, gd, IONFormat) {
 
     // In case ION new line logic applies to the legend labels
     var numCharsInLabel = 17;
-    if (gd._fullLayout._hasPie && gd._fullLayout.legend && gd._fullLayout.legend.orientation === 'v' && gd._fullLayout.width > 220 && gd.data.length === 1) {
-        numCharsInLabel = 5 + Math.ceil((gd._fullLayout.width - 220)/25);
+
+    if (gd._fullLayout._hasPie && gd._fullLayout.legend && gd._fullLayout.legend.orientation === 'v' && gd._fullLayout.width > 170 && gd.data.length === 1) {
+        numCharsInLabel = 5 + Math.floor((gd._fullLayout.width - 170)/22);
     }
 
     // In case BR is already used for hovertooltip custom formatting
@@ -448,7 +449,7 @@ function buildSVGText(containerNode, str, gd, IONFormat) {
         } else  {
             strION = strION.substr(0, upToPos) + "<br>" + strION.substr(upToPos);
         }
-        if (strION.length > numCharsInLabel * 2) {
+        if (strION.length - 4 > numCharsInLabel * 2) {
             strION = strION.substr(0, (numCharsInLabel * 2) + 4 - 3 ) + "...";
         }
     }