Skip to content

Commit ba68dad

Browse files
authored
chore: Update CI with fixes (#604)
* Remove old volta stuff * chore: Update CI to latest actions * add node 16 back
1 parent b60ec8d commit ba68dad

4 files changed

Lines changed: 8 additions & 15 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
node-version: [16.x, 18.x]
16+
node-version: [16.x, 18.x, 20.x]
1717
steps:
1818
- name: Use Node.js ${{ matrix.node-version }}
19-
uses: actions/setup-node@v1
19+
uses: actions/setup-node@v4
2020
with:
2121
node-version: ${{ matrix.node-version }}
22-
- uses: actions/checkout@v1
22+
- uses: actions/checkout@v4
2323
- name: npm install, build, and test
2424
env:
2525
CI: true

package-lock.json

Lines changed: 3 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,5 @@
9797
"@xmldom/xmldom": "0.7.7"
9898
}
9999
}
100-
},
101-
"volta": {
102-
"node": "16.13.2",
103-
"npm": "8.3.0"
104100
}
105-
}
101+
}

src/platforms/pwa/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ export class PwaAssetGenerator extends AssetGenerator {
366366
for (const icon of icons) {
367367
if (await pathExists(join(pwaDir, icon.src))) {
368368
const exists = !!pwaAssets.find(({ template: { width, height } }) => {
369-
return `${width}x${height}` === icon.sizes
369+
return `${width}x${height}` === icon.sizes;
370370
});
371371
if (!exists) {
372372
rmSync(join(pwaDir, icon.src));

0 commit comments

Comments
 (0)