deprecate(filesystem): deprecate downloadFile and add migration steps for file transfer plugin#2360
Merged
Merged
Conversation
… for file transfer plugin
Contributor
There was a problem hiding this comment.
Overall looks good!
We didn't add this in the context of the filesystem, but could we do changes that we did for geolocation in this PR as well? https://github.com/ionic-team/capacitor-plugins/pull/2304/files
Or do you prefer to open a separate PR for that?
Contributor
Author
There was a problem hiding this comment.
Maybe it should be a separate PR so we can also include the File Viewer plugin. What are your thoughts?
Contributor
There was a problem hiding this comment.
Sure fair enough!
OS-pedrogustavobilro
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.