fix(cli): Don't add kotlin plugin for Cordova plugins#8518
Merged
Conversation
jcesarmobile
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
markemer and
theproducer
markemer
reviewed
Jun 24, 2026
| export async function handleCordovaPluginsGradle(config: Config, cordovaPlugins: Plugin[]): Promise<void> { | ||
| const pluginsGradlePath = join(config.android.cordovaPluginsDirAbs, 'build.gradle'); | ||
| const kotlinNeeded = await kotlinNeededCheck(config, cordovaPlugins); | ||
| const kotlinVersionString = config.app.extConfig.cordova?.preferences?.GradlePluginKotlinVersion ?? '2.4.0'; |
Member
There was a problem hiding this comment.
This lint warning appears to be correct, Line 324 is the only place we use this.
markemer
requested changes
Jun 24, 2026
markemer
left a comment
markemer
left a comment
Member
There was a problem hiding this comment.
Just that one fix and I think we're good.
markemer
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Gradle 9, kotlin plugin is enabled, and causes issues to apply it, so remove all kotlin plugin related code from the CLI