Commit 02c1388
fix(tokens): fix usage on components and review scss architecture (#30368)
Issue number: internal
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
Added improvements on scss architecture, as identified on past
assessment, on multiple components.
Some of these changes resulted in snapshots differences, all reviewed
and expected:
- Button spinner - pics with no visual differences/false-positive.
- Item slider - difference due to updated typography token.
- Item - difference as is now using correct disabled styles tokens.
- searchbar: 1px difference on horizontal margin - expected - to start
using a more rounded value from a token.
- Tab/tab-button - difference as is now using correct typography token.
- Spinner/loading - this looks like a false positive, saw no visible
differences.
- Textarea - this looks like a false positive, saw no visible
differences.
- Typography - this looks like a false positive, saw no visible
differences.
## Does this introduce a breaking change?
- [x] Yes
- [ ] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->
---------
Co-authored-by: ionitron <hi@ionicframework.com>1 parent 1e7a84f commit 02c1388
723 files changed
Lines changed: 634 additions & 456 deletions
File tree
- core
- src
- components
- accordion-group
- test
- expand/accordion-group.e2e.ts-snapshots
- shape/accordion-group.e2e.ts-snapshots
- states/accordion-group.e2e.ts-snapshots
- accordion
- test
- basic/accordion.e2e.ts-snapshots
- multiple/accordion.e2e.ts-snapshots
- shape/accordion.e2e.ts-snapshots
- states/accordion.e2e.ts-snapshots
- avatar
- backdrop
- badge
- test
- basic/badge.e2e.ts-snapshots
- hint/badge.e2e.ts-snapshots
- hue/badge.e2e.ts-snapshots
- shape/badge.e2e.ts-snapshots
- size/badge.e2e.ts-snapshots
- button
- test
- basic/button.e2e.ts-snapshots
- clear/button.e2e.ts-snapshots
- outline/button.e2e.ts-snapshots
- shape/button.e2e.ts-snapshots
- spinner/button.e2e.ts-snapshots
- states/button.e2e.ts-snapshots
- card
- chip
- test
- basic/chip.e2e.ts-snapshots
- hue/chip.e2e.ts-snapshots
- shape/chip.e2e.ts-snapshots
- size/chip.e2e.ts-snapshots
- states/chip.e2e.ts-snapshots
- datetime/test/basic/datetime.e2e.ts-snapshots
- input-password-toggle
- input
- item-options
- item-option
- item-sliding/test
- basic/item-sliding.e2e.ts-snapshots
- hue/item-sliding.e2e.ts-snapshots
- icons/item-sliding.e2e.ts-snapshots
- shapes/item-sliding.e2e.ts-snapshots
- states/item-sliding.e2e.ts-snapshots
- item
- test
- disabled/item.e2e.ts-snapshots
- lines/item.e2e.ts-snapshots
- states/item.e2e.ts-snapshots
- list-header
- test/basic/list-header.e2e.ts-snapshots
- list
- test
- lines/list.e2e.ts-snapshots
- shape/list.e2e.ts-snapshots
- loading/test
- a11y/loading.e2e.ts-snapshots
- basic/loading.e2e.ts-snapshots
- modal
- test
- basic/modal.e2e.ts-snapshots
- shape/modal.e2e.ts-snapshots
- sheet/modal.e2e.ts-snapshots
- progress-bar
- test/basic/progress-bar.e2e.ts-snapshots
- radio
- test/item/radio.e2e.ts-snapshots
- range
- ripple-effect
- searchbar
- test/basic/searchbar.e2e.ts-snapshots
- select-modal/test/basic/select-modal.e2e.ts-snapshots
- select
- test/item/select.e2e.ts-snapshots
- spinner
- test
- color/spinner.e2e.ts-snapshots
- resize/spinner.e2e.ts-snapshots
- tab-bar/test
- basic/tab-bar.e2e.ts-snapshots
- expand/tab-bar.e2e.ts-snapshots
- shape/tab-bar.e2e.ts-snapshots
- tab-button
- test/shape
- tab-button.e2e.ts-snapshots
- textarea
- test/color/textarea.e2e.ts-snapshots
- title/test/basic/title.e2e.ts-snapshots
- toast
- toggle
- test/item/toggle.e2e.ts-snapshots
- css
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1707 | 1707 | | |
1708 | 1708 | | |
1709 | 1709 | | |
1710 | | - | |
1711 | 1710 | | |
1712 | 1711 | | |
1713 | | - | |
1714 | 1712 | | |
1715 | 1713 | | |
1716 | 1714 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
0 commit comments