Skip to content

Commit 1c14e34

Browse files
OS-jacobbellShaneK
andauthored
Apply suggestions from code review
Co-authored-by: Shane <shane@shanessite.net>
1 parent a678411 commit 1c14e34

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/actions/build-vue/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ runs:
2727
run: npm run build
2828
shell: bash
2929
working-directory: ./packages/vue
30-
- name: Clean core package.json
30+
- name: Clean package.json updates
3131
run: git checkout ./core/package.json ./packages/react/package.json
3232
shell: bash
3333
- name: 🔍 Check Diff

.github/workflows/actions/test-core-clean-build/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ runs:
1212
name: ionic-core
1313
path: ./core
1414
filename: CoreBuild.zip
15-
- name: Clean core package.json
15+
- name: Clean package.json updates
1616
run: git checkout ./core/package.json ./packages/react/package.json
1717
shell: bash
1818
- name: 🔍 Check Diff

.github/workflows/stencil-nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ jobs:
182182
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
183183
- name: Install Stencil React Output Target
184184
working-directory: ./packages/react
185-
run: npm i @stencil/react-output-target@${{ inputs.npm_release_tag_react_output_target }}
185+
run: npm i @stencil/react-output-target@${{ inputs.npm_release_tag_react_output_target || 'latest' }}
186186
shell: bash
187187
- uses: ./.github/workflows/actions/build-react
188188

0 commit comments

Comments
 (0)