Skip to content

Commit 5388749

Browse files
committed
docs(breaking): update to include spinner
1 parent cb80321 commit 5388749

1 file changed

Lines changed: 18 additions & 7 deletions

File tree

BREAKING.md

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ This is a comprehensive list of the breaking changes introduced in the major ver
1919
- [Card](#version-9x-card)
2020
- [Chip](#version-9x-chip)
2121
- [Grid](#version-9x-grid)
22+
- [Radio Group](#version-9x-radio-group)
23+
- [Spinner](#version-9x-spinner)
2224

2325
<h2 id="version-9x-components">Components</h2>
2426

@@ -38,12 +40,6 @@ This is a comprehensive list of the breaking changes introduced in the major ver
3840

3941
- The properties `pull` and `push` have been deprecated and no longer work. A similar look can be achieved with the newly added property `order`.
4042

41-
<h4 id="version-9x-radio-group">Radio Group</h4>
42-
43-
- Converted `ion-radio-group` to use [Shadow DOM](https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_shadow_DOM).<br/>
44-
If you were targeting the internals of `ion-radio-group` in your CSS, you will need to target the `supporting-text`, `helper-text` or `error-text` [Shadow Parts](https://ionicframework.com/docs/theming/css-shadow-parts) instead, or use the provided CSS Variables.<br/>
45-
Additionally, the `radio-group-wrapper` div element has been removed, causing slotted elements to be direct children of the `ion-radio-group`.
46-
4743
<h5>Example 1: Swap two columns</h5>
4844

4945
**Version up to 8.x**
@@ -140,4 +136,19 @@ To reorder two columns where column 1 has `size="9" push="3"` and column 2 has `
140136
</ion-col>
141137
</ion-row>
142138
</ion-grid>
143-
```
139+
```
140+
141+
<h4 id="version-9x-radio-group">Radio Group</h4>
142+
143+
- Converted `ion-radio-group` to use [Shadow DOM](https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_shadow_DOM).<br/>
144+
If you were targeting the internals of `ion-radio-group` in your CSS, you will need to target the `supporting-text`, `helper-text` or `error-text` [Shadow Parts](https://ionicframework.com/docs/theming/css-shadow-parts) instead, or use the provided CSS Variables.<br/>
145+
Additionally, the `radio-group-wrapper` div element has been removed, causing slotted elements to be direct children of the `ion-radio-group`.
146+
147+
<h4 id="version-9x-spinner">Spinner</h4>
148+
149+
- Component CSS variables have been removed. The component now utilizes the centralized Ionic Theming system. Global updates should be managed via the theme tokens file, while component-specific overrides are handled through localized CSS variables.
150+
- `--color` is replaced by `IonSpinner.color` for global styles and
151+
`--ion-spinner-color` for component-specific styles.
152+
- CSS classes now include the property name to improve clarity.
153+
- `.spinner-[spinner-name]``.spinner-name-[spinner-name]`
154+
- Specific theme classes (e.g., `ion-spinner.md`) are no longer supported. Style modifications based on the active theme must be implemented using theme tokens rather than direct class targeting.

0 commit comments

Comments
 (0)