Skip to content

Commit 8f1b005

Browse files
fix(accordion): update styles for ionic theme (#31023)
Issue number: resolves internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? There were several issues in the ionic theme which are resolved in this PR: - The last item of an accordion had a divider - The pressed state color did not match design specifications - Nested accordions did not have not have horizontal padding, causing the focus state to be different from the parent accordion ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> The following changes were made in the ionic theme: - Removed the divider from the final accordion item - Update the pressed state color to match design specifications - Add additional horizontal padding for nested accordion items ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information - [Basic Accordion Preview](https://ionic-framework-git-rou-11979-fix-accordian-styles-ionic1.vercel.app/src/components/accordion/test/basic?ionic:theme=ionic) - [Accordion States Preview](https://ionic-framework-git-rou-11979-fix-accordian-styles-ionic1.vercel.app/src/components/accordion/test/states?ionic:theme=ionic) - [Nested Accordion Preview](https://ionic-framework-git-rou-11979-fix-accordian-styles-ionic1.vercel.app/src/components/accordion/test/nested?ionic:theme=ionic) --------- Co-authored-by: ionitron <hi@ionicframework.com>
1 parent 807c701 commit 8f1b005

File tree

80 files changed

+18
-5
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

80 files changed

+18
-5
lines changed

0 commit comments

Comments
 (0)