Skip to content

Commit 966d6b2

Browse files
authored
fix(button): fixed target area size for all button sizes (#31007)
Issue number: resolves # --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? Now target area `min-height` for Ionic theme is set to the default size token size, which causes an issue when button size is **small**. ## What is the new behavior? By changing this to **inherit** target area will have now the parent height. ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent 8b44fb5 commit 966d6b2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

core/src/components/button/button.ionic.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
position: absolute;
2020

2121
height: 100%;
22-
min-height: globals.$ion-scale-1200;
22+
min-height: inherit;
2323

2424
transform: translateY(-50%);
2525

0 commit comments

Comments
 (0)