fix(react-router): removing previously required wait on tab click tests

Author: ShaneK

packages/react-router/test/base/tests/e2e/playwright/utils/test-utils.ts

@@ -69,12 +69,10 @@ export async function ionBackClick(page: Page, pageId: string): Promise<void> {
 }
 
 /**
- * Click a tab button by text. Includes a 500ms wait before clicking
- * to handle the timing issue with tab switches after forward navigation (FW-2800).
+ * Click a tab button by text.
  * Equivalent to Cypress `cy.ionTabClick(tabText)`.
  */
 export async function ionTabClick(page: Page, tabText: string): Promise<void> {
-  await page.waitForTimeout(500);
   await page.locator('ion-tab-button').filter({ hasText: tabText }).click({ force: true });
 }
 

packages/react-router/test/base/tests/e2e/support/commands.js

@@ -70,8 +70,6 @@ Cypress.Commands.add('ionMenuNav', (contains) => {
 });
 
 Cypress.Commands.add('ionTabClick', (tabText) => {
-  // TODO FW-2800: figure out how to get rid of this wait. Switching tabs after a forward nav to a details page needs it
-  cy.wait(500);
   cy.contains('ion-tab-button', tabText).click({ force: true });
 });