fix(tab-button): apply code review feedback v1

Author: gnbm

core/src/components/tab-button/test/states/tab-button.e2e.ts

@@ -80,3 +80,22 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, c
     });
   });
 });
+
+configs({ palettes: ['dark'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('tab-button: focused state in dark palette'), () => {
+    test('should not have visual regressions for focused tab button', async ({ page }) => {
+      await page.setContent(
+        `
+        <ion-tab-bar style="width: 300px">
+          <ion-tab-button href="#" class="ion-focused">
+            <ion-label>Favorites</ion-label>
+          </ion-tab-button>
+        </ion-tab-bar>
+        `,
+        config
+      );
+
+      await expect(page.locator('ion-tab-bar')).toHaveScreenshot(screenshot('tab-bar-focused-dark'));
+    });
+  });
+});

core/src/components/tabs/test/a11y/tab-button-dark-focused.e2e.ts

@@ -186,7 +186,7 @@ $lightest-text-color: $text-color;
     --ion-item-background: #1e1e1e;
     --ion-toolbar-background: #1f1f1f;
     --ion-tab-bar-background: #1f1f1f;
-    --ion-tab-bar-background-focused: #0b0b0b;
+    --ion-tab-bar-background-focused: #1b1b1b;
     --ion-card-background: #1e1e1e;
 
     /// Only the item borders should increase in contrast