Skip to content

Commit d46b0b1

Browse files
fix(datetime): stretch ion-buttons to fill space for ios (#30963)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `iOS` datetime buttons do not stretch to its available height. This can lead to style inconsistencies with `md`. <img width="926" height="444" alt="Screenshot 2026-02-23 at 10 35 10 AM" src="https://github.com/user-attachments/assets/79835a34-5039-4ed8-8ce8-fbb696258052" /> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The buttons fill in the available height. <img width="359" height="362" alt="Screenshot 2026-02-23 at 10 37 18 AM" src="https://github.com/user-attachments/assets/362410eb-ec0b-46c3-87c5-e92af659830d" /> - The arrows also line up with each other. <img width="806" height="590" alt="Screenshot 2026-02-23 at 10 30 17 AM" src="https://github.com/user-attachments/assets/31ab043c-858e-498b-a947-1f08bb6fb7a1" /> ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> [Preview](https://ionic-framework-git-datetime-ios-buttons-ionic1.vercel.app/src/components/datetime/test/basic/?ionic%3Amode=ios) --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
1 parent 682a17e commit d46b0b1

File tree

181 files changed

+3
-1
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

181 files changed

+3
-1
lines changed

core/src/components/datetime/datetime.ios.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@
5757
}
5858

5959
:host .calendar-action-buttons ion-buttons {
60-
@include padding($datetime-ios-padding * 0.5, 0, 0, 0);
60+
align-items: stretch;
61+
62+
height: 100%;
6163
}
6264

6365
:host .calendar-action-buttons ion-buttons ion-button {
761 Bytes
-690 Bytes
780 Bytes
-44 Bytes

0 commit comments

Comments
 (0)