Commit e4d7a6a
authored
chore(deps): unpin @stencil/react-output-target to ^1.5.2 (#31098)
Issue number: internal
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
`@stencil/react-output-target` is pinned to exactly `1.5.0` in
`core/package.json` and `packages/react/package.json`. This was a
defensive pin after `1.5.1` shipped a regression that dropped the
`Partial<C>` wrapper from `StencilProps`, which broke everything in our
react apps by [requiring all props to be
defined](https://github.com/ionic-team/ionic-framework/actions/runs/25007199736/job/73233599812?pr=30831).
Exact-pinning meant we couldn't pick up future patches in the `1.5.x`
line.
## What is the new behavior?
Both `package.json` ranges move to `^1.5.2`. Upstream fully reverted [PR
#788](stenciljs/output-targets#788) in
[`1.5.2`](https://github.com/stenciljs/output-targets/blob/main/packages/react/CHANGELOG.md),
so the generator emits `Components.${tag}` again and the runtime
restores `Partial<C>`. Regenerating
`packages/react/src/components/components.ts` against the `1.5.2`
generator and running prettier produces a file byte-identical to the one
committed under `1.5.0`, so the published shape is unchanged.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
The original break, the upstream conversation, and the rationale for
staying on the `1.5.x` line (rather than taking the new "errors on truly
required props" behavior) are all in the [PR #788
thread](stenciljs/output-targets#788).1 parent 150ba3a commit e4d7a6a
4 files changed
Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
0 commit comments