Skip to content

Commit fc0b992

Browse files
thetaPCthetaPC
committed
feat(item-divider): more cleanup
1 parent 89bcfb4 commit fc0b992

4 files changed

Lines changed: 2 additions & 58 deletions

File tree

‎core/src/components/item-divider/item-divider.interfaces.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,12 @@ export type IonItemDividerRecipe = {
6262
};
6363
};
6464

65+
// Default non-semantic states
6566
default?: {
6667
color?: string;
6768
};
6869

70+
// Any of the semantic colors like primary, secondary, etc.
6971
semantic?: {
7072
default?: {
7173
color?: string;

‎core/src/themes/ionic/default.tokens.ts‎

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,6 @@ export const defaultTheme: DefaultTheme = {
294294
},
295295

296296
leading: {
297-
// Targets `::slotted([slot="start"])`
298297
edge: {
299298
margin: {
300299
end: components.item.start.slot.margin.end,
@@ -303,15 +302,13 @@ export const defaultTheme: DefaultTheme = {
303302
},
304303

305304
trailing: {
306-
// Targets `::slotted([slot="end"])`
307305
edge: {
308306
margin: {
309307
start: components.item.end.slot.margin.start,
310308
},
311309
},
312310
},
313311

314-
// Targets `ion-label`
315312
label: {
316313
margin: {
317314
top: '13px',
@@ -321,7 +318,6 @@ export const defaultTheme: DefaultTheme = {
321318
},
322319
},
323320

324-
// Targets `ion-icon`
325321
icon: {
326322
font: {
327323
/**
@@ -336,7 +332,6 @@ export const defaultTheme: DefaultTheme = {
336332
},
337333

338334
leading: {
339-
// Targets `ion-icon[slot="start"]`
340335
edge: {
341336
margin: {
342337
top: components.item.icon.slot.margin.top,
@@ -347,7 +342,6 @@ export const defaultTheme: DefaultTheme = {
347342
},
348343

349344
trailing: {
350-
// Targets `ion-icon[slot="end"]`
351345
edge: {
352346
margin: {
353347
top: components.item.icon.slot.margin.top,
@@ -357,20 +351,17 @@ export const defaultTheme: DefaultTheme = {
357351
},
358352
},
359353

360-
// Default non-semantic states
361354
default: {
362355
color: components.item.icon.slot.color,
363356
},
364357

365-
// Any of the semantic colors like primary, secondary, etc.
366358
semantic: {
367359
default: {
368360
color: currentColor('contrast'),
369361
},
370362
},
371363
},
372364

373-
// Targets `ion-note`
374365
note: {
375366
align: {
376367
self: 'flex-start',
@@ -395,7 +386,6 @@ export const defaultTheme: DefaultTheme = {
395386
},
396387
},
397388

398-
// Targets `ion-avatar`
399389
avatar: {
400390
height: components.item.avatar.height,
401391
width: components.item.avatar.width,
@@ -406,7 +396,6 @@ export const defaultTheme: DefaultTheme = {
406396
},
407397

408398
leading: {
409-
// Targets `ion-avatar[slot="start"]`
410399
edge: {
411400
margin: {
412401
end: components.item.media.start.slot.margin.end,
@@ -415,7 +404,6 @@ export const defaultTheme: DefaultTheme = {
415404
},
416405

417406
trailing: {
418-
// Targets `ion-avatar[slot="end"]`
419407
edge: {
420408
margin: {
421409
start: components.item.media.end.slot.margin.start,
@@ -424,9 +412,7 @@ export const defaultTheme: DefaultTheme = {
424412
},
425413
},
426414

427-
// Targets `ion-thumbnail`
428415
thumbnail: {
429-
// TODO: switch from size to height and width
430416
height: components.item.thumbnail.height,
431417
width: components.item.thumbnail.width,
432418

@@ -436,7 +422,6 @@ export const defaultTheme: DefaultTheme = {
436422
},
437423

438424
leading: {
439-
// Targets `ion-thumbnail[slot="start"]`
440425
edge: {
441426
margin: {
442427
end: components.item.media.start.slot.margin.end,
@@ -445,7 +430,6 @@ export const defaultTheme: DefaultTheme = {
445430
},
446431

447432
trailing: {
448-
// Targets `ion-thumbnail[slot="end"]`
449433
edge: {
450434
margin: {
451435
start: components.item.media.end.slot.margin.start,
@@ -454,7 +438,6 @@ export const defaultTheme: DefaultTheme = {
454438
},
455439
},
456440

457-
// Targets `h1`
458441
header1: {
459442
margin: {
460443
top: 'var(--ion-spacing-0)',
@@ -464,7 +447,6 @@ export const defaultTheme: DefaultTheme = {
464447
},
465448
},
466449

467-
// Targets `h2`
468450
header2: {
469451
margin: {
470452
top: 'var(--ion-spacing-xxxs)',
@@ -474,7 +456,6 @@ export const defaultTheme: DefaultTheme = {
474456
},
475457
},
476458

477-
// Targets `h3`
478459
header3: {
479460
margin: {
480461
top: 'var(--ion-spacing-xxxs)',
@@ -484,7 +465,6 @@ export const defaultTheme: DefaultTheme = {
484465
},
485466
},
486467

487-
// Targets `h4`
488468
header4: {
489469
margin: {
490470
top: 'var(--ion-spacing-xxxs)',
@@ -494,7 +474,6 @@ export const defaultTheme: DefaultTheme = {
494474
},
495475
},
496476

497-
// Targets `h5`
498477
header5: {
499478
margin: {
500479
top: 'var(--ion-spacing-xxxs)',
@@ -504,7 +483,6 @@ export const defaultTheme: DefaultTheme = {
504483
},
505484
},
506485

507-
// Targets `h6`
508486
header6: {
509487
margin: {
510488
top: 'var(--ion-spacing-xxxs)',
@@ -514,7 +492,6 @@ export const defaultTheme: DefaultTheme = {
514492
},
515493
},
516494

517-
// Targets `p`
518495
paragraph: {
519496
color: components.item.paragraph.color,
520497
overflow: 'inherit',

‎core/src/themes/ios/default.tokens.ts‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,6 @@ export const defaultTheme: DefaultTheme = {
429429
},
430430

431431
leading: {
432-
// Targets `:host([slot="start"])`
433432
anchor: {
434433
margin: {
435434
top: components.item.slot.start.margin.top,
@@ -440,10 +439,8 @@ export const defaultTheme: DefaultTheme = {
440439
},
441440
},
442441

443-
// Targets `ion-icon`
444442
icon: {
445443
leading: {
446-
// Targets `ion-icon[slot="start"]`
447444
edge: {
448445
margin: {
449446
top: components.item.icon.slot.margin.top,
@@ -453,7 +450,6 @@ export const defaultTheme: DefaultTheme = {
453450
},
454451

455452
trailing: {
456-
// Targets `ion-icon[slot="end"]`
457453
edge: {
458454
margin: {
459455
top: components.item.icon.slot.margin.top,
@@ -463,7 +459,6 @@ export const defaultTheme: DefaultTheme = {
463459
},
464460
},
465461

466-
// Targets `h1`
467462
header1: {
468463
margin: {
469464
top: 'var(--ion-spacing-0)',
@@ -473,7 +468,6 @@ export const defaultTheme: DefaultTheme = {
473468
},
474469
},
475470

476-
// Targets `h2`
477471
header2: {
478472
margin: {
479473
top: 'var(--ion-spacing-0)',
@@ -482,15 +476,13 @@ export const defaultTheme: DefaultTheme = {
482476
start: 'var(--ion-spacing-0)',
483477
},
484478

485-
// Targets `:last-child`
486479
trailing: {
487480
margin: {
488481
bottom: 'var(--ion-spacing-0)',
489482
},
490483
},
491484
},
492485

493-
// Targets `h3`
494486
header3: {
495487
margin: {
496488
top: 'var(--ion-spacing-0)',
@@ -506,7 +498,6 @@ export const defaultTheme: DefaultTheme = {
506498
},
507499
},
508500

509-
// Targets `h4`
510501
header4: {
511502
margin: {
512503
top: 'var(--ion-spacing-0)',
@@ -522,7 +513,6 @@ export const defaultTheme: DefaultTheme = {
522513
},
523514
},
524515

525-
// Targets `h5`
526516
header5: {
527517
margin: {
528518
top: 'var(--ion-spacing-0)',
@@ -538,7 +528,6 @@ export const defaultTheme: DefaultTheme = {
538528
},
539529
},
540530

541-
// Targets `h6`
542531
header6: {
543532
margin: {
544533
top: 'var(--ion-spacing-0)',
@@ -554,7 +543,6 @@ export const defaultTheme: DefaultTheme = {
554543
},
555544
},
556545

557-
// Targets `p`
558546
paragraph: {
559547
color: components.item.paragraph.color,
560548
overflow: 'inherit',

0 commit comments

Comments
 (0)